You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-28] [$250] Android - Expense preview carousel does not scroll back after deleting expense #61555
Version Number: 9.1.41-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+300402kh@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Samsung Galaxy Z Fold 4 / Android 14 App Component: Money Requests
Action Performed:
Precondition:
Log in with Expensifail account.
Launch Expensify app.
Go to 1:1 DM.
Submit two expenses.
Scroll the carousel to the right to reveal the second expense.
Tap on the expense preview.
Long press on the second expense.
Tap dropdown > Delete.
Delete the expense.
Tap app back button.
Expected Result:
The expense preview carousel will auto scroll back to the first expense.
Actual Result:
The expense preview carousel does not auto scroll back to the first expense, which results in a blank view as the second expense is deleted.
changed the title [-]Android - Expense preview carousel does not scroll back after deleting expense[/-][+][$250] Android - Expense preview carousel does not scroll back after deleting expense[/+]on May 13, 2025
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other: Known platform bug
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: No specific PR caused this bug. This was a limitation of the FlatList on React native android.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Table report view permission is enabled and you are on Android hybrid app.
Test:
Create more than 1 money request on a chat
Scroll the expense preview list to the last item
Open the expense report
Delete one of the transaction
Go back
Verify the expense preview list doesn't show blank space
Activity
melvin-bot commentedon May 7, 2025
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon May 7, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The expense preview list doesn't adjust the scroll when the last item is deleted.
What is the root cause of that problem?
It's a known issue of FlatList RN on Android.
What changes do you think we should make in order to solve the problem?
We can apply a workaround by calling
scrollToEndwhen the end is reached AND an item is deleted.Details:
One way to know if an item is deleted is to detect if the content width reduces by storing both current and previous content width.
Then, in
onEndReached, if the width reduces, callscrollToEndto adjust the scroll position.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
melvin-bot commentedon May 12, 2025
@johncschuster Eep! 4 days overdue now. Issues have feelings too...
[-]Android - Expense preview carousel does not scroll back after deleting expense[/-][+][$250] Android - Expense preview carousel does not scroll back after deleting expense[/+]melvin-bot commentedon May 13, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021922399136504489350
melvin-bot commentedon May 13, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (
External)allroundexperts commentedon May 13, 2025
@bernhardoj's proposal looks good to me. Let's go with them.
🎀 👀 🎀 C+ reviewed
20 remaining items
johncschuster commentedon May 23, 2025
Payment Summary (to be issued after regression window has passed)
Contributor: @bernhardoj owed $250 via NewDot ✅
Contributor+: @allroundexperts owed $250 via NewDot
bernhardoj commentedon May 24, 2025
Requested in ND.
melvin-bot commentedon May 28, 2025
Payment Summary
Upwork Job
BugZero Checklist (@johncschuster)
johncschuster commentedon May 28, 2025
@allroundexperts can you complete the BZ Checklist above?
JmillsExpensify commentedon May 29, 2025
$250 approved for @bernhardoj
allroundexperts commentedon Jun 1, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: No specific PR caused this bug. This was a limitation of the FlatList on React native android.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Verify the expense preview list doesn't show blank space
Do we agree 👍 or 👎
johncschuster commentedon Jun 2, 2025
@allroundexperts please request payment via ND. Thank you!
JmillsExpensify commentedon Jun 13, 2025
$250 approved for @allroundexperts