Skip to content

Upgrade Modal Shows "$5 per Active Member" Instead of "$5 per Member" for Categories Pricing #61611

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.41-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

  1. Login as a new user and choose Track in onboarding
  2. Create a manual tracking expense
  3. Click "categorize it" in the self DM
  4. Observe the copy in upgrade modal displayed

Expected Result:

The Upgrade modal for categories should display pricing as "$5 per member"

Actual Result:

The Upgrade modal incorrectly displays pricing as "$5 per active member"

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Recording.1196.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 7, 2025
  2. melvin-bot commented on May 7, 2025

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nabi-ebrahimi commented on May 7, 2025

    @nabi-ebrahimi

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The Upgrade modal incorrectly displays pricing as "$5 per active member"

    What is the root cause of that problem?

    Incorrect text here

     pricing: {
                    perActiveMember: 'per active member per month.',
                },
    

    and here

     commonFeatures: {
                    title: 'Upgrade to the Control plan',
                    note: 'Unlock our most powerful features, including:',
                    benefits: {
                        startsAt: 'The Control plan starts at ',
                        perMember: 'per active member per month.',
                        learnMore: 'Learn more',
                        pricing: 'about our plans and pricing.',
                        benefit1: 'Advanced accounting connections (NetSuite, Sage Intacct, and more)',
                        benefit2: 'Smart expense rules',
                        benefit3: 'Multi-level approval workflows',
                        benefit4: 'Enhanced security controls',
                        toUpgrade: 'To upgrade, click',
                        selectWorkspace: 'select a workspace, and change the plan type to',
                    },
                },
    

    here

     yourPlan: {
                title: 'Your plan',
                exploreAllPlans: 'Explore all plans',
                customPricing: 'Custom pricing',
                asLowAs: ({price}: YourPlanPriceValueParams) => `as low as ${price} per active member/month`,
                pricePerMemberMonth: ({price}: YourPlanPriceValueParams) => `${price} per member/month`,
                pricePerMemberPerMonth: ({price}: YourPlanPriceValueParams) => `${price} per member per month`,
                perMemberMonth: 'per member/month',
    

    and here

     subscriptionSettings: {
                title: 'Subscription settings',
                summary: ({subscriptionType, subscriptionSize, autoRenew, autoIncrease}: SubscriptionSettingsSummaryParams) =>
                    `Subscription type: ${subscriptionType}, Subscription size: ${subscriptionSize}, Auto renew: ${autoRenew}, Auto increase annual seats: ${autoIncrease}`,
                none: 'none',
                on: 'on',
                off: 'off',
                annual: 'Annual',
                autoRenew: 'Auto-renew',
                autoIncrease: 'Auto-increase annual seats',
                saveUpTo: ({amountWithCurrency}: SubscriptionSettingsSaveUpToParams) => `Save up to ${amountWithCurrency}/month per active member`,
                automaticallyIncrease:
                    'Automatically increase your annual seats to accommodate for active members that exceed your subscription size. Note: This will extend your annual subscription end date.',
                disableAutoRenew: 'Disable auto-renew',
                helpUsImprove: 'Help us improve Expensify',
                whatsMainReason: "What's the main reason you're disabling auto-renew?",
                renewsOn: ({date}: SubscriptionSettingsRenewsOnParams) => `Renews on ${date}.`,
                pricingConfiguration: 'Pricing depends on configuration. For the lowest price, choose an annual subscription and get the Expensify Card.',
                learnMore: {
                    part1: 'Learn more on our ',
                    pricingPage: 'pricing page',
                    part2: ' or chat with our team in your ',
                    adminsRoom: '#admins room.',
                },
                estimatedPrice: 'Estimated price',
                changesBasedOn: 'This changes based on your Expensify Card usage and the subscription options below.',
            },
    

    What changes do you think we should make in order to solve the problem?

    Make them correct by replacing active member by member

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    N / A

  4. self-assigned this
    on May 7, 2025
  5. added
    ReviewingHas a PR in review
    and removed on May 9, 2025
  6. amyevans commented on May 9, 2025

    @amyevans
    Contributor

    PR up: #61812

  7. amyevans commented on May 20, 2025

    @amyevans
    Contributor

    Has been in prod for 5 days and no payments needed, so going to close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions