You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-22] [Due for payment 2025-05-20] Workspace - Searching for member using full name returns no result #61650
Version Number: 9.1.42-0 Reproducible in staging?: Yes Reproducible in production?: Unable to check, new feature If this was caught during regression testing, add the test name, ID and link from TestRail:#60488 Email or phone of affected tester (no customers):applausetester+300402kh@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Have a workspace with at least 16 members.
At least one member has first and last name.
Go to staging.new.expensify.com
Go to workspace settings > Members.
Search for the member with first and last name using the full name.
Expected Result:
The search result will return the member with the full name.
Actual Result:
The search result returns nothing when searching for member using full name.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
When a user searches for a member using a full name or partial full name (e.g., "Jane D" or "zarin 3"), the member is not returned unless the search query exactly matches one of the fields (text or alternateText). This results in unexpected behavior, where valid partial name matches do not appear in the search results.
What is the root cause of that problem?
The filtering logic only checks if the search query is found within either text or alternateText separately. It also lacks proper normalization of the data, so partial matches like "zarin 3" do not match "zarin 30" even though the beginning of the name clearly aligns. In addition, queries that span both the first and last name (e.g., "Jane D") also fail, because the match isn’t performed on a combined and normalized name string.
What changes do you think we should make in order to solve the problem?
⚠️@nabi-ebrahimi Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
changed the title [-]Workspace - Searching for member using full name returns no result[/-][+][Due for payment 2025-05-20] Workspace - Searching for member using full name returns no result[/+]on May 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@roryabraham@strepanier03@daledah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2025-05-20] Workspace - Searching for member using full name returns no result[/-][+][Due for payment 2025-05-22] [Due for payment 2025-05-20] Workspace - Searching for member using full name returns no result[/+]on May 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@roryabraham@strepanier03@daledah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 8, 2025
Triggered auto assignment to @cristipaval (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 8, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 8, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 8, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
daledah commentedon May 8, 2025
Coming from #60488, I'll open a follow-up soon.
nabi-ebrahimi commentedon May 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user searches for a member using a full name or partial full name (e.g.,
"Jane D"or"zarin 3"), the member is not returned unless the search query exactly matches one of the fields (textoralternateText). This results in unexpected behavior, where valid partial name matches do not appear in the search results.What is the root cause of that problem?
The filtering logic only checks if the search query is found within either
textoralternateTextseparately. It also lacks proper normalization of the data, so partial matches like"zarin 3"do not match"zarin 30"even though the beginning of the name clearly aligns. In addition, queries that span both the first and last name (e.g.,"Jane D") also fail, because the match isn’t performed on a combined and normalized name string.What changes do you think we should make in order to solve the problem?
Update the filterMember function to:
Concatenate both
textandalternateTextfields.Normalize the combined string and the user input by:
Then, check if the normalized query is included in the normalized combined string.
This approach ensures that partial and full-name queries like
"Jane D","zarin 3", or"Jane Sharifi"work reliably.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
github-actions commentedon May 8, 2025
21 remaining items
melvin-bot commentedon May 9, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon May 9, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]Workspace - Searching for member using full name returns no result[/-][+][Due for payment 2025-05-20] Workspace - Searching for member using full name returns no result[/+]melvin-bot commentedon May 13, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2025
@roryabraham @strepanier03 @daledah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2025-05-20] Workspace - Searching for member using full name returns no result[/-][+][Due for payment 2025-05-22] [Due for payment 2025-05-20] Workspace - Searching for member using full name returns no result[/+]melvin-bot commentedon May 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 15, 2025
@roryabraham @strepanier03 @daledah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]