Skip to content

[Due for payment 2025-05-22] [Due for payment 2025-05-20] Expensify Card - Card stays in member profile after the card is deactivated #61720

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6069055
Email or phone of affected tester (no customers): applausetester+080506kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Workspace has set up Expensify Card with bank account.
  • User has assigned themselves or any member a virtual Expensify card.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Members.
  3. Click on the member with Expensify card.
  4. Click on the card.
  5. Click Deactivate card.
  6. Deactivate the card.

Expected Result:

The card will be removed from member profile.

Actual Result:

The card stays in member profile after the card is deactivated.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @johncschuster

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 8, 2025
  2. melvin-bot commented on May 8, 2025

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 8, 2025

    @melvin-bot

    Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 8, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 8, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. samranahm commented on May 8, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Card stays in member profile after the card is deactivated

    What is the root cause of that problem?

    Here

    https://github.com/Expensify/App/blob/e2c5d7d0f34564e2e5d285d5bcde5a669164fc6c/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx#L374-L376

    we did not check if the card is inactive and display all card

    What changes do you think we should make in order to solve the problem?

    We should explicitly check for inactive card and return null

    const inactiveCard = cardList?.[memberCard.cardID];

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. 21 remaining items

  8. changed the title [-][Due for payment 2025-05-20] Expensify Card - Card stays in member profile after the card is deactivated[/-] [+][Due for payment 2025-05-22] [Due for payment 2025-05-20] Expensify Card - Card stays in member profile after the card is deactivated[/+] on May 15, 2025
  9. melvin-bot commented on May 15, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-22. 🎊

  10. melvin-bot commented on May 15, 2025

    @melvin-bot

    @cead22 @johncschuster @cead22 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. johncschuster commented on May 16, 2025

    @johncschuster
    Contributor

    @cead22 bump on my question above 🙏

  12. cead22 commented on May 16, 2025

    @cead22
    Contributor

    Sorry not sure how I missed it. That's correct

  13. johncschuster commented on May 19, 2025

    @johncschuster
    Contributor

    Sweet. Thank you!

  14. melvin-bot commented on May 22, 2025

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  15. melvin-bot commented on May 23, 2025

    @melvin-bot

    @johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. johncschuster commented on May 23, 2025

    @johncschuster
    Contributor

    Looks like we're good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions