You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-22] [Due for payment 2025-05-20] Expensify Card - Card stays in member profile after the card is deactivated #61720
Version Number: 9.1.42-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/6069055 Email or phone of affected tester (no customers):applausetester+080506kh@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Workspace has set up Expensify Card with bank account.
User has assigned themselves or any member a virtual Expensify card.
Go to staging.new.expensify.com
Go to workspace settings > Members.
Click on the member with Expensify card.
Click on the card.
Click Deactivate card.
Deactivate the card.
Expected Result:
The card will be removed from member profile.
Actual Result:
The card stays in member profile after the card is deactivated.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
we did not check if the card is inactive and display all card
What changes do you think we should make in order to solve the problem?
We should explicitly check for inactive card and return null
constinactiveCard=cardList?.[memberCard.cardID];
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][Due for payment 2025-05-20] Expensify Card - Card stays in member profile after the card is deactivated[/-][+][Due for payment 2025-05-22] [Due for payment 2025-05-20] Expensify Card - Card stays in member profile after the card is deactivated[/+]on May 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@cead22@johncschuster@cead22 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon May 8, 2025
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 8, 2025
Triggered auto assignment to @cead22 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 8, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 8, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
samranahm commentedon May 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Card stays in member profile after the card is deactivated
What is the root cause of that problem?
Here
https://github.com/Expensify/App/blob/e2c5d7d0f34564e2e5d285d5bcde5a669164fc6c/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx#L374-L376
we did not check if the card is inactive and display all card
What changes do you think we should make in order to solve the problem?
We should explicitly check for inactive card and return null
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
21 remaining items
[-][Due for payment 2025-05-20] Expensify Card - Card stays in member profile after the card is deactivated[/-][+][Due for payment 2025-05-22] [Due for payment 2025-05-20] Expensify Card - Card stays in member profile after the card is deactivated[/+]melvin-bot commentedon May 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-22. 🎊
melvin-bot commentedon May 15, 2025
@cead22 @johncschuster @cead22 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
johncschuster commentedon May 16, 2025
@cead22 bump on my question above 🙏
cead22 commentedon May 16, 2025
Sorry not sure how I missed it. That's correct
johncschuster commentedon May 19, 2025
Sweet. Thank you!
melvin-bot commentedon May 22, 2025
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
melvin-bot commentedon May 23, 2025
@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!
johncschuster commentedon May 23, 2025
Looks like we're good to go!