Skip to content

[Due for payment 2025-05-27] mweb - Reports - Bookmark menu is empty after saving search #61924

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.45-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+300402kh@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Reports
  3. Tap Filters
  4. Tap Expense type
  5. Select any type and tap Save
  6. Tap Save search
  7. Tap bookmark icon

Expected Result:

Menu will display with options

Actual Result:

Menu is empty

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6830015_1747159789105.Screen_Recording_20250514_020754_Chrome.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @adelekennedy

Activity

  1. melvin-bot commented on May 13, 2025

    @melvin-bot

    Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on May 13, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on May 13, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. nkdengineer commented on May 13, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Menu is empty

    What is the root cause of that problem?

    Offending PR: #60959

    We got error Uncaught ReferenceError: React is not defined. In useSearchTypeMenu file, ThreeDotsMenu component is being rendered in JSX syntax, which requires React to be in scope.

    rightComponent: (
    <ThreeDotsMenu
    menuItems={getOverflowMenu(baseMenuItem.title ?? '', Number(baseMenuItem.hash ?? ''), item.query ?? '')}
    anchorPosition={{horizontal: 0, vertical: 380}}
    anchorAlignment={{
    horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
    vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP,
    }}
    disabled={item.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE}
    />
    ),

    What changes do you think we should make in order to solve the problem?

    We can fix this by adding the React import

        import React, {useCallback, useEffect, useMemo, useState} from 'react';
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. aldo-expensify commented on May 13, 2025

    @aldo-expensify
    Contributor

    Thanks @nkdengineer , I think you are right, reverting that PR fixes the issue.

    cc @OlimpiaZurek @rushatgabhane

  6. aldo-expensify commented on May 13, 2025

    @aldo-expensify
    Contributor

    @nkdengineer 's proposed fix sounds better than just reverting, specially considering how simple it is. I'll put up a PR.

  7. nkdengineer commented on May 13, 2025

    @nkdengineer
    Contributor

    @aldo-expensify I can help to raise a PR now

  8. aldo-expensify commented on May 13, 2025

    @aldo-expensify
    Contributor

    @nkdengineer I appreciate the help, but I'll handle this internally since it is a very simple fix.

  9. 11 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 20, 2025
  11. changed the title [-]mweb - Reports - Bookmark menu is empty after saving search[/-] [+][Due for payment 2025-05-27] mweb - Reports - Bookmark menu is empty after saving search[/+] on May 20, 2025
  12. melvin-bot commented on May 20, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on May 20, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-27. 🎊

  14. melvin-bot commented on May 20, 2025

    @melvin-bot

    @aldo-expensify @adelekennedy @aldo-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. melvin-bot commented on May 27, 2025

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  16. adelekennedy commented on May 27, 2025

    @adelekennedy
    Contributor

    Upwork payment made!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions