You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-27] mweb - Reports - Bookmark menu is empty after saving search #61924
Version Number: 9.1.45-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):applausetester+300402kh@applause.expensifail.com Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to Reports
Tap Filters
Tap Expense type
Select any type and tap Save
Tap Save search
Tap bookmark icon
Expected Result:
Menu will display with options
Actual Result:
Menu is empty
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6830015_1747159789105.Screen_Recording_20250514_020754_Chrome.mp4
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
We got error Uncaught ReferenceError: React is not defined. In useSearchTypeMenu file, ThreeDotsMenu component is being rendered in JSX syntax, which requires React to be in scope.
What changes do you think we should make in order to solve the problem?
We can fix this by adding the React import
import React, {useCallback, useEffect, useMemo, useState} from 'react';
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]mweb - Reports - Bookmark menu is empty after saving search[/-][+][Due for payment 2025-05-27] mweb - Reports - Bookmark menu is empty after saving search[/+]on May 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@aldo-expensify@adelekennedy@aldo-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon May 13, 2025
Triggered auto assignment to @aldo-expensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon May 13, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon May 13, 2025
💬 A slack conversation has been started in #expensify-open-source
nkdengineer commentedon May 13, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Menu is empty
What is the root cause of that problem?
Offending PR: #60959
We got error
Uncaught ReferenceError: React is not defined. InuseSearchTypeMenufile,ThreeDotsMenucomponent is being rendered in JSX syntax, which requires React to be in scope.App/src/hooks/useSearchTypeMenu.tsx
Lines 155 to 165 in 2239609
What changes do you think we should make in order to solve the problem?
We can fix this by adding the React import
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
aldo-expensify commentedon May 13, 2025
Thanks @nkdengineer , I think you are right, reverting that PR fixes the issue.
cc @OlimpiaZurek @rushatgabhane
aldo-expensify commentedon May 13, 2025
@nkdengineer 's proposed fix sounds better than just reverting, specially considering how simple it is. I'll put up a PR.
nkdengineer commentedon May 13, 2025
@aldo-expensify I can help to raise a PR now
aldo-expensify commentedon May 13, 2025
@nkdengineer I appreciate the help, but I'll handle this internally since it is a very simple fix.
11 remaining items
[-]mweb - Reports - Bookmark menu is empty after saving search[/-][+][Due for payment 2025-05-27] mweb - Reports - Bookmark menu is empty after saving search[/+]melvin-bot commentedon May 20, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-27. 🎊
melvin-bot commentedon May 20, 2025
@aldo-expensify @adelekennedy @aldo-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon May 27, 2025
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
adelekennedy commentedon May 27, 2025
Upwork payment made!