Repository navigation
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.45-15
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #61764
Issue reported by: Applause - Internal Team
Action Performed:
Precondition: account has several expenses with receipts
- Navigate to Reports
2 Make sure you are in Expenses or Expense reports
Expected Result:
The loading spinner displayed for receipt thumbnails.
Default BG color fill for the thumbnail area, and use a 20x20 spinner in the middle of the thumbnail area for these
Actual Result:
No loading spinner displayed for receipt thumbnails
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6831198_1747239274940.bandicam_2025-05-14_18-50-12-819.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021922808396648832547
- Upwork Job ID: 1922808396648832547
- Last Price Increase: 2025-05-15
- Automatic offers:
- Krishna2323 | Contributor | 107398010
Issue Owner
Current Issue Owner: @jliexpensifyMetadata
Metadata
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor
Activity
melvin-bot commentedon May 14, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.M00rish commentedon May 14, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-05-14 22:45:33 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Reports - No spinner on receipt thumbnail
What is the root cause of that problem?
no mechanism for showing spinner while loading :
App/src/components/Image/index.tsx
Lines 138 to 156 in f65da19
What changes do you think we should make in order to solve the problem?
add onLoading state to ReceiptImage :
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
UI issue
What alternative solutions did you explore? (Optional)
add check in Image component based on prop :
jliexpensify commentedon May 15, 2025
cc @Expensify/design to confirm the expected result:
[-]Reports - No spinner on receipt thumbnail[/-][+][$250] Reports - No spinner on receipt thumbnail[/+]melvin-bot commentedon May 15, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021922808396648832547
melvin-bot commentedon May 15, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)dubielzyk-expensify commentedon May 15, 2025
I think we're in the process of fixing this one on another issue. @shawnborton is involved in it, so I'll let him comment.
shawnborton commentedon May 15, 2025
Yeah, we do indeed have another issue for this: #61073
cc @Valforte @nkdengineer @dominictb for extra eyes
jliexpensify commentedon May 15, 2025
Oh cool, should we close this one?
46 remaining items
melvin-bot commentedon Jun 27, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 27, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.71-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-07-04. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 27, 2025
@sobitneupane @jliexpensify @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
jliexpensify commentedon Jul 4, 2025
Bump @sobitneupane for the checklist!
Payment Summary - #62036 (comment)
jliexpensify commentedon Jul 4, 2025
New Upworks job - https://www.upwork.com/jobs/~021940972380530554971
huult commentedon Jul 4, 2025
@jliexpensify accepted your offer
sobitneupane commentedon Jul 4, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Transactions - Update Generic Receipts to use ReceiptBackground #34843
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
jliexpensify commentedon Jul 6, 2025
Paid and job closed.
jliexpensify commentedon Jul 6, 2025
@sobitneupane payment summary here
laurenreidexpensify commentedon Aug 7, 2025
$250 approved in New Expensify for @sobitneupane
trjExpensify commentedon Aug 14, 2025
$250 approved in NewDot for @sobitneupane.
(We changed approvers so this bounced to me!)