Skip to content

[Due for payment 2025-06-02] [$250] Tap back button on detail expense if deleting expense should return to Workspace chat #62075

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.45-18
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #60292
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Android 13 / Xiaomi Poco F5, iOS 15.8.3 / iPhone 7 Plus, Chrome / Android 13
App Component: Other

Action Performed:

  1. Log in with a Gmail account
  2. Open any workspace/1-1 chat
  3. Submit two expenses
  4. Open the detail expense of any expense
  5. Tap the More button and tap Delete
  6. Tap Delete again on the confirmation modal
  7. Tap the app back button on the expense detail

Expected Result:

Tap the back button on the detail expense after delete expense should return to the Workspace chat

Actual Result:

Tap the back button on the detail expense after deleting the expense will navigate to the detail expense again

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021923009602603456361
  • Upwork Job ID: 1923009602603456361
  • Last Price Increase: 2025-05-15
Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 15, 2025
  2. melvin-bot commented on May 15, 2025

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 15, 2025

    @melvin-bot

    Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on May 15, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on May 15, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. PiyushChandra17 commented on May 15, 2025

    @PiyushChandra17
    Contributor

    Working on this one :)

  7. MariaHCD commented on May 15, 2025

    @MariaHCD
    Contributor

    👋🏼 @PiyushChandra17 we haven't made this external yet 🤔

  8. MariaHCD commented on May 15, 2025

    @MariaHCD
    Contributor

    @VickyStash looks like your PR was reverted and you're working on a new one here: #62080

    Is this bug related to your changes in the original PR? If so, is it something that will be fixed in your new PR? :)

  9. 32 remaining items

  10. changed the title [-][$250] Tap back button on detail expense if deleting expense should return to Workspace chat[/-] [+][Due for payment 2025-06-02] [$250] Tap back button on detail expense if deleting expense should return to Workspace chat[/+] on May 26, 2025
  11. melvin-bot commented on May 26, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on May 26, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.51-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-02. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on May 26, 2025

    @melvin-bot

    @allroundexperts @isabelastisser @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. isabelastisser commented on May 28, 2025

    @isabelastisser
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  15. isabelastisser commented on May 28, 2025

    @isabelastisser
    Contributor

    @allroundexperts, please complete the BZ checklist, thanks!

  16. allroundexperts commented on Jun 1, 2025

    @allroundexperts
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/59999/files#r2119598535

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • N/A

    Test:

    1. Log in with a Gmail account
    2. Open any workspace/1-1 chat
    3. Submit two expenses
    4. Open the detail expense of any expense
    5. Tap the More button and tap Delete
    6. Tap Delete again on the confirmation modal
    7. Tap the app back button on the expense detail

    Make sure that you are redirected to the workspace chat.

    Do we agree 👍 or 👎

  17. melvin-bot commented on Jun 2, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Reviewer: @allroundexperts owed $250 via NewDot
    • Contributor: @WojtekBoman is from an agency-contributor and not due payment
    • Contributor: @SzymczakJ is from an agency-contributor and not due payment

    BugZero Checklist (@isabelastisser)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1923009602603456361/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  18. isabelastisser commented on Jun 2, 2025

    @isabelastisser
    Contributor

    Payment summary:

    Reviewer: @allroundexperts owed $250 via NewDot for c+ review pending

  19. JmillsExpensify commented on Jun 13, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions