Skip to content

[Due for payment 2025-07-23] [$175] Expense - Unable to add unreported expense to IOU report #62179

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.46-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+160503kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Account has self DM.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Track a manual expense.
  4. Open FAB > Create expense > Manual.
  5. Submit a manual expense to any user (not workspace).
  6. In 1:1 DM, click on the expense preview.
  7. Click More.
  8. Click Add expense > Add unreported expense.
  9. Select the track expense from Step 3.
  10. Click Add to report.

Expected Result:

The track expense will be added to IOU without issue.

Actual Result:

The track expense cannot be added to IOU,
The IOU report shows the added track expense briefly and then it is removed from IOU report.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6832642_1747357414271.20250516_085907.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021924847533389997024
  • Upwork Job ID: 1924847533389997024
  • Last Price Increase: 2025-07-23
Issue OwnerCurrent Issue Owner: @rayane-d

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 16, 2025
  2. melvin-bot commented on May 16, 2025

    @melvin-bot

    Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. twilight2294 commented on May 16, 2025

    @twilight2294
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Unable to add unreported expense to IOU report

    What is the root cause of that problem?

    We cannot add unreported expenses to IOU reports, we can add unreported expenses to only EXPENSE reports, this is what can be concluded from the API response.

    What changes do you think we should make in order to solve the problem?

    We should hide the Add unreported expenses option from the list, if the type of report is IOU:

    {
    value: CONST.REPORT.ADD_EXPENSE_OPTIONS.ADD_UNREPORTED_EXPENSE,
    text: translate('iou.addUnreportedExpense'),
    icon: Expensicons.ReceiptPlus,
    onSelected: () => {
    openUnreportedExpense(iouReport?.reportID);
    },
    },

    {
    value: CONST.REPORT.ADD_EXPENSE_OPTIONS.ADD_UNREPORTED_EXPENSE,
    text: translate('iou.addUnreportedExpense'),
    icon: Expensicons.ReceiptPlus,
    onSelected: () => {
    openUnreportedExpense(moneyRequestReport?.reportID);
    },

    {
    value: CONST.REPORT.ADD_EXPENSE_OPTIONS.ADD_UNREPORTED_EXPENSE,
    text: translate('iou.addUnreportedExpense'),
    icon: Expensicons.ReceiptPlus,
    onSelected: () => {
    openUnreportedExpense(iouReport?.reportID);

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A minor UI bug, alternatively we can render the list and verify that the option is not present if the report is IOU

    What alternative solutions did you explore? (Optional)

  4. melvin-bot commented on May 19, 2025

    @melvin-bot

    @lydiabarclay Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. twilight2294 commented on May 20, 2025

    @twilight2294
    Contributor

    @lydiabarclay can you make this issue external please

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 20, 2025
  7. changed the title [-]Expense - Unable to add unreported expense to IOU report[/-] [+][$250] Expense - Unable to add unreported expense to IOU report[/+] on May 20, 2025
  8. melvin-bot commented on May 20, 2025

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 20, 2025
  10. melvin-bot commented on May 20, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  11. 79 remaining items

  12. MariaHCD commented on Jul 23, 2025

    @MariaHCD
    Contributor

    @MariaHCD This PR caused a regression in staging but I was wondering if we could keep the original price was this was a bit complex. Let me know what you think?

    @mananjadhav 👋🏼 Could you share what specifically felt complex about this issue - was it the logic in the PR itself or something during the review? I just want to better understand the reasoning for keeping the original price given that there was a regression.

    That said, I do understand how it could have been easy to miss the need to use isIOUReport vs isMoneyRequestReport

  13. mananjadhav commented on Jul 23, 2025

    @mananjadhav
    Collaborator

    Thanks for responding @MariaHCD. More than complex to QA because it was a bit tedious checking every field and param of the optimistic data including the variations and on different platforms. Had to test against the participants records, transaction params different values, different currency getMoneyRequestInformation and convertParams. With that I missed checking isIOUReport check as I was more focused on the params stored in the optimistic data and the API calls.

  14. MariaHCD commented on Jul 23, 2025

    @MariaHCD
    Contributor

    @mananjadhav thanks for the clarification! I completely understand that carefully reviewing and testing this PR was a time-consuming and detailed process. That said, I do think the regression was due to a business logic error in the PR itself that required closer review.

    With that in mind, instead of a 50% reduction of the payment due to the regression, we’ll adjust the payment to $175. I believe this is still a fair amount considering the effort you put in, while also accounting for the regression.

    cc: @lydiabarclay

  15. changed the title [-][Due for payment 2025-07-23] [$250] Expense - Unable to add unreported expense to IOU report[/-] [+][Due for payment 2025-07-23] [$175] Expense - Unable to add unreported expense to IOU report[/+] on Jul 23, 2025
  16. melvin-bot commented on Jul 23, 2025

    @melvin-bot

    Upwork job price has been updated to $175

  17. mananjadhav commented on Jul 23, 2025

    @mananjadhav
    Collaborator

    Thanks for the consideration @MariaHCD

  18. lydiabarclay commented on Jul 23, 2025

    @lydiabarclay
    Contributor

    Payment Summary

    Contributor: @rayane-d does not require payment (hourly)
    Contributor+: @mananjadhav due $175 via NewDot

    ✅ Regression test filed

  19. MariaHCD commented on Jul 24, 2025

    @MariaHCD
    Contributor

    @lydiabarclay - since @rayane-d is an external backend contributor, he does not need separate payment for this one.

  20. lydiabarclay commented on Jul 25, 2025

    @lydiabarclay
    Contributor

    Updated!

  21. garrettmknight commented on Aug 1, 2025

    @garrettmknight
    Contributor

    $175 approved for @mananjadhav

  22. flaviadefaria commented on Aug 4, 2025

    @flaviadefaria
    Contributor

    $175 approved for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions