You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-07-23] [$175] Expense - Unable to add unreported expense to IOU report #62179
Version Number: 9.1.46-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+160503kh@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Log in with Expensifail account.
Account has self DM.
Go to staging.new.expensify.com
Go to self DM.
Track a manual expense.
Open FAB > Create expense > Manual.
Submit a manual expense to any user (not workspace).
In 1:1 DM, click on the expense preview.
Click More.
Click Add expense > Add unreported expense.
Select the track expense from Step 3.
Click Add to report.
Expected Result:
The track expense will be added to IOU without issue.
Actual Result:
The track expense cannot be added to IOU,
The IOU report shows the added track expense briefly and then it is removed from IOU report.
Please re-state the problem that we are trying to solve in this issue.
Unable to add unreported expense to IOU report
What is the root cause of that problem?
We cannot add unreported expenses to IOU reports, we can add unreported expenses to only EXPENSE reports, this is what can be concluded from the API response.
What changes do you think we should make in order to solve the problem?
We should hide the Add unreported expenses option from the list, if the type of report is IOU:
changed the title [-]Expense - Unable to add unreported expense to IOU report[/-][+][$250] Expense - Unable to add unreported expense to IOU report[/+]on May 20, 2025
@MariaHCD This PR caused a regression in staging but I was wondering if we could keep the original price was this was a bit complex. Let me know what you think?
@mananjadhav 👋🏼 Could you share what specifically felt complex about this issue - was it the logic in the PR itself or something during the review? I just want to better understand the reasoning for keeping the original price given that there was a regression.
That said, I do understand how it could have been easy to miss the need to use isIOUReport vs isMoneyRequestReport
Thanks for responding @MariaHCD. More than complex to QA because it was a bit tedious checking every field and param of the optimistic data including the variations and on different platforms. Had to test against the participants records, transaction params different values, different currency getMoneyRequestInformation and convertParams. With that I missed checking isIOUReport check as I was more focused on the params stored in the optimistic data and the API calls.
@mananjadhav thanks for the clarification! I completely understand that carefully reviewing and testing this PR was a time-consuming and detailed process. That said, I do think the regression was due to a business logic error in the PR itself that required closer review.
With that in mind, instead of a 50% reduction of the payment due to the regression, we’ll adjust the payment to $175. I believe this is still a fair amount considering the effort you put in, while also accounting for the regression.
changed the title [-][Due for payment 2025-07-23] [$250] Expense - Unable to add unreported expense to IOU report[/-][+][Due for payment 2025-07-23] [$175] Expense - Unable to add unreported expense to IOU report[/+]on Jul 23, 2025
Activity
melvin-bot commentedon May 16, 2025
Triggered auto assignment to @lydiabarclay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.twilight2294 commentedon May 16, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Unable to add unreported expense to IOU report
What is the root cause of that problem?
We cannot add unreported expenses to IOU reports, we can add unreported expenses to only
EXPENSEreports, this is what can be concluded from the API response.What changes do you think we should make in order to solve the problem?
We should hide the
Add unreported expensesoption from the list, if the type of report isIOU:App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
Lines 474 to 481 in 9e0ae4f
App/src/components/MoneyReportHeader.tsx
Lines 451 to 457 in 9e0ae4f
App/src/components/ReportActionItem/ReportPreview.tsx
Lines 515 to 520 in 9e0ae4f
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A minor UI bug, alternatively we can render the list and verify that the option is not present if the report is IOU
What alternative solutions did you explore? (Optional)
melvin-bot commentedon May 19, 2025
@lydiabarclay Whoops! This issue is 2 days overdue. Let's get this updated quick!
twilight2294 commentedon May 20, 2025
@lydiabarclay can you make this issue external please
[-]Expense - Unable to add unreported expense to IOU report[/-][+][$250] Expense - Unable to add unreported expense to IOU report[/+]melvin-bot commentedon May 20, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021924847533389997024
melvin-bot commentedon May 20, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)79 remaining items
MariaHCD commentedon Jul 23, 2025
@mananjadhav 👋🏼 Could you share what specifically felt complex about this issue - was it the logic in the PR itself or something during the review? I just want to better understand the reasoning for keeping the original price given that there was a regression.
That said, I do understand how it could have been easy to miss the need to use
isIOUReportvsisMoneyRequestReportmananjadhav commentedon Jul 23, 2025
Thanks for responding @MariaHCD. More than complex to QA because it was a bit tedious checking every field and param of the optimistic data including the variations and on different platforms. Had to test against the participants records, transaction params different values, different currency
getMoneyRequestInformationand convertParams. With that I missed checkingisIOUReportcheck as I was more focused on the params stored in the optimistic data and the API calls.MariaHCD commentedon Jul 23, 2025
@mananjadhav thanks for the clarification! I completely understand that carefully reviewing and testing this PR was a time-consuming and detailed process. That said, I do think the regression was due to a business logic error in the PR itself that required closer review.
With that in mind, instead of a 50% reduction of the payment due to the regression, we’ll adjust the payment to $175. I believe this is still a fair amount considering the effort you put in, while also accounting for the regression.
cc: @lydiabarclay
[-][Due for payment 2025-07-23] [$250] Expense - Unable to add unreported expense to IOU report[/-][+][Due for payment 2025-07-23] [$175] Expense - Unable to add unreported expense to IOU report[/+]melvin-bot commentedon Jul 23, 2025
Upwork job price has been updated to $175
mananjadhav commentedon Jul 23, 2025
Thanks for the consideration @MariaHCD
lydiabarclay commentedon Jul 23, 2025
Payment Summary
Contributor: @rayane-d does not require payment (hourly)
Contributor+: @mananjadhav due $175 via NewDot
✅ Regression test filed
MariaHCD commentedon Jul 24, 2025
@lydiabarclay - since @rayane-d is an external backend contributor, he does not need separate payment for this one.
lydiabarclay commentedon Jul 25, 2025
Updated!
garrettmknight commentedon Aug 1, 2025
$175 approved for @mananjadhav
flaviadefaria commentedon Aug 4, 2025
$175 approved for @mananjadhav