Skip to content

[Due for payment 2025-08-26] [$250] Recent search history missing when opening search switcher before app reconnects #62335

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): #Quality

Action Performed:

  1. Open the app
  2. Immediately tap on the search switcher
  3. Observe that the page is empty — no recent history is shown
  4. Wait 20+ seconds for the app to finish reconnecting
  5. Tap the search switcher again — recent history is now visible.

Expected Result:

Recent search history should load instantly, even if the app is still reconnecting in the background.

Actual Result:

Recent search history does not appear until the app completes reconnecting.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021927051599348689449
  • Upwork Job ID: 1927051599348689449
  • Last Price Increase: 2025-06-02
Issue OwnerCurrent Issue Owner: @strepanier03

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 19, 2025
  2. melvin-bot commented on May 19, 2025

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 23, 2025

    @melvin-bot

    @strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  4. moved this from HIGH to CRITICAL in [#whatsnext] #qualityon May 26, 2025
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 26, 2025
  6. changed the title [-]Recent search history missing when opening search switcher before app reconnects[/-] [+][$250] Recent search history missing when opening search switcher before app reconnects[/+] on May 26, 2025
  7. melvin-bot commented on May 26, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 26, 2025
  9. melvin-bot commented on May 26, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

  10. 84 remaining items

  11. changed the title [-][$250] Recent search history missing when opening search switcher before app reconnects[/-] [+][Due for payment 2025-08-26] [$250] Recent search history missing when opening search switcher before app reconnects[/+] on Aug 19, 2025
  12. melvin-bot commented on Aug 19, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.96-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-08-26. 🎊

    For reference, here are some details about the assignees on this issue:

    • @sosek108 does not require payment (Contractor)
    • @DylanDylann requires payment through NewDot Manual Requests
  13. melvin-bot commented on Aug 19, 2025

    @melvin-bot

    @DylanDylann @strepanier03 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. melvin-bot commented on Aug 26, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @sosek108 is from an agency-contributor and not due payment
    • Reviewer: @DylanDylann owed $250 via NewDot

    BugZero Checklist (@strepanier03)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1927051599348689449/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  15. strepanier03 commented on Aug 28, 2025

    @strepanier03
    Contributor

    @DylanDylann - Checklist when you have a sec!

  16. DylanDylann commented on Aug 28, 2025

    @DylanDylann
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug: This looks like a performance improvement
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: This looks like a performance improvement

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Log in to application
    2. While app is reconnecting open Search modal with 🔍 icon
    3. observe autocomplete list
    4. it should show skeleton if no data is available
    5. recent searches should be visible while reconnecting
    6. all items are visible after app loaded fully

    Do we agree 👍 or 👎

  17. strepanier03 commented on Aug 28, 2025

    @strepanier03
    Contributor

    Thanks @DylanDylann payment summary is above!

  18. garrettmknight commented on Oct 29, 2025

    @garrettmknight
    Contributor

    $250 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions