Skip to content

[Due for payment 2025-06-05] [$50] When editing distance on confirm page & select different user, old amount & distance are shown #62444

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.47-5
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): sddsnsduhisudh2@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Account has self DM.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Track a distance expense.
  4. Click Submit it to someone.
  5. Select a user.
  6. On confirmation page, click Distance.
  7. Edit the waypoints and save it.
  8. Click app back button to go back to Share list.
  9. Select another user.
  10. Note that the new amount and distance are shown on the confirmation page.
  11. Click app back button.
  12. Select the same user from Step 9.

Expected Result:

The new amount and distance are shown on the confirmation page after selecting a different user (production behavior).

Actual Result:

The original amount and distance are shown on the confirmation page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6837674_1747795433317.20250521_104027.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021925153234080405615
  • Upwork Job ID: 1925153234080405615
  • Last Price Increase: 2025-05-21
Issue OwnerCurrent Issue Owner: @strepanier03

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on May 21, 2025
  2. melvin-bot commented on May 21, 2025

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 21, 2025

    @melvin-bot

    Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 21, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 21, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. mollfpr commented on May 21, 2025

    @mollfpr
    Contributor

    @mitarachim I can't reproduce the issue. Could you test again? Thanks!

  7. mitarachim commented on May 21, 2025

    @mitarachim
    Author

    Hello @mollfpr , i still could reproduce this issue using build v9.1.47-5

    Screen.Recording.2025-05-21.at.3.12.35.PM.mov
  8. 32 remaining items

  9. melvin-bot commented on May 29, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-05. 🎊

    For reference, here are some details about the assignees on this issue:

    • @VickyStash does not require payment (Contractor)
    • @dukenv0307 requires payment through NewDot Manual Requests
  10. melvin-bot commented on May 29, 2025

    @melvin-bot

    @dukenv0307 @strepanier03 @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. melvin-bot commented on Jun 5, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @VickyStash is from an agency-contributor and not due payment
    • Reviewer: @dukenv0307 owed $250 via NewDot

    BugZero Checklist (@strepanier03)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1925153234080405615/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. strepanier03 commented on Jun 5, 2025

    @strepanier03
    Contributor

    @dukenv0307 - Wanna finish up the checklist? When I make the reg test, I'll remove the hold from the payment summary below.

  13. strepanier03 commented on Jun 5, 2025

    @strepanier03
    Contributor

    @dukenv0307 @VickyStash -- Actually, the GH title says $50 and the payment comment says $250? Anyone have context on that they can share?

  14. dukenv0307 commented on Jun 6, 2025

    @dukenv0307
    Contributor

    @strepanier03 I think we can do nothing here because it's our regression.

  15. melvin-bot commented on Jun 9, 2025

    @melvin-bot

    @strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. strepanier03 commented on Jun 9, 2025

    @strepanier03
    Contributor

    Aaah, got it. So no paymen,t but how about a reg test @dukenv0307? Will we need to make one of those? If not, then let's close this otherwise we can keep it open until the reg test steps are added, and I can finish up the GH for that.

  17. dukenv0307 commented on Jun 9, 2025

    @dukenv0307
    Contributor

    @strepanier03 i think we can close it

  18. strepanier03 commented on Jun 10, 2025

    @strepanier03
    Contributor

    Thanks @dukenv0307 feel free to reopen or ping me in Slack if anything changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions