Skip to content

[Due for payment 2025-06-02] [Due for payment 2025-05-30] [$250][$25 for offending PR link] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page #62506

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.48-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): sjdiojdsoisdjsoi@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Go offline
  4. Click + > Create expense > Manual
  5. Enter amount > Next
  6. On confirmation page, enter merchant
  7. Click Show more
  8. Disable Reimbursable toggle
  9. Submit the expense
  10. Go to transaction thread

Expected Result:

Reimbursable toggle should be disabled because it is disabled on the confirmation page

Actual Result:

Reimbursable toggle is enabled when it is disabled on the confirmation page

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6838554_1747855042027.reimbursable.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021925299076161716076
  • Upwork Job ID: 1925299076161716076
  • Last Price Increase: 2025-05-21
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on May 21, 2025

    @melvin-bot

    Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. melvin-bot commented on May 21, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on May 21, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 21, 2025
  5. changed the title [-]Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/-] [+][$250] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/+] on May 21, 2025
  6. melvin-bot commented on May 21, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 21, 2025
  8. melvin-bot commented on May 21, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

  9. 25 remaining items

  10. mallenexpensify commented on May 23, 2025

    @mallenexpensify
    Contributor

    Thx, paid, updated post above.

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 23, 2025
  12. changed the title [-][$250][$25 for offending PR link] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/-] [+][Due for payment 2025-05-30] [$250][$25 for offending PR link] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/+] on May 23, 2025
  13. melvin-bot commented on May 23, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-30. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on May 23, 2025

    @melvin-bot

    @allroundexperts @mallenexpensify @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. changed the title [-][Due for payment 2025-05-30] [$250][$25 for offending PR link] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/-] [+][Due for payment 2025-06-02] [Due for payment 2025-05-30] [$250][$25 for offending PR link] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/+] on May 26, 2025
  16. melvin-bot commented on May 26, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.51-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-02. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on May 26, 2025

    @melvin-bot

    @allroundexperts @mallenexpensify @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  18. allroundexperts commented on Jun 1, 2025

    @allroundexperts
    Contributor

    I did not review the PR here as it was a straight revert (so no payment due for me). A checklist isn't needed as well because of the same reason.

  19. nabi-ebrahimi commented on Jun 3, 2025

    @nabi-ebrahimi

    Bit to unpack here.

    1. @Krishna2323 is due $25 smackers for finding the offending PR, thx.
    2. The offending PR that was identified by @Krishna2323 was reverted.
    3. Because Help Wanted was added, is compensation due? Our (current) policy is

    If we decide to close the job before it is successfully completed
    50% payment to contributor and C+ if the contributor was hired/assigned.
    50% payment if the contributor wasn't assigned and

    1. The bug was fixed by a different PR
    2. The proposal was 🎀👀🎀 by the C+, and
    3. Most of the code used in the fix came from the accepted proposal

    For this instance, since the code wasn't used at all, compensation isn't due. If the code ends up getting used in the future and someone posts here with links to it, compensation might be due.

    @mallenexpensify The selected proposal helps the team identify what was missed in the reverted PR more easily. They can then apply the same approach to avoid the issue in the new PR. So, the proposed code is both helpful and actively being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions