You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-02] [Due for payment 2025-05-30] [$250][$25 for offending PR link] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page #62506
Version Number: 9.1.48-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):sjdiojdsoisdjsoi@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat
Go offline
Click + > Create expense > Manual
Enter amount > Next
On confirmation page, enter merchant
Click Show more
Disable Reimbursable toggle
Submit the expense
Go to transaction thread
Expected Result:
Reimbursable toggle should be disabled because it is disabled on the confirmation page
Actual Result:
Reimbursable toggle is enabled when it is disabled on the confirmation page
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6838554_1747855042027.reimbursable.mp4
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/-][+][$250] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/+]on May 21, 2025
changed the title [-][$250][$25 for offending PR link] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/-][+][Due for payment 2025-05-30] [$250][$25 for offending PR link] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/+]on May 23, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@allroundexperts@mallenexpensify@allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2025-05-30] [$250][$25 for offending PR link] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/-][+][Due for payment 2025-06-02] [Due for payment 2025-05-30] [$250][$25 for offending PR link] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/+]on May 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.51-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@allroundexperts@mallenexpensify@allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
The offending PR that was identified by @Krishna2323 was reverted.
Because Help Wanted was added, is compensation due? Our (current) policy is
If we decide to close the job before it is successfully completed
50% payment to contributor and C+ if the contributor was hired/assigned.
50% payment if the contributor wasn't assigned and
The bug was fixed by a different PR
The proposal was 🎀👀🎀 by the C+, and
Most of the code used in the fix came from the accepted proposal
For this instance, since the code wasn't used at all, compensation isn't due. If the code ends up getting used in the future and someone posts here with links to it, compensation might be due.
@mallenexpensify The selected proposal helps the team identify what was missed in the reverted PR more easily. They can then apply the same approach to avoid the issue in the new PR. So, the proposed code is both helpful and actively being used.
Activity
melvin-bot commentedon May 21, 2025
Triggered auto assignment to @marcochavezf (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 21, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 21, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
[-]Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/-][+][$250] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/+]melvin-bot commentedon May 21, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021925299076161716076
melvin-bot commentedon May 21, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (
External)25 remaining items
mallenexpensify commentedon May 23, 2025
Thx, paid, updated post above.
[-][$250][$25 for offending PR link] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/-][+][Due for payment 2025-05-30] [$250][$25 for offending PR link] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/+]melvin-bot commentedon May 23, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 23, 2025
@allroundexperts @mallenexpensify @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2025-05-30] [$250][$25 for offending PR link] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/-][+][Due for payment 2025-06-02] [Due for payment 2025-05-30] [$250][$25 for offending PR link] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page[/+]melvin-bot commentedon May 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.51-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 26, 2025
@allroundexperts @mallenexpensify @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
allroundexperts commentedon Jun 1, 2025
I did not review the PR here as it was a straight revert (so no payment due for me). A checklist isn't needed as well because of the same reason.
nabi-ebrahimi commentedon Jun 3, 2025
@mallenexpensify The selected proposal helps the team identify what was missed in the reverted PR more easily. They can then apply the same approach to avoid the issue in the new PR. So, the proposed code is both helpful and actively being used.