You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Reports - After moving expense and deleting all expenses, table header remains in blank page #62507
Version Number: 9.1.48-0 Reproducible in staging?: Yes Reproducible in production?: Unable to check If this was caught during regression testing, add the test name, ID and link from TestRail:#62270 Email or phone of affected tester (no customers):sjdiodjsodsj232@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.4 / Chrome App Component: Search
Action Performed:
Go to staging.new.expensify.com
Create two workspace chats.
Submit one expense to each workspace chat.
Go to Reports.
Go to Expense Reports.
Select one of the expenses via checkbox.
Click dropdown button.
Click Move expense.
Select the unselected report.
Select all expenses via checkbox.
Click dropdown button > Delete.
Delete the expenses.
Expected Result:
Table header will disappear.
Empty state will show up.
Actual Result:
Table header does not disappear.
Empty state does not show up.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Hmm, interesting. So if you're in the beta everything works correctly. I'm not sure this is worth doing anything about then, since it'll naturally fix itself shortly when the beta becomes live. What do you think @bfitzexpensify?
I think even though the issue will resolve itself when the beta goes live, we should still consider fixing it now because this bug creates a poor experience for non-beta users right now
I agree we can just wait for that beta to go live - this is a niche flow, and only a display issue, not something that prevents a user taking an action.
@puneetlath@bfitzexpensify I received a C+ review here, and my proposal addresses the bug mentioned in the original post. Since the issue has been marked as external, is there any chance I could be considered for partial compensation for my contribution?
@nkdengineer this would be eligible for partial payment if you as the contributor were hired - in this case, though your proposal was selected by the C, we didn't proceed with hiring.
Thanks for the reply @bfitzexpensify. I think we still provide payment to the contributor if the proposal is C+ reviewed, we have a similar case as in this issue
50% payment if the contributor wasn't assigned and
The proposal was 🎀👀🎀 by the C+, and
Most of the code used in the fix came from the accepted proposal
Activity
melvin-bot commentedon May 21, 2025
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 21, 2025
Triggered auto assignment to @puneetlath (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 21, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 21, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nlemma commentedon May 21, 2025
@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
nabi-ebrahimi commentedon May 21, 2025
Can see the
move expenseoption btw.11 remaining items
nkdengineer commentedon May 26, 2025
@alitoshmatov what do you think about my proposal here?
alitoshmatov commentedon May 27, 2025
@nkdengineer Thank you for your proposal. Your RCA is correct and solution works. I think we should check reports for empty transactions.
We can go with @nkdengineer 's proposal
C+ reviewed 🎀 👀 🎀
melvin-bot commentedon May 27, 2025
Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
puneetlath commentedon May 27, 2025
Hmm, interesting. So if you're in the beta everything works correctly. I'm not sure this is worth doing anything about then, since it'll naturally fix itself shortly when the beta becomes live. What do you think @bfitzexpensify?
nkdengineer commentedon May 27, 2025
I think even though the issue will resolve itself when the beta goes live, we should still consider fixing it now because this bug creates a poor experience for non-beta users right now
bfitzexpensify commentedon May 28, 2025
I agree we can just wait for that beta to go live - this is a niche flow, and only a display issue, not something that prevents a user taking an action.
nkdengineer commentedon May 29, 2025
@puneetlath @bfitzexpensify I received a C+ review here, and my proposal addresses the bug mentioned in the original post. Since the issue has been marked as external, is there any chance I could be considered for partial compensation for my contribution?
nkdengineer commentedon Jun 2, 2025
@puneetlath @bfitzexpensify could you please check my comment here?
bfitzexpensify commentedon Jun 2, 2025
@nkdengineer this would be eligible for partial payment if you as the contributor were hired - in this case, though your proposal was selected by the C, we didn't proceed with hiring.
nkdengineer commentedon Jun 2, 2025
Thanks for the reply @bfitzexpensify. I think we still provide payment to the contributor if the proposal is C+ reviewed, we have a similar case as in this issue
Quote from here
bfitzexpensify commentedon Jun 2, 2025
This case doesn't satisfy the last requirement:
In your proposal, you noted that:
And as we're not doing anything for non-beta users, this means the resolution for this already existed pre-proposal.
nkdengineer commentedon Jun 3, 2025
That makes sense, thanks @bfitzexpensify