Skip to content

[Due for payment 2025-06-02] [Due for payment 2025-05-30] Expense - Pay button does not disappear after disabling Reimbursable in offline mode #62521

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.48-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: #59209
Email or phone of affected tester (no customers): applausetester+200510kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Create a workspace with Delayed submissions and Add approvals disabled.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense with Reimbursable enabled to the workspace chat.
  4. Go to transaction thread.
  5. Go offline.
  6. Disable Reimbursable toggle.
  7. Click Pay elsewhere.
  8. Go online.

Expected Result:

In Step 6. after disabling Reimbursable toggle. Pay button will disappear.

Actual Result:

In Step 6. after disabling Reimbursable toggle. Pay button does not disappear.
In Step 8, after paying elsewhere and returning online, Pay button still does not disappear when Reimbursable toggle is already disabled.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6838647_1747860927840.20250522_045114.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @flaviadefaria

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on May 21, 2025
  2. melvin-bot commented on May 21, 2025

    @melvin-bot

    Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 21, 2025

    @melvin-bot

    Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 21, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 21, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on May 21, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  7. 6 remaining items

  8. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 23, 2025
  9. changed the title [-]Expense - Pay button does not disappear after disabling Reimbursable in offline mode[/-] [+][Due for payment 2025-05-30] Expense - Pay button does not disappear after disabling Reimbursable in offline mode[/+] on May 23, 2025
  10. melvin-bot commented on May 23, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on May 23, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-30. 🎊

  12. melvin-bot commented on May 23, 2025

    @melvin-bot

    @blimpich @flaviadefaria @blimpich The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. changed the title [-][Due for payment 2025-05-30] Expense - Pay button does not disappear after disabling Reimbursable in offline mode[/-] [+][Due for payment 2025-06-02] [Due for payment 2025-05-30] Expense - Pay button does not disappear after disabling Reimbursable in offline mode[/+] on May 26, 2025
  14. melvin-bot commented on May 26, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.51-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-02. 🎊

  15. melvin-bot commented on May 26, 2025

    @melvin-bot

    @blimpich @flaviadefaria @blimpich The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions