You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-11] [$250] tags-User able to delete all tags. #62537
Version Number: V9 1.48-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#58052 Email or phone of affected tester (no customers):slottwo1@gmail.com Issue reported by: Applause Internal Team Device used: Redminote 10s android 13 phone App Component: Workspace Settings
Action Performed:
Launch app
Create a new workspace and enable tags
Tap Tags
Add a tag
Tap settings - enable members must tag all expenses
Delete the tag
Expected Result:
User must not be able to delete all tags. Cannot delete all tags modal must be shown.
Actual Result:
User able to delete all tags and Cannot delete all tags modal is not shown.
Then isDisablingOrDeletingLastEnabledTag returns false when we select all tags, it's only updated until the tag list is updated from the backend with required as true
What changes do you think we should make in order to solve the problem?
We should also update required as true for normal tags. We can remove isMultiLevelTags check here since normal tags are also objects with tag names like multi-level tags.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Update setPolicyRequiresTag test and verify that required is updated to true for normal tags.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
@mananjadhav@sakluger@mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Create a new WS
Enable tag features
Create some tags
Tap settings - enable members must tag all expenses
Select all tags > Delete tags
Verify that Cannot delete all tags modal is shown.
Activity
melvin-bot commentedon May 22, 2025
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.ijmalik commentedon May 22, 2025
Hi @sakluger
The issue has been resolved in v9.1.49-4.
62537.mp4
mitarachim commentedon May 22, 2025
QA team still reproduce this issue using build v9.1.49-4
Screenrecorder-2025-05-22-09-01-38-592.mp4
nkdengineer commentedon May 22, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
User able to delete all tags and Cannot delete all tags modal is not shown.
What is the root cause of that problem?
When we update
requiresTag, we only updaterequiredin policy tags data if the the tags are multi-level tagApp/src/libs/actions/Policy/Tag.ts
Lines 785 to 803 in 6871ba9
Then
isDisablingOrDeletingLastEnabledTagreturns false when we select all tags, it's only updated until the tag list is updated from the backend withrequiredastrueApp/src/libs/OptionsListUtils.ts
Lines 1141 to 1150 in 6871ba9
What changes do you think we should make in order to solve the problem?
We should also update
requiredastruefor normal tags. We can removeisMultiLevelTagscheck here since normal tags are also objects with tag names like multi-level tags.App/src/libs/actions/Policy/Tag.ts
Lines 785 to 803 in 6871ba9
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Update
setPolicyRequiresTagtest and verify thatrequiredis updated totruefor normal tags.What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon May 27, 2025
@sakluger Eep! 4 days overdue now. Issues have feelings too...
[-]tags-User able to delete all tags.[/-][+][$250] tags-User able to delete all tags.[/+]melvin-bot commentedon May 27, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021927373792094838117
27 remaining items
melvin-bot commentedon Jun 4, 2025
@mananjadhav @sakluger @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
sakluger commentedon Jun 11, 2025
@mananjadhav please complete the BZ checklist 🙏
sakluger commentedon Jun 11, 2025
Summarizing payment on this issue:
Contributor: @nkdengineer $250, paid via Upwork
Contributor+: @mananjadhav $250, please request on Newdot
fix: QBO - Tag status does not change when 'Members must tag all expe…
mananjadhav commentedon Jun 13, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: b5b6e9c#r159909682
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
mananjadhav commentedon Jun 13, 2025
@sakluger Apologies for the delay. Here's the checklist ^
melvin-bot commentedon Jun 16, 2025
@mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!