You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-02] [$250] Move expense - Expense can be moved to report of deleted workspace #62552
Version Number: 9.1.49-4 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):dhsishdsiushbishd@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.4 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Create a workspace.
Go to workspace chat.
Submit an expense to the workspace chat.
Delete the workspace.
Create another workspace.
Go to workspace chat.
Submit an expense to the workspace chat.
Click on the expense preview.
Click More > Move expense.
Select the expense report of the deleted workspace.
Expected Result:
Expense report from the deleted workspace should not appear in the Report list when moving expense.
Reports from other workspaces should not appear in the Report list (production behavior).
Actual Result:
Expense report from the deleted workspace appears in the Report list when moving expense.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Update getOutstandingReportsForUser test and verify the result doesn't include the archived report.
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
@rojiphil@bfitzexpensify@rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Create a new workspace
Go to WS chat and create a new expense
Open expense report in the step 2
Select any expense > Move expense
Verify that the archived report doesn't appear in the list
Activity
melvin-bot commentedon May 22, 2025
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 22, 2025
Triggered auto assignment to @lakchote (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 22, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 22, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nkdengineer commentedon May 22, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense report from the deleted workspace appears in the Report list when moving expense.
What is the root cause of that problem?
It comes from #62270. But the current problem is
isReportOutstandingfunction doesn't return false for archived reports.App/src/pages/iou/request/step/IOURequestEditReportCommon.tsx
Lines 53 to 67 in 6871ba9
App/src/libs/ReportUtils.ts
Lines 9640 to 9647 in 6871ba9
App/src/libs/ReportUtils.ts
Lines 9618 to 9630 in 6871ba9
What changes do you think we should make in order to solve the problem?
We should return false for archived report here
App/src/libs/ReportUtils.ts
Lines 9618 to 9630 in 6871ba9
Or we can filter out it here
App/src/libs/ReportUtils.ts
Lines 9640 to 9647 in 6871ba9
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Update
getOutstandingReportsForUsertest and verify the result doesn't include the archived report.What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
lakchote commentedon May 22, 2025
cc @jnowakow @DylanDylann @luacmartins @dangrous it comes from #62270
33 remaining items
melvin-bot commentedon May 26, 2025
@rojiphil @bfitzexpensify @rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
bfitzexpensify commentedon Jun 2, 2025
Payment complete to @nkdengineer
@rojiphil, please complete the BZ checklist
melvin-bot commentedon Jun 6, 2025
@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
rojiphil commentedon Jun 6, 2025
BZ Checklist is pending from my end. Will do it today.
rojiphil commentedon Jun 7, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
rojiphil commentedon Jun 7, 2025
@bfitzexpensify BZ Checklist Done. Thanks.
melvin-bot commentedon Jun 9, 2025
@bfitzexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
luacmartins commentedon Jun 9, 2025
What's left here before we can close this issue?
bfitzexpensify commentedon Jun 10, 2025
Payment summary:
@rojiphil due $250 payment through NewDot Manual Requests
garrettmknight commentedon Jun 19, 2025
$250 approved for @rojiphil