You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-12] [$250] Reports - On removing expense, "to" field briefly appears and disappears in reports page. #62558
Version Number: V9.1.49-4 Reproducible in staging?: Yes Reproducible in production?: Unable to check, new feature If this was caught during regression testing, add the test name, ID and link from TestRail: N Email or phone of affected tester (no customers): Applausetester lq@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Redminote 10s android 13 phone App Component: User Settings
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
When re-moving an expense between reports, the "to" field (recipient information) briefly appears and then disappears on the reports page, creating a flickering effect.
What is the root cause of that problem?
The root cause was that the logic for displaying the recipient information in the ExpenseItemHeaderNarrow component did not correctly account for scenarios where the "from" and "to" participants of an expense movement are the same. The UI would momentarily try to display recipient details even when the expense was essentially being moved by the same user, causing the brief appearance and disappearance of the "to" field.
What changes do you think we should make in order to solve the problem?
To solve this, we introduced a new utility function shouldShowRecipientForExpenseMovement in IOUUtils.ts. This function checks if the accountID of the participantFrom and participantTo are different.
In ExpenseItemHeaderNarrow.tsx, we now use this function in conjunction with isCorrectSearchUserName to determine shouldDisplayArrowIcon. This flag now correctly controls whether the recipient information (the "to" field) and the connecting arrow icon are displayed. Specifically, the "to" field and arrow are only shown if the "from" and "to" participants are different individuals.
Additionally, the shouldShowToRecipient prop for UserInfoCellsWithArrow is now directly tied to the shouldDisplayArrowIcon state, ensuring consistency.
This separates business logic from presentation and ensures consistent behavior across the application.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
changed the title [-][$250] Reports - On removing expense, "to" field briefly appears and disappears in reports page.[/-][+][Due for payment 2025-06-12] [$250] Reports - On removing expense, "to" field briefly appears and disappears in reports page.[/+]on Jun 5, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.59-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ishpaul777@abekkala@ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: no need minor ui glitch does not block any functionality
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.- for same reason as above not recomended
Activity
melvin-bot commentedon May 22, 2025
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 22, 2025
Triggered auto assignment to @pecanoro (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 22, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 22, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MobileMage commentedon May 22, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
When re-moving an expense between reports, the "to" field (recipient information) briefly appears and then disappears on the reports page, creating a flickering effect.
What is the root cause of that problem?
The root cause was that the logic for displaying the recipient information in the
ExpenseItemHeaderNarrowcomponent did not correctly account for scenarios where the "from" and "to" participants of an expense movement are the same. The UI would momentarily try to display recipient details even when the expense was essentially being moved by the same user, causing the brief appearance and disappearance of the "to" field.What changes do you think we should make in order to solve the problem?
To solve this, we introduced a new utility function
shouldShowRecipientForExpenseMovementinIOUUtils.ts. This function checks if theaccountIDof theparticipantFromandparticipantToare different.In
ExpenseItemHeaderNarrow.tsx, we now use this function in conjunction withisCorrectSearchUserNameto determineshouldDisplayArrowIcon. This flag now correctly controls whether the recipient information (the "to" field) and the connecting arrow icon are displayed. Specifically, the "to" field and arrow are only shown if the "from" and "to" participants are different individuals.Additionally, the
shouldShowToRecipientprop forUserInfoCellsWithArrowis now directly tied to theshouldDisplayArrowIconstate, ensuring consistency.This separates business logic from presentation and ensures consistent behavior across the application.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore?
N/A
28 remaining items
[-][$250] Reports - On removing expense, "to" field briefly appears and disappears in reports page.[/-][+][Due for payment 2025-06-12] [$250] Reports - On removing expense, "to" field briefly appears and disappears in reports page.[/+]melvin-bot commentedon Jun 5, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 5, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.59-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-12. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 5, 2025
@ishpaul777 @abekkala @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
abekkala commentedon Jun 6, 2025
PAYMENT SUMMARY FOR JUN 12
please complete checklsit
ishpaul777 commentedon Jun 11, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/59200/files#r2141229047
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: no need minor ui glitch does not block any functionality
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.- for same reason as above not recomended
melvin-bot commentedon Jun 12, 2025
Payment Summary
Upwork Job
BugZero Checklist (@abekkala)
abekkala commentedon Jun 12, 2025
PAYMENT SUMMARY FOR JUN 12
bernhardoj commentedon Jun 13, 2025
Requested in ND.
garrettmknight commentedon Jul 3, 2025
$250 approved for @ishpaul777