Skip to content

[Due for payment 2025-06-12] [$250] Reports - On removing expense, "to" field briefly appears and disappears in reports page. #62558

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9.1.49-4
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): Applausetester lq@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: User Settings

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Login with new expensifail account
  3. Tap fab - create a new workspace
  4. Create a manual expense entering merchant
  5. Create another workspace
  6. Create a manual expense entering merchant
  7. Go to profile and set a display name
  8. Go to reports
  9. Select all expenses and "move expense" to first report
  10. Again select all expenses and "move expense" to second report

Expected Result:

On re-moving expense, "to" field must not briefly appear and disappear in reports page.

Actual Result:

On re-moving expense, "to" field briefly appears and disappears in reports page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021925532511970505418
  • Upwork Job ID: 1925532511970505418
  • Last Price Increase: 2025-05-22
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 22, 2025
  2. melvin-bot commented on May 22, 2025

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 22, 2025

    @melvin-bot

    Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 22, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 22, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MobileMage commented on May 22, 2025

    @MobileMage
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When re-moving an expense between reports, the "to" field (recipient information) briefly appears and then disappears on the reports page, creating a flickering effect.

    What is the root cause of that problem?

    The root cause was that the logic for displaying the recipient information in the ExpenseItemHeaderNarrow component did not correctly account for scenarios where the "from" and "to" participants of an expense movement are the same. The UI would momentarily try to display recipient details even when the expense was essentially being moved by the same user, causing the brief appearance and disappearance of the "to" field.

    What changes do you think we should make in order to solve the problem?

    To solve this, we introduced a new utility function shouldShowRecipientForExpenseMovement in IOUUtils.ts. This function checks if the accountID of the participantFrom and participantTo are different.

    In ExpenseItemHeaderNarrow.tsx, we now use this function in conjunction with isCorrectSearchUserName to determine shouldDisplayArrowIcon. This flag now correctly controls whether the recipient information (the "to" field) and the connecting arrow icon are displayed. Specifically, the "to" field and arrow are only shown if the "from" and "to" participants are different individuals.

    Additionally, the shouldShowToRecipient prop for UserInfoCellsWithArrow is now directly tied to the shouldDisplayArrowIcon state, ensuring consistency.

    This separates business logic from presentation and ensures consistent behavior across the application.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore?

    N/A

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on May 22, 2025
  8. 28 remaining items

  9. changed the title [-][$250] Reports - On removing expense, "to" field briefly appears and disappears in reports page.[/-] [+][Due for payment 2025-06-12] [$250] Reports - On removing expense, "to" field briefly appears and disappears in reports page.[/+] on Jun 5, 2025
  10. melvin-bot commented on Jun 5, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jun 5, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.59-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-12. 🎊

    For reference, here are some details about the assignees on this issue:

    • @bernhardoj requires payment through NewDot Manual Requests
    • @ishpaul777 requires payment through NewDot Manual Requests
  12. melvin-bot commented on Jun 5, 2025

    @melvin-bot

    @ishpaul777 @abekkala @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. abekkala commented on Jun 6, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR JUN 12

    • Fix: @bernhardoj [$250, if no regressions] payment via NewDot
    • PR Review: @ishpaul777 [$250, if no regressions] payment via NewDot
      please complete checklsit
  14. ishpaul777 commented on Jun 11, 2025

    @ishpaul777
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/59200/files#r2141229047

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: no need minor ui glitch does not block any functionality

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.- for same reason as above not recomended

  15. melvin-bot commented on Jun 12, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@abekkala)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1925532511970505418/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. abekkala commented on Jun 12, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR JUN 12

    • Fix: @bernhardoj [$250] payment via NewDot - thank you! 🎉
    • PR Review: @ishpaul777 [$250] payment via NewDot - thank you! 🎉
  17. bernhardoj commented on Jun 13, 2025

    @bernhardoj
    Contributor

    Requested in ND.

  18. garrettmknight commented on Jul 3, 2025

    @garrettmknight
    Contributor

    $250 approved for @ishpaul777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions