You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-05] [$250] Expense reports with the table report view do not get marked as read upon visiting #62559
changed the title [-]Expense reports with the table report view do not get marked as read upon visiting[/-][+][$250] Expense reports with the table report view do not get marked as read upon visiting[/+]on May 22, 2025
Please re-state the problem that we are trying to solve in this issue.
Reports are not getting marked as read once visited by the users
What is the root cause of that problem?
data is getting cached either on the UI or the underlying database did not get updated with the latest value once a user visits the Reports
What changes do you think we should make in order to solve the problem?
To fix this problem I may need to evluate following :
Caching on UI & on the repositories. May need to invalidate (if logic is present, this will quickly start working)
if caching is not problem, then the logic to update & retrieve values from database is missing, which need to be written
if logic is also available, then there must be 5XX error happening which is well documented and not coming on front-end. May need to dig in logs.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Test cases like clicking the respective unread reports can be written and checking the correct values in db.
What alternative solutions did you explore? (Optional)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No discussion was started because nothing can be standardized in a checklist for this bug.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon May 22, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021925478167796105068
[-]Expense reports with the table report view do not get marked as read upon visiting[/-][+][$250] Expense reports with the table report view do not get marked as read upon visiting[/+]melvin-bot commentedon May 22, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)melvin-bot commentedon May 22, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.vishalPwc commentedon May 22, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Reports are not getting marked as read once visited by the users
What is the root cause of that problem?
data is getting cached either on the UI or the underlying database did not get updated with the latest value once a user visits the Reports
What changes do you think we should make in order to solve the problem?
To fix this problem I may need to evluate following :
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Test cases like clicking the respective unread reports can be written and checking the correct values in db.
What alternative solutions did you explore? (Optional)
Contributor details
Your Expensify account email: vishal.thamman@gmail.com
Upwork Profile Link:(https://www.upwork.com/freelancers/vishalthamman)
18 remaining items
melvin-bot commentedon Jun 5, 2025
Payment Summary
Upwork Job
BugZero Checklist (@jliexpensify)
mountiny commentedon Jun 5, 2025
@c3024 is owed $250
Can you add the checklist please
jliexpensify commentedon Jun 5, 2025
Payment Summary
c3024 commentedon Jun 6, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: [Better Expense Reports] Add MoneyRequestReportView #58360 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No discussion was started because nothing can be standardized in a checklist for this bug.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
jliexpensify commentedon Jun 8, 2025
Bump on checklist @c3024
jliexpensify commentedon Jun 10, 2025
Bump @c3024 for checklist
c3024 commentedon Jun 11, 2025
@jliexpensify
updated here. TY!
jliexpensify commentedon Jun 12, 2025
Payment Summary is here
JmillsExpensify commentedon Jun 26, 2025
$250 approved for @c3024