Skip to content

[Due for payment 2025-06-05] [$250] Expense reports with the table report view do not get marked as read upon visiting #62559

Closed

Description

@mountiny

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C05LX9D6E07/p1747855421259419

Action Performed:

Break down in numbered steps

Not sure but maybe these steps could help:

  1. As Alice, create a workspace with approvals set up
  2. Add a another member Bob to the workspace
  3. Add Carl to the workspace and set him as an approver of Bob
  4. As Bob, submit 3 expenses to the workspace
  5. As Alice, copilot into Carl account
  6. Approve the report from Bob on behalf of Carl

Expected Result:

Describe what you think should've happened

When Bob now goes to the unread expense report, it would get marked as read

Actual Result:

Describe what actually happened

The report is never marked as read by just visiting it

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021925478167796105068
  • Upwork Job ID: 1925478167796105068
  • Last Price Increase: 2025-05-22
Issue OwnerCurrent Issue Owner: @jliexpensify

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 22, 2025
  2. melvin-bot commented on May 22, 2025

    @melvin-bot
  3. changed the title [-]Expense reports with the table report view do not get marked as read upon visiting[/-] [+][$250] Expense reports with the table report view do not get marked as read upon visiting[/+] on May 22, 2025
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 22, 2025
  5. melvin-bot commented on May 22, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  6. moved this to Second Cohort - HIGH in [#whatsnext] #migrateon May 22, 2025
  7. melvin-bot commented on May 22, 2025

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  8. vishalPwc commented on May 22, 2025

    @vishalPwc

    Proposal

    Please re-state the problem that we are trying to solve in this issue.
    Reports are not getting marked as read once visited by the users

    What is the root cause of that problem?
    data is getting cached either on the UI or the underlying database did not get updated with the latest value once a user visits the Reports

    What changes do you think we should make in order to solve the problem?
    To fix this problem I may need to evluate following :

    1. Caching on UI & on the repositories. May need to invalidate (if logic is present, this will quickly start working)
    2. if caching is not problem, then the logic to update & retrieve values from database is missing, which need to be written
    3. if logic is also available, then there must be 5XX error happening which is well documented and not coming on front-end. May need to dig in logs.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
    Test cases like clicking the respective unread reports can be written and checking the correct values in db.

    What alternative solutions did you explore? (Optional)

    Contributor details
    Your Expensify account email: vishal.thamman@gmail.com
    Upwork Profile Link:(https://www.upwork.com/freelancers/vishalthamman)

  9. 18 remaining items

  10. melvin-bot commented on Jun 5, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @SzymczakJ is from an agency-contributor and not due payment
    • Reviewer: @c3024 owed $250 via NewDot

    BugZero Checklist (@jliexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1925478167796105068/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. mountiny commented on Jun 5, 2025

    @mountiny
    ContributorAuthor

    @c3024 is owed $250

    Can you add the checklist please

  12. jliexpensify commented on Jun 5, 2025

    @jliexpensify
    Contributor

    Payment Summary

    • C+: @c3024 $250 (to be paid via New Expensify payments)
  13. c3024 commented on Jun 6, 2025

    @c3024
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: [Better Expense Reports] Add MoneyRequestReportView #58360 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: No discussion was started because nothing can be standardized in a checklist for this bug.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Table report view enabled

    Test:

    1. Go to a report with multiple transactions
    2. Send a few messages
    3. Mark the last message as unread
    4. Click on Inbox
    5. Click on the report
    6. Verify that it's no longer "unread".

    Do we agree 👍 or 👎

  14. jliexpensify commented on Jun 8, 2025

    @jliexpensify
    Contributor

    Bump on checklist @c3024

  15. jliexpensify commented on Jun 10, 2025

    @jliexpensify
    Contributor

    Bump @c3024 for checklist

  16. c3024 commented on Jun 11, 2025

    @c3024
    Contributor

    @jliexpensify

    updated here. TY!

  17. jliexpensify commented on Jun 12, 2025

    @jliexpensify
    Contributor
  18. moved this from Second Cohort - HIGH to Done in [#whatsnext] #migrateon Jun 12, 2025
  19. JmillsExpensify commented on Jun 26, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @c3024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions