You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-23] [Better Expense Report View] [$250] Chat bubble is always green in the expense preview when hold messages are read #62579
Version Number: 9.1.49-5 Reproducible in staging?: Yes Reproducible in production?: Unable to check - New feature testing (Chat bubble is not on prod yet) If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+x34@applause.expensifail.com Issue reported by: Applause Internal Team Device used: iPhone 15 Pro Max / iOS 18.4 App Component: Search
Action Performed:
Launch Expensify app.
Go to workspace chat.
Submit an expense to the workspace chat.
Long press on the expense preview > Hold.
Enter reason and save it.
Tap on the expense preview to mark the hold messages as read.
Go to Reports.
Tap bookmark button.
Tap Expense Reports.
Tap on the report.
Tap app back button.
Expected Result:
Chat bubble will turn grey because the hold messages are already read in Step 6.
Actual Result:
Chat bubble is always green when the hold messages are already read in Step 6.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@lydiabarclay FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
changed the title [-][Better Expense Report View] [$250] Chat bubble is always green in the expense preview when hold messages are read[/-][+][Due for payment 2025-06-23] [Better Expense Report View] [$250] Chat bubble is always green in the expense preview when hold messages are read[/+]on Jun 16, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.66-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@DylanDylann@lydiabarclay@DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon May 22, 2025
Triggered auto assignment to @lydiabarclay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 22, 2025
Triggered auto assignment to @youssef-lr (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 22, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 22, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nlemma commentedon May 22, 2025
@lydiabarclay FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
arosiclair commentedon May 22, 2025
Any progress on this @youssef-lr? I think this might be caused by #62286
youssef-lr commentedon May 22, 2025
Yeah, IMO this is minor and shouldn't block the deploy. What do you think about demoting this?
36 remaining items
[-][Better Expense Report View] [$250] Chat bubble is always green in the expense preview when hold messages are read[/-][+][Due for payment 2025-06-23] [Better Expense Report View] [$250] Chat bubble is always green in the expense preview when hold messages are read[/+]melvin-bot commentedon Jun 16, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 16, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.66-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-23. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 16, 2025
@DylanDylann @lydiabarclay @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
DylanDylann commentedon Jun 22, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Add selection to table on MoneyRequestReport page #59433 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/517016
Regression Test Proposal
Test:
On Mobile only
Do we agree 👍 or 👎
melvin-bot commentedon Jun 23, 2025
Payment Summary
Upwork Job
BugZero Checklist (@lydiabarclay)
lydiabarclay commentedon Jun 23, 2025
Payment Summary
Contributor: @sumo-slonik does not require payment (Contractor)
Contributor+: @DylanDylann due $250 via NewDot
✅ Regression test filed
quinthar commentedon Aug 28, 2025
$250 approved for @DylanDylann