Skip to content

[Due for payment 2025-06-23] [Better Expense Report View] [$250] Chat bubble is always green in the expense preview when hold messages are read #62579

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.49-5
Reproducible in staging?: Yes
Reproducible in production?: Unable to check - New feature testing (Chat bubble is not on prod yet)
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+x34@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.4
App Component: Search

Action Performed:

  1. Launch Expensify app.
  2. Go to workspace chat.
  3. Submit an expense to the workspace chat.
  4. Long press on the expense preview > Hold.
  5. Enter reason and save it.
  6. Tap on the expense preview to mark the hold messages as read.
  7. Go to Reports.
  8. Tap bookmark button.
  9. Tap Expense Reports.
  10. Tap on the report.
  11. Tap app back button.

Expected Result:

Chat bubble will turn grey because the hold messages are already read in Step 6.

Actual Result:

Chat bubble is always green when the hold messages are already read in Step 6.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6839160_1747916098197.ScreenRecording_05-22-2025_20-07-42_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021925588134633455429
  • Upwork Job ID: 1925588134633455429
  • Last Price Increase: 2025-05-22
Issue OwnerCurrent Issue Owner: @lydiabarclay

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 22, 2025
  2. melvin-bot commented on May 22, 2025

    @melvin-bot

    Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 22, 2025

    @melvin-bot

    Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 22, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 22, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. nlemma commented on May 22, 2025

    @nlemma
    Author

    @lydiabarclay FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. arosiclair commented on May 22, 2025

    @arosiclair
    Contributor

    Any progress on this @youssef-lr? I think this might be caused by #62286

  8. youssef-lr commented on May 22, 2025

    @youssef-lr
    Contributor

    Yeah, IMO this is minor and shouldn't block the deploy. What do you think about demoting this?

  9. 36 remaining items

  10. changed the title [-][Better Expense Report View] [$250] Chat bubble is always green in the expense preview when hold messages are read[/-] [+][Due for payment 2025-06-23] [Better Expense Report View] [$250] Chat bubble is always green in the expense preview when hold messages are read[/+] on Jun 16, 2025
  11. melvin-bot commented on Jun 16, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jun 16, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.66-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-23. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Jun 16, 2025

    @melvin-bot

    @DylanDylann @lydiabarclay @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. DylanDylann commented on Jun 22, 2025

    @DylanDylann
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Add selection to table on MoneyRequestReport page #59433 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/517016

    Regression Test Proposal

    Test:

    On Mobile only

    1. Go to workspace chat.
    2. Create Report > Submit an expense
    3. Long press on the expense preview > Hold.
    4. Enter reason and save it.
    5. Tap on the expense preview to mark the hold messages as read.
    6. Go to Reports.
    7. Tap bookmark button.
    8. Tap Expense Reports.
    9. Tap on the report.
    10. Tap app back button.
    11. Chat bubble should be gray

    Do we agree 👍 or 👎

  15. melvin-bot commented on Jun 23, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @sumo-slonik is from an agency-contributor and not due payment
    • Reviewer: @DylanDylann owed $250 via NewDot

    BugZero Checklist (@lydiabarclay)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1925588134633455429/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. lydiabarclay commented on Jun 23, 2025

    @lydiabarclay
    Contributor

    Payment Summary

    Contributor: @sumo-slonik does not require payment (Contractor)
    Contributor+: @DylanDylann due $250 via NewDot

    ✅ Regression test filed

  17. moved this from Second Cohort - MEDIUM or LOW to Done in [#whatsnext] #migrateon Jun 23, 2025
  18. quinthar commented on Aug 28, 2025

    @quinthar
    Contributor

    $250 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions