You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Reports - Keyboard closes instead of selecting user when tapping on user when keyboard is up #62676
Version Number: 9.1.51-0 Reproducible in staging?: Yes Reproducible in production?: Unable to check - New feature testing If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+160510kh@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Samsung Galaxy Z Fold 4 / Android 14 App Component: Search
Action Performed:
Launch Expensify app.
Go to Reports.
Tap From filter.
With keyboard open, tap on any user.
Expected Result:
The user will be selected.
Actual Result:
Keyboard closes when tapping on user when keyboard is up.
Second tap on the user only selects the user after closing the keyboard.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Please re-state the problem that we are trying to solve in this issue.
When the keyboard is open, tapping on a user in the list first dismisses the keyboard, rather than selecting the user immediately. The user must tap twice: once to dismiss the keyboard, and again to make the selection.
What is the root cause of that problem?
The UserSelectPopup component uses the SelectionList to render its options:
This outer ScrollView does not define keyboardShouldPersistTaps, so it defaults to never, which causes taps to be intercepted to dismiss the keyboard first. As noted in this React Native issue, this prevents the inner SelectionList from receiving the tap event properly.
What changes do you think we should make in order to solve the problem?
Add keyboardShouldPersistTaps="handled" to the parent ScrollView at:
Activity
melvin-bot commentedon May 23, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 23, 2025
Triggered auto assignment to @AndrewGable (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 23, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 23, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nlemma commentedon May 23, 2025
@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
truph01 commentedon May 26, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
The
UserSelectPopupcomponent uses theSelectionListto render its options:App/src/components/Search/FilterDropdowns/UserSelectPopup.tsx
Line 159 in c84977b
This list already sets
keyboardShouldPersistTaps="always", which should allow users to tap and select an item even when the keyboard is open.However,
UserSelectPopupis wrapped in a parentScrollViewhere:App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx
Line 358 in c84977b
This outer
ScrollViewdoes not definekeyboardShouldPersistTaps, so it defaults tonever, which causes taps to be intercepted to dismiss the keyboard first. As noted in this React Native issue, this prevents the innerSelectionListfrom receiving the tap event properly.What changes do you think we should make in order to solve the problem?
keyboardShouldPersistTaps="handled"to the parentScrollViewat:App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx
Line 358 in c84977b
This will allow tap events to propagate to the
SelectionListwhile the keyboard is up, fixing the issue.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
Beamanator commentedon May 26, 2025
closing as fixed by mega revert