Skip to content

[Due for payment 2025-06-05] [Due for payment 2025-06-02] Expense - Next step action shows skeleton loading when workflows are disabled #62685

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.51-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): sjdnoisdjodisjo@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a workspace.
  3. Disable workflows in More features page (if already disabled, enable it and disable)
  4. Go to workspace chat.
  5. Submit an expense.
  6. Click on the expense preview.

Expected Result:

Next step action will not show skeleton loading.

Actual Result:

Next step action shows skeleton loading when workflows are disabled.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6840589_1748031253608.20250524_041240.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 23, 2025
  2. melvin-bot commented on May 23, 2025

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 23, 2025

    @melvin-bot

    Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 23, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 23, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. nlemma commented on May 23, 2025

    @nlemma
    Author

    @muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. blimpich commented on May 23, 2025

    @blimpich
    Contributor

    Skimmed the PR list, no idea what caused this.

  8. blimpich commented on May 24, 2025

    @blimpich
    Contributor

    Did a git bisect and it led me back to this PR

    19f893ee0dc5e389306bd803589c498f4e2532af is the first bad commit
    commit 19f893ee0dc5e389306bd803589c498f4e2532af
    Author: Jakub Szymczak <szymczak.jakub12@gmail.com>
    Date:   Tue May 20 12:48:01 2025 +0200
    
        refactor loading state logic in ReportScreen
    
     src/components/MoneyReportHeader.tsx               |  5 +--
     .../MoneyReportHeaderStatusBarSkeleton.tsx         | 36 ++++++++++++++++++++++
     .../MoneyRequestReportActionsList.tsx              |  8 ++++-
     .../MoneyRequestReportTransactionList.tsx          | 14 +++++++--
     .../ReportActionsListLoadingSkeleton.tsx           | 16 ++++++++++
     src/pages/home/ReportScreen.tsx                    |  1 +
     6 files changed, 75 insertions(+), 5 deletions(-)
     create mode 100644 src/components/MoneyReportHeaderStatusBarSkeleton.tsx
     create mode 100644 src/components/MoneyRequestReportView/ReportActionsListLoadingSkeleton.tsx
    
  9. 23 remaining items

  10. melvin-bot commented on May 26, 2025

    @melvin-bot

    @DylanDylann @muttmuure @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. changed the title [-][Due for payment 2025-06-02] Expense - Next step action shows skeleton loading when workflows are disabled[/-] [+][Due for payment 2025-06-05] [Due for payment 2025-06-02] Expense - Next step action shows skeleton loading when workflows are disabled[/+] on May 29, 2025
  12. melvin-bot commented on May 29, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-05. 🎊

    For reference, here are some details about the assignees on this issue:

    • @SzymczakJ does not require payment (Contractor)
    • @DylanDylann requires payment through NewDot Manual Requests
  13. melvin-bot commented on May 29, 2025

    @melvin-bot

    @DylanDylann @muttmuure @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. muttmuure commented on Jun 3, 2025

    @muttmuure
    Contributor

    June 5th

  15. melvin-bot commented on Jun 5, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @SzymczakJ is from an agency-contributor and not due payment
    • Reviewer: @DylanDylann owed $250 via NewDot

    BugZero Checklist (@muttmuure)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. mountiny commented on Jun 5, 2025

    @mountiny
    Contributor

    We can handle the payment for this on the og issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringMonthlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions