You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[READY FOR PAYMENT ?][$250] Reports - When creating new expense while inside report, user is automatically navigated out #62733
Version Number: 9.1.51-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):ibellicotest+870@gmail.com Issue reported by: Applause Internal Team Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome App Component: Search
Action Performed:
Open the staging.new.expensify.com website.
Open any workspace chat.
Create at least two different expenses.
Navigate to "Reports"
Tap on the bookmark icon and select "Reports"
Open the report of the just created expenses.
Tap on the "+" button and select "Create Expense"
Complete the creation flow.
Note that you are automatically navigated out of the report, and land on "Expenses" section again.
Expected Result:
When adding a new expense while inside the report, the user should remain inside of it, and the new expense should be displayed.
Actual Result:
When opening a report on "Reports" and adding a new expense, the user is automatically navigated out of the report and lands on "Expenses" section again.
Please re-state the problem that we are trying to solve in this issue.
When opening a report on "Reports" and adding a new expense, the user is automatically navigated out of the report and lands on "Expenses" section again.
What is the root cause of that problem?
It starts happening after this PR, we always reset the search query to default after creating an expense
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Reports - When creating new expense while inside report, user is automatically navigated out[/-][+][$250] Reports - When creating new expense while inside report, user is automatically navigated out[/+]on May 27, 2025
changed the title [-][Due for payment 2025-06-17] [Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Reports - When creating new expense while inside report, user is automatically navigated out[/-][+][$250] Reports - When creating new expense while inside report, user is automatically navigated out[/+]on Jun 17, 2025
changed the title [-][$250] Reports - When creating new expense while inside report, user is automatically navigated out[/-][+][READY FOR PAYMENT ?][$250] Reports - When creating new expense while inside report, user is automatically navigated out[/+]on Jul 11, 2025
Activity
melvin-bot commentedon May 24, 2025
Triggered auto assignment to @miljakljajic (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon May 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
When opening a report on "Reports" and adding a new expense, the user is automatically navigated out of the report and lands on "Expenses" section again.
What is the root cause of that problem?
It starts happening after this PR, we always reset the search query to default after creating an expense
App/src/libs/actions/IOU.ts
Lines 5295 to 5309 in 526a0e4
App/src/libs/actions/IOU.ts
Lines 816 to 829 in 526a0e4
What changes do you think we should make in order to solve the problem?
We should check if we're already on
Expense/Reports, we shouldn't reset the search queryApp/src/libs/actions/IOU.ts
Lines 816 to 829 in 526a0e4
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
bernhardoj commentedon May 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
When user creating a new expense from report RHP, the report RHP will be closed.
What is the root cause of that problem?
After request money, we call
dismissModalAndOpenReportInInboxTab. If the topmost full screen is the search screen, then we dismiss the modal.App/src/libs/actions/IOU.ts
Lines 816 to 827 in 526a0e4
This works fine if we create the money request from FAB. However, if we do it from report RHP, then the report RHP will be dismissed too.
What changes do you think we should make in order to solve the problem?
We need to check if we are on report RHP. If true, then we need to only pop the money request flow page.
Navigation.popis a new function that accepts the key on which the pop action will happen.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
[-]Reports - When creating new expense while inside report, user is automatically navigated out[/-][+][$250] Reports - When creating new expense while inside report, user is automatically navigated out[/+]melvin-bot commentedon May 27, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021927428430319802299
melvin-bot commentedon May 27, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)54 remaining items
[-][Due for payment 2025-06-17] [Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Reports - When creating new expense while inside report, user is automatically navigated out[/-][+][$250] Reports - When creating new expense while inside report, user is automatically navigated out[/+]dangrous commentedon Jun 18, 2025
Great, let's move forward at least with the first part, and if you can figure out anything about part two, let us know and we can discuss
bernhardoj commentedon Jun 23, 2025
A new PR is ready
cc: @fedirjh
miljakljajic commentedon Jul 9, 2025
PR is merged and closed - is this ready for 50% payment now?
dangrous commentedon Jul 9, 2025
I think so! 7/8 ended the 7-day period. Not sure why the automation didn't trigger, seems like no PRs did that deploy
[-][$250] Reports - When creating new expense while inside report, user is automatically navigated out[/-][+][READY FOR PAYMENT ?][$250] Reports - When creating new expense while inside report, user is automatically navigated out[/+]miljakljajic commentedon Jul 14, 2025
Upwork Job
Reviewer: @fedirjh owed $125 via NewDot
Reviewer: @bernhardoj owed $125 via NewDot
Ready to request in ND! Updated to 50% original price given the regression.
bernhardoj commentedon Jul 14, 2025
Requested in ND.
JmillsExpensify commentedon Jul 14, 2025
$125 approved for @bernhardoj
laurenreidexpensify commentedon Aug 6, 2025
$125 approved in New Expensify for @fedirjh