Skip to content

[Due for payment 2025-07-25] [$250] Expense - Expense report from another workspace cannot be selected on the confirmation page #62911

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.53-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #62351
Email or phone of affected tester (no customers): applausetester+sjdoidj12@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Create two workspaces.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat of the first workspace.
  3. Create two new reports via + > Create report.
  4. Go to expense report, click on the report header and rename the expense report to A and B respectively for each report (to differentiate later).
  5. Go to workspace chat of the second workspace.
  6. Create a new report via + > Create report.
  7. Go to expense report, click on the report header and rename the expense report to C.
  8. Go back to the workspace chat of first workspace.
  9. Click + > Create expense > Manual.
  10. Enter amount > Next.
  11. On confirmation page, click Report.
  12. Select Report C (which is from the other workspace).

Expected Result:

After selecting Report C, Report field will show C as selected.

Actual Result:

After selecting Report C, Report field will show A as selected.
Expense report from another workspace cannot be selected on the confirmation page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021929568339929823344
  • Upwork Job ID: 1929568339929823344
  • Last Price Increase: 2025-06-16
  • Automatic offers:
    • linhvovan29546 | Contributor | 107778538
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @jliexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 28, 2025
  2. melvin-bot commented on May 28, 2025

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 28, 2025

    @melvin-bot

    Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 28, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 28, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. BlameGPT commented on May 28, 2025

    @BlameGPT
    Contributor

    Possible culprit PRs for this issue

    Please 👍 or 👎

  7. self-assigned this
    on May 28, 2025
  8. Beamanator commented on May 28, 2025

    @Beamanator
    Contributor

    Jumping in to help a bit - going to chat in slack, but it does looke like the 1st PR from blame-gpt could be correct - we're reverting & CPing that, so let's see if this gets fixed after that 🙏

  9. 70 remaining items

  10. allroundexperts commented on Jul 20, 2025

    @allroundexperts
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: This was part of the Better Report View feature and was behind a beta. I think we missed this case during the implementation phase. As such, I couldn't point a single PR that caused this.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Have two workspaces

    Test:

    1. Go to workspace chat of the first workspace.
    2. Create two new reports via + > Create report.
    3. Go to expense report, click on the report header and rename the expense report to A and B respectively for each report (to differentiate later).
    4. Go to workspace chat of the second workspace.
    5. Create a new report via + > Create report.
    6. Go to expense report, click on the report header and rename the expense report to C.
    7. Go back to the workspace chat of first workspace.
    8. Click + > Create expense > Manual.
    9. Enter amount > Next.
    10. On confirmation page, click Report.
    11. Select Report C (which is from the other workspace).

    Verify that after selecting Report C, Report field will show C as selected.

    Test 1

    1. Go to workspace chat of the first workspace.
    2. Create two new reports via + > Create report.
    3. Go to expense report, click on the report header and rename the expense report to A and B respectively for each report (to differentiate later).
    4. Go to workspace chat of the second workspace.
    5. Create a new report via + > Create report.
    6. Go to expense report, click on the report header and rename the expense report to C.
    7. Go back to the workspace chat of first workspace.
    8. Click + > Create expense > Manual.
    9. Enter amount > Next.
    10. On confirmation page, click Report.

    Verify that only display the report from the current workspace

    Test 2

    1. Open a individual report
    2. Click + > Create expense

    Verify that the report field is read-only

    Test 3

    1. Open ND
    2. Click + > Create expense
    3. Complete flow to navigate to Confirmation page
    4. Click Report

    Verify that we can select any report from any workspace

    Test 4

    1. Open Self-DM
    2. Create expense
    3. Complete create flow
    4. On Self-DM page test with Submit, Category, Share option

    Verify the test steps from test 1

    Do we agree 👍 or 👎

  11. jliexpensify commented on Jul 20, 2025

    @jliexpensify
    Contributor

    Payment Summary

    https://www.upwork.com/jobs/~021929568339929823344

  12. jliexpensify commented on Jul 24, 2025

    @jliexpensify
    Contributor

    Hi @allroundexperts I'm getting Applause asking about the regression test steps - are you able to view this?

  13. allroundexperts commented on Jul 25, 2025

    @allroundexperts
    Contributor

    Hi @allroundexperts I'm getting Applause asking about the regression test steps - are you able to view this?

    No, I don't have access.

  14. jliexpensify commented on Jul 25, 2025

    @jliexpensify
    Contributor

    @allroundexperts no worries, here's what they have said:

    Image

    I'm also going to try and upload their video.

  15. jliexpensify commented on Jul 25, 2025

    @jliexpensify
    Contributor
    470400222-c5ad64aa-9426-4f6b-88e4-b75f1c016e66.mp4
  16. linhvovan29546 commented on Jul 25, 2025

    @linhvovan29546
    Contributor

    @jliexpensify @allroundexperts Based on this comment #62911 (comment) I think we should have 3 tests. For example in the PR #64782 (comment) I included 3 test steps

    1. Click + > Create expense > Manual.

    I think that should 'Click the global + > Create expense > Manual.

  17. allroundexperts commented on Jul 26, 2025

    @allroundexperts
    Contributor

    @jliexpensify I have updated the test steps. It should now match the steps in the PR.

  18. jliexpensify commented on Jul 27, 2025

    @jliexpensify
    Contributor

    Thank you! I'll update the other issue.

  19. jliexpensify commented on Jul 27, 2025

    @jliexpensify
    Contributor

    Paid and job closed.

    @allroundexperts - payment summary here

    I'll re-open if Applause needs more clarifications on the regression tests.

  20. trjExpensify commented on Jan 5, 2026

    @trjExpensify
    Contributor

    approved $250 for @allroundexperts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions