You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-07-25] [$250] Expense - Expense report from another workspace cannot be selected on the confirmation page #62911
Version Number: 9.1.53-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail:#62351 Email or phone of affected tester (no customers):applausetester+sjdoidj12@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.4 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Create two workspaces.
Go to staging.new.expensify.com
Go to workspace chat of the first workspace.
Create two new reports via + > Create report.
Go to expense report, click on the report header and rename the expense report to A and B respectively for each report (to differentiate later).
Go to workspace chat of the second workspace.
Create a new report via + > Create report.
Go to expense report, click on the report header and rename the expense report to C.
Go back to the workspace chat of first workspace.
Click + > Create expense > Manual.
Enter amount > Next.
On confirmation page, click Report.
Select Report C (which is from the other workspace).
Expected Result:
After selecting Report C, Report field will show C as selected.
Actual Result:
After selecting Report C, Report field will show A as selected.
Expense report from another workspace cannot be selected on the confirmation page.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Fix report selection #62659: PR fixes report selection on the confirmation page with test steps matching selecting reports including from other workspaces, directly addressing the issue where selecting a report from another workspace does not update the field.
Jumping in to help a bit - going to chat in slack, but it does looke like the 1st PR from blame-gpt could be correct - we're reverting & CPing that, so let's see if this gets fixed after that 🙏
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: This was part of the Better Report View feature and was behind a beta. I think we missed this case during the implementation phase. As such, I couldn't point a single PR that caused this.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Have two workspaces
Test:
Go to workspace chat of the first workspace.
Create two new reports via + > Create report.
Go to expense report, click on the report header and rename the expense report to A and B respectively for each report (to differentiate later).
Go to workspace chat of the second workspace.
Create a new report via + > Create report.
Go to expense report, click on the report header and rename the expense report to C.
Go back to the workspace chat of first workspace.
Click + > Create expense > Manual.
Enter amount > Next.
On confirmation page, click Report.
Select Report C (which is from the other workspace).
Verify that after selecting Report C, Report field will show C as selected.
Test 1
Go to workspace chat of the first workspace.
Create two new reports via + > Create report.
Go to expense report, click on the report header and rename the expense report to A and B respectively for each report (to differentiate later).
Go to workspace chat of the second workspace.
Create a new report via + > Create report.
Go to expense report, click on the report header and rename the expense report to C.
Go back to the workspace chat of first workspace.
Click + > Create expense > Manual.
Enter amount > Next.
On confirmation page, click Report.
Verify that only display the report from the current workspace
Test 2
Open a individual report
Click + > Create expense
Verify that the report field is read-only
Test 3
Open ND
Click + > Create expense
Complete flow to navigate to Confirmation page
Click Report
Verify that we can select any report from any workspace
Test 4
Open Self-DM
Create expense
Complete create flow
On Self-DM page test with Submit, Category, Share option
Activity
melvin-bot commentedon May 28, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 28, 2025
Triggered auto assignment to @cristipaval (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 28, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 28, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
BlameGPT commentedon May 28, 2025
Possible culprit PRs for this issue
Please 👍 or 👎
Beamanator commentedon May 28, 2025
Jumping in to help a bit - going to chat in slack, but it does looke like the 1st PR from blame-gpt could be correct - we're reverting & CPing that, so let's see if this gets fixed after that 🙏
70 remaining items
allroundexperts commentedon Jul 20, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: This was part of the
Better Report Viewfeature and was behind a beta. I think we missed this case during the implementation phase. As such, I couldn't point a single PR that caused this.[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Verify that after selecting Report C, Report field will show C as selected.
Test 1
Verify that only display the report from the current workspace
Test 2
Verify that the report field is read-only
Test 3
Verify that we can select any report from any workspace
Test 4
Verify the test steps from test 1
Do we agree 👍 or 👎
jliexpensify commentedon Jul 20, 2025
Payment Summary
https://www.upwork.com/jobs/~021929568339929823344
jliexpensify commentedon Jul 24, 2025
Hi @allroundexperts I'm getting Applause asking about the regression test steps - are you able to view this?
allroundexperts commentedon Jul 25, 2025
No, I don't have access.
jliexpensify commentedon Jul 25, 2025
@allroundexperts no worries, here's what they have said:
I'm also going to try and upload their video.
jliexpensify commentedon Jul 25, 2025
470400222-c5ad64aa-9426-4f6b-88e4-b75f1c016e66.mp4
linhvovan29546 commentedon Jul 25, 2025
@jliexpensify @allroundexperts Based on this comment #62911 (comment) I think we should have 3 tests. For example in the PR #64782 (comment) I included 3 test steps
I think that should 'Click the global + > Create expense > Manual.
allroundexperts commentedon Jul 26, 2025
@jliexpensify I have updated the test steps. It should now match the steps in the PR.
jliexpensify commentedon Jul 27, 2025
Thank you! I'll update the other issue.
jliexpensify commentedon Jul 27, 2025
Paid and job closed.
@allroundexperts - payment summary here
I'll re-open if Applause needs more clarifications on the regression tests.
trjExpensify commentedon Jan 5, 2026
approved $250 for @allroundexperts.