Skip to content

[HOLD] [$250] Remove the "One-expense report" view #63024

Closed

Description

@JmillsExpensify

Background

We originally introduced the "one-expense report" view with the assumption that:

  • Expenses would be approved immediately, consistently

  • Viewing a single expense directly in the report simplified the experience.

Image

Problem

We’ve run into numerous issues and UX inconsistencies:

  • The majority of our members manually submit reports with multiple expenses.

  • Delayed/instant submission batches expenses together by default, so there's no way to reliably guarantee one-expense-per-report.

  • The "one-expense report" view is an on-going source of bugs.

  • Even internal Expensify employees are often confused. For instance, in the "one-expense report" the total is at the top of the report by necessity, though in the "TradReport" design the total is at the bottom.

  • On mobile, the supposed benefit of "seeing everything at a glance" doesn’t hold up—opening a one-expense report requires scrolling through a long expense form before you see any details.

  • "One expense" disrupts our consistent “TradReport” design, which users now expect across the app

CleanShot.2025-05-29.at.10.14.37.mp4

Solution

Remove the "one-expense report" view entirely. This will reduce bugs, simplify maintenance, and unify our app design. What this means in practice:

  • All reports—whether they contain one expense or many—will share this same layout.

Image

  • Expenses on the Reports > Expenses view show either a View button or a Review button (when violations present)

  • No changes to Inbox report previews.

  • No changes to group-by:report search results.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021928020802640068123
  • Upwork Job ID: 1928020802640068123
  • Last Price Increase: 2025-05-29
Issue OwnerCurrent Issue Owner: @Kicu

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 29, 2025
  2. melvin-bot commented on May 29, 2025

    @melvin-bot

    Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

  3. JakubKorytko commented on May 29, 2025

    @JakubKorytko
    Member

    If it is fine to start working on this either tomorrow or on Monday, please assign it to me.

  4. mountiny commented on May 29, 2025

    @mountiny
    Contributor

    It might require some backend changes and clean up for sure so happy to help with this one

  5. JmillsExpensify commented on May 29, 2025

    @JmillsExpensify
    ContributorAuthor

    Nice we're set. Thanks!

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 29, 2025
  7. melvin-bot commented on May 29, 2025

    @melvin-bot
  8. changed the title [-]Remove the "One-expense report" view[/-] [+][$250] Remove the "One-expense report" view[/+] on May 29, 2025
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 29, 2025
  10. 18 remaining items

  11. shawnborton commented on Jun 3, 2025

    @shawnborton
    Contributor

    I'm curious, in case this task goes through would it mean that the "RHP transaction view" when clicking on transaction row goes away?

    I don't think so, no. I think if you are on Reports > Expenses and you click on an expense, each expense should open with just the expense view in the RHP. Does that make sense?

    Should I still create a test branch or wait with anything since this was put on HOLD? currently Im waiting.

    I commented in Slack but I would still love to see a test branch!

  12. Kicu commented on Jun 3, 2025

    @Kicu
    Contributor

    @shawnborton you can use this PR to trigger ad-hoc: #63341

    However I focused on not putting a lot of work there, and since single transaction thread logic is spread over many places, there might be some bugs.
    But to clean it up properly, means understanding all the edge cases fully - which means spending more time on this.
    If something that you would expect to work doesn't - please shout.

    What should work and I tested:

    • in Inbox if you click a preview for report that has only 1 transaction -> you should get table view with 1 expense
    • if you do the flow: "+" -> Create Report -> you see empty report -> "Create Expense" -> you stay on table view with 1 expense
  13. shawnborton commented on Jun 3, 2025

    @shawnborton
    Contributor

    On it!

  14. melvin-bot commented on Jun 9, 2025

    @melvin-bot

    @Kicu Eep! 4 days overdue now. Issues have feelings too...

  15. luacmartins commented on Jun 9, 2025

    @luacmartins
    Contributor

    On hold for discussions

  16. JmillsExpensify commented on Jun 11, 2025

    @JmillsExpensify
    ContributorAuthor

    Still on hold, @puneetlath is very likely going to pick this up and tweak the solution based on the problem stated above.

  17. JmillsExpensify commented on Jul 11, 2025

    @JmillsExpensify
    ContributorAuthor

    We still have on-going internal disagreement on this issue, so sadly I'm going to close this out for now. We can revisit down the line though, and I expect we will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.MonthlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions