You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-18] [$250] Bottom padding cuts letters off in Workflow approver area #63121
Version Number: v9.1.54-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#62664 Email or phone of affected tester (no customers):applausetester+en@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Macbook Pro 2023 / Sequoia 15.2 App Component: Workspace Settings
Action Performed:
Precond: User has a workspace
Access staging.new.expensify.com or open the Desktop app
Login to a valid user
Tap on Workspace > Member > invite member accounts that contain letters like “Y”, “J”, “G”, etc.
What changes do you think we should make in order to solve the problem?
We should pass the line height style that matches the fontSize of the approver text here. I tested 18px is enough, but we can confirm with the design team to choose the best result
descriptionTextStyle={[styles.textNormalThemeText, styles.lineHeightLarge]} // or we can use lineHeightXLarge
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
We can add a flag to only apply textLineHeightNormal when it's necessary, otherwise the fallback line height will be StyleUtils.getLineHeightStyle(variables.fontSizeNormalHeight) (20px)
title ? styles.textLineHeightNormal : StyleUtils.getLineHeightStyle(variables.fontSizeNormalHeight),
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Bottom padding cuts letters off in Workflow approver area[/-][+][$250] Bottom padding cuts letters off in Workflow approver area[/+]on Jun 2, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.64-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ishpaul777@muttmuure@ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: no need this was very minor ui issue
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. not recommended, very minor ui issue
Activity
melvin-bot commentedon May 30, 2025
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.thelullabyy commentedon May 30, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
These letters are slightly cut off at the bottom
What is the root cause of that problem?
The default description has
textLabelSupportingwith thefontSize: 13App/src/components/MenuItem.tsx
Line 529 in 733010e
And we add the line height normal style (
16px) if the title exists.App/src/components/MenuItem.tsx
Line 532 in 733010e
The problem is that the approver text has
textNormalThemeTextwithfontSize: 15, then it's cut off because the line height is not enoughApp/src/components/ApprovalWorkflowSection.tsx
Line 92 in 733010e
The same problem with the expense from description here
App/src/components/ApprovalWorkflowSection.tsx
Line 73 in 733010e
What changes do you think we should make in order to solve the problem?
We should pass the line height style that matches the fontSize of the approver text here. I tested
18pxis enough, but we can confirm with the design team to choose the best resultApp/src/components/ApprovalWorkflowSection.tsx
Line 92 in 733010e
App/src/components/ApprovalWorkflowSection.tsx
Line 73 in 733010e
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
We can add a flag to only apply
textLineHeightNormalwhen it's necessary, otherwise the fallback line height will beStyleUtils.getLineHeightStyle(variables.fontSizeNormalHeight)(20px)App/src/components/MenuItem.tsx
Line 532 in 733010e
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Jun 2, 2025
@muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-]Bottom padding cuts letters off in Workflow approver area[/-][+][$250] Bottom padding cuts letters off in Workflow approver area[/+]melvin-bot commentedon Jun 2, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021929532731643910351
melvin-bot commentedon Jun 2, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (
External)muttmuure commentedon Jun 3, 2025
Awaiting C+ review
18 remaining items
melvin-bot commentedon Jun 11, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 11, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.64-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-18. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 11, 2025
@ishpaul777 @muttmuure @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
ishpaul777 commentedon Jun 18, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/46562/files#r2155408613
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: no need this was very minor ui issue
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. not recommended, very minor ui issue
muttmuure commentedon Jun 22, 2025
$250 - @ishpaul777 C+
$250 - @thelullabyy C
muttmuure commentedon Jun 25, 2025
@thelullabyy has been paid
@ishpaul777 will request via ND
garrettmknight commentedon Jul 3, 2025
$250 approved for @ishpaul777