Skip to content

[Due for payment 2025-06-18] [$250] Bottom padding cuts letters off in Workflow approver area #63121

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.54-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #62664
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Macbook Pro 2023 / Sequoia 15.2
App Component: Workspace Settings

Action Performed:

Precond: User has a workspace

  1. Access staging.new.expensify.com or open the Desktop app
  2. Login to a valid user
  3. Tap on Workspace > Member > invite member accounts that contain letters like “Y”, “J”, “G”, etc.
  4. Tap on Workspace > Workflow > Go to approver
  5. select member in step 3

Expected Result:

User expects all text to display correctly

Actual Result:

These letters are slightly cut off at the bottom

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021929532731643910351
  • Upwork Job ID: 1929532731643910351
  • Last Price Increase: 2025-06-02
  • Automatic offers:
    • thelullabyy | Contributor | 107567613
Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 30, 2025
  2. melvin-bot commented on May 30, 2025

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. thelullabyy commented on May 30, 2025

    @thelullabyy
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    These letters are slightly cut off at the bottom

    What is the root cause of that problem?

    The default description has textLabelSupporting with the fontSize: 13

    styles.textLabelSupporting,

    And we add the line height normal style (16px) if the title exists.

    title ? styles.textLineHeightNormal : StyleUtils.getLineHeightStyle(variables.fontSizeNormalHeight),

    The problem is that the approver text has textNormalThemeText with fontSize: 15, then it's cut off because the line height is not enough

    descriptionTextStyle={styles.textNormalThemeText}

    The same problem with the expense from description here

    descriptionTextStyle={styles.textNormalThemeText}

    What changes do you think we should make in order to solve the problem?

    We should pass the line height style that matches the fontSize of the approver text here. I tested 18px is enough, but we can confirm with the design team to choose the best result

    descriptionTextStyle={[styles.textNormalThemeText, styles.lineHeightLarge]} // or we can use lineHeightXLarge
    

    descriptionTextStyle={styles.textNormalThemeText}

    descriptionTextStyle={styles.textNormalThemeText}

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    We can add a flag to only apply textLineHeightNormal when it's necessary, otherwise the fallback line height will be StyleUtils.getLineHeightStyle(variables.fontSizeNormalHeight) (20px)

    title ? styles.textLineHeightNormal : StyleUtils.getLineHeightStyle(variables.fontSizeNormalHeight),

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. melvin-bot commented on Jun 2, 2025

    @melvin-bot

    @muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 2, 2025
  6. changed the title [-]Bottom padding cuts letters off in Workflow approver area[/-] [+][$250] Bottom padding cuts letters off in Workflow approver area[/+] on Jun 2, 2025
  7. melvin-bot commented on Jun 2, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 2, 2025
  9. melvin-bot commented on Jun 2, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

  10. muttmuure commented on Jun 3, 2025

    @muttmuure
    Contributor

    Awaiting C+ review

  11. 18 remaining items

  12. melvin-bot commented on Jun 11, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jun 11, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.64-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-18. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Jun 11, 2025

    @melvin-bot

    @ishpaul777 @muttmuure @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. ishpaul777 commented on Jun 18, 2025

    @ishpaul777
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/46562/files#r2155408613

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: no need this was very minor ui issue

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. not recommended, very minor ui issue

  16. muttmuure commented on Jun 22, 2025

    @muttmuure
    Contributor

    $250 - @ishpaul777 C+
    $250 - @thelullabyy C

  17. muttmuure commented on Jun 25, 2025

    @muttmuure
    Contributor

    @thelullabyy has been paid

    @ishpaul777 will request via ND

  18. garrettmknight commented on Jul 3, 2025

    @garrettmknight
    Contributor

    $250 approved for @ishpaul777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions