Skip to content

[Due for payment 2025-06-12] Reports - No scroll bar in the contact list when accessed from From filter button #63334

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.56-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check - new feature testing
If this was caught during regression testing, add the test name, ID and link from TestRail: #62851
Email or phone of affected tester (no customers): applausetester+020606kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Search

Action Performed:

Precondition:

  • Log in with an account that has many contacts (Expensifail account).
  1. Go to staging.new.expensify.com
  2. Go to Reports > Expenses.
  3. Click Filters.
  4. Click From.
  5. Scroll the contact list.
  6. Note that there is scroll bar in the contact list.
  7. Close the RHP.
  8. Click From filter.
  9. Scroll the list.

Expected Result:

There will be scroll bar in the contact list when accessed from From filter button.

Actual Result:

There is no scroll bar in the contact list when accessed from From filter button.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6849493_1748941092675.20250603_165514.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @flaviadefaria

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 3, 2025
  2. melvin-bot commented on Jun 3, 2025

    @melvin-bot

    Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 3, 2025

    @melvin-bot

    Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jun 3, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 3, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. nlemma commented on Jun 3, 2025

    @nlemma
    Author

    @flaviadefaria FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. MobileMage commented on Jun 3, 2025

    @MobileMage
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The contact list in the "From" filter dropdown on the Reports page lacks a scrollbar, making it difficult for users to navigate through a long list of contacts.

    What is the root cause of that problem?

    The showScrollIndicator prop is explicitly set to false in the UserSelectPopup component, which disables the scrollbar visibility.

    What changes do you think we should make in order to solve the problem?

    Change the showScrollIndicator prop from false to true in src/components/Search/FilterDropdowns/UserSelectPopup.tsx to enable the scrollbar visibility.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    1. Verify that the scrollbar is visible when the contact list exceeds the viewport height
    2. Verify that the scrollbar remains visible after selecting and deselecting contacts
    3. Verify that the scrollbar is visible when the list is filtered through search

    What alternative solutions did you explore? (Optional)

    None - this is a straightforward prop change to enable an existing feature.

  8. JS00001 commented on Jun 3, 2025

    @JS00001
    Contributor

    will fix this and cp, caused by my changes

  9. 2 remaining items

  10. luacmartins commented on Jun 3, 2025

    @luacmartins
    Contributor

    I think we can demote this one since it's a really small UI issue

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 5, 2025
  12. changed the title [-]Reports - No scroll bar in the contact list when accessed from From filter button[/-] [+][Due for payment 2025-06-12] Reports - No scroll bar in the contact list when accessed from From filter button[/+] on Jun 5, 2025
  13. melvin-bot commented on Jun 5, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jun 5, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.59-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-12. 🎊

  15. melvin-bot commented on Jun 5, 2025

    @melvin-bot

    @JS00001 @flaviadefaria @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. JS00001 commented on Jun 6, 2025

    @JS00001
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: My own PR

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: wasn't critical

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

    Doesn't need regression tests, this is a one-off implementation issue in my PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions