You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-12] Reports - No scroll bar in the contact list when accessed from From filter button #63334
Version Number: 9.1.56-1 Reproducible in staging?: Yes Reproducible in production?: Unable to check - new feature testing If this was caught during regression testing, add the test name, ID and link from TestRail:#62851 Email or phone of affected tester (no customers):applausetester+020606kh@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.4 / Chrome App Component: Search
Action Performed:
Precondition:
Log in with an account that has many contacts (Expensifail account).
Go to staging.new.expensify.com
Go to Reports > Expenses.
Click Filters.
Click From.
Scroll the contact list.
Note that there is scroll bar in the contact list.
Close the RHP.
Click From filter.
Scroll the list.
Expected Result:
There will be scroll bar in the contact list when accessed from From filter button.
Actual Result:
There is no scroll bar in the contact list when accessed from From filter button.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@flaviadefaria FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Please re-state the problem that we are trying to solve in this issue.
The contact list in the "From" filter dropdown on the Reports page lacks a scrollbar, making it difficult for users to navigate through a long list of contacts.
What is the root cause of that problem?
The showScrollIndicator prop is explicitly set to false in the UserSelectPopup component, which disables the scrollbar visibility.
What changes do you think we should make in order to solve the problem?
Change the showScrollIndicator prop from false to true in src/components/Search/FilterDropdowns/UserSelectPopup.tsx to enable the scrollbar visibility.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Verify that the scrollbar is visible when the contact list exceeds the viewport height
Verify that the scrollbar remains visible after selecting and deselecting contacts
Verify that the scrollbar is visible when the list is filtered through search
What alternative solutions did you explore? (Optional)
None - this is a straightforward prop change to enable an existing feature.
changed the title [-]Reports - No scroll bar in the contact list when accessed from From filter button[/-][+][Due for payment 2025-06-12] Reports - No scroll bar in the contact list when accessed from From filter button[/+]on Jun 5, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.59-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@JS00001@flaviadefaria@JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: My own PR
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: wasn't critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Doesn't need regression tests, this is a one-off implementation issue in my PR
Activity
melvin-bot commentedon Jun 3, 2025
Triggered auto assignment to @flaviadefaria (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 3, 2025
Triggered auto assignment to @madmax330 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 3, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 3, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nlemma commentedon Jun 3, 2025
@flaviadefaria FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
MobileMage commentedon Jun 3, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The contact list in the "From" filter dropdown on the Reports page lacks a scrollbar, making it difficult for users to navigate through a long list of contacts.
What is the root cause of that problem?
The
showScrollIndicatorprop is explicitly set tofalsein theUserSelectPopupcomponent, which disables the scrollbar visibility.What changes do you think we should make in order to solve the problem?
Change the
showScrollIndicatorprop fromfalsetotrueinsrc/components/Search/FilterDropdowns/UserSelectPopup.tsxto enable the scrollbar visibility.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
None - this is a straightforward prop change to enable an existing feature.
JS00001 commentedon Jun 3, 2025
will fix this and cp, caused by my changes
2 remaining items
luacmartins commentedon Jun 3, 2025
I think we can demote this one since it's a really small UI issue
[-]Reports - No scroll bar in the contact list when accessed from From filter button[/-][+][Due for payment 2025-06-12] Reports - No scroll bar in the contact list when accessed from From filter button[/+]melvin-bot commentedon Jun 5, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 5, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.59-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-12. 🎊
melvin-bot commentedon Jun 5, 2025
@JS00001 @flaviadefaria @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
JS00001 commentedon Jun 6, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: My own PR
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: wasn't critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎