You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-11] [Reject] Hold modal, Hold/Reject modal and role-based modal updates #63363
Slack conversation (hyperlinked to channel name): convert
Update Hold educational modal trigger
Current: The Hold educational modal shows after a submitter completes their first hold by clicking/tapping Hold expense. This is after the member uses the feature so it's not very educational.
Update: Show the Hold educational modal when a submitter clicks/taps Hold for the first time.
Update the Hold modal copy to simplify and focus on submitters
Updated copy:
Use the Hold/Reject modal for both Hold and Reject for approvers
Update: Show the Hold/Reject modal when approvers tap Hold or Reject on a transaction for the first time.
Update the Hold modal to be role-specific, one for submitters and another for approvers
Current: When a submitter or an approver holds their first expense, we show them the same modal when the experiences are different.
Update:
When a submitter taps Hold for the first time, we'll show them the Hold modal above in "Update the Hold modal copy to simplify and focus on submitters".
When an approver taps Hold or Reject for the first time, we'll show them the Hold/Reject modal above in "Update the Hold/Reject modal to simplify copy for approvers". Once they tap 'Got it' in either, we won't show the modal again.
Platforms:
Select the officially supported platforms where the issue was reproduced:
ALL
changed the title [-]Hold modal, Hold/Decline modal and role-based modal updates[/-][+][Holding on Decline] Hold modal, Hold/Decline modal and role-based modal updates[/+]on Jun 3, 2025
changed the title [-][Reject] Hold modal, Hold/Reject modal and role-based modal updates[/-][+][Due for payment 2025-12-11] [Reject] Hold modal, Hold/Reject modal and role-based modal updates[/+]on Dec 4, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.71-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Activity
melvin-bot commentedon Jun 3, 2025
Current assignee @garrettmknight is eligible for the NewFeature assigner, not assigning anyone new.
[-]Hold modal, Hold/Decline modal and role-based modal updates[/-][+][Holding on Decline] Hold modal, Hold/Decline modal and role-based modal updates[/+]garrettmknight commentedon Jun 12, 2025
Copy updated, this will happen after decline is out.
garrettmknight commentedon Jun 17, 2025
Same as above.
garrettmknight commentedon Jun 26, 2025
Same as above.
100 remaining items
lakchote commentedon Dec 2, 2025
PR has been merged.
[-][Reject] Hold modal, Hold/Reject modal and role-based modal updates[/-][+][Due for payment 2025-12-11] [Reject] Hold modal, Hold/Reject modal and role-based modal updates[/+]melvin-bot commentedon Dec 4, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 4, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.71-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-12-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 4, 2025
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mananjadhav commentedon Dec 5, 2025
This is deployed to production and will be paid as a part of the project. Best to close this one in a few days.
Pujan92 commentedon Dec 6, 2025
I am eligible for the payment for reviewing PR #75192.
@garrettmknight could you plz provide payment summary for it.
cc @luacmartins
garrettmknight commentedon Dec 8, 2025
Payment summary:
trjExpensify commentedon Dec 8, 2025
approved $250 for @Pujan92.
mananjadhav commentedon Dec 8, 2025
I think it's safe to close this one out.