Skip to content

[Due for payment 2025-12-11] [Reject] Hold modal, Hold/Reject modal and role-based modal updates #63363

Closed

Description

@garrettmknight

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Slack conversation (hyperlinked to channel name): convert

Update Hold educational modal trigger

Current: The Hold educational modal shows after a submitter completes their first hold by clicking/tapping Hold expense. This is after the member uses the feature so it's not very educational.

Update: Show the Hold educational modal when a submitter clicks/taps Hold for the first time.

Update the Hold modal copy to simplify and focus on submitters

Updated copy:

Image

Use the Hold/Reject modal for both Hold and Reject for approvers

Update: Show the Hold/Reject modal when approvers tap Hold or Reject on a transaction for the first time.

Image

Update the Hold modal to be role-specific, one for submitters and another for approvers

Current: When a submitter or an approver holds their first expense, we show them the same modal when the experiences are different.

Update:

  • When a submitter taps Hold for the first time, we'll show them the Hold modal above in "Update the Hold modal copy to simplify and focus on submitters".
  • When an approver taps Hold or Reject for the first time, we'll show them the Hold/Reject modal above in "Update the Hold/Reject modal to simplify copy for approvers". Once they tap 'Got it' in either, we won't show the modal again.

Platforms:

Select the officially supported platforms where the issue was reproduced:
ALL

Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. melvin-bot commented on Jun 3, 2025

    @melvin-bot

    Current assignee @garrettmknight is eligible for the NewFeature assigner, not assigning anyone new.

  2. changed the title [-]Hold modal, Hold/Decline modal and role-based modal updates[/-] [+][Holding on Decline] Hold modal, Hold/Decline modal and role-based modal updates[/+] on Jun 3, 2025
  3. garrettmknight commented on Jun 12, 2025

    @garrettmknight
    ContributorAuthor

    Copy updated, this will happen after decline is out.

  4. garrettmknight commented on Jun 17, 2025

    @garrettmknight
    ContributorAuthor

    Same as above.

  5. garrettmknight commented on Jun 26, 2025

    @garrettmknight
    ContributorAuthor

    Same as above.

  6. 100 remaining items

  7. lakchote commented on Dec 2, 2025

    @lakchote
    Contributor

    PR has been merged.

  8. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 4, 2025
  9. changed the title [-][Reject] Hold modal, Hold/Reject modal and role-based modal updates[/-] [+][Due for payment 2025-12-11] [Reject] Hold modal, Hold/Reject modal and role-based modal updates[/+] on Dec 4, 2025
  10. melvin-bot commented on Dec 4, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Dec 4, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.71-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-11. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mananjadhav requires payment through NewDot Manual Requests
    • @Pujan92 requires payment through NewDot Manual Requests
    • @truph01 requires payment (Needs manual offer from BZ)
  12. melvin-bot commented on Dec 4, 2025

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  13. mananjadhav commented on Dec 5, 2025

    @mananjadhav
    Collaborator

    This is deployed to production and will be paid as a part of the project. Best to close this one in a few days.

  14. Pujan92 commented on Dec 6, 2025

    @Pujan92
    Contributor

    I am eligible for the payment for reviewing PR #75192.
    @garrettmknight could you plz provide payment summary for it.

    cc @luacmartins

  15. garrettmknight commented on Dec 8, 2025

    @garrettmknight
    ContributorAuthor

    Payment summary:

  16. trjExpensify commented on Dec 8, 2025

    @trjExpensify
    Contributor

    approved $250 for @Pujan92.

  17. mananjadhav commented on Dec 8, 2025

    @mananjadhav
    Collaborator

    I think it's safe to close this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions