Skip to content

Remove early return from isFromPublicDomain if domain is public #6337

Closed

Description

@luacmartins

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem

We added the ability to auto approving Expensify Cards for users with private domain as secondary logins here. Since users with a public domain primary login can have Expensify Cards enabled in their account, we should always fetch that information.

Action Performed:

  1. Log into NewDot with a public domain email
  2. Open the browser console and navigate to the application tab.
  3. Search for the user key and verify that isUsingExpensifyCard is not set.

Expected Result:

isUsingExpensifyCard should be set.

Actual Result:

isUsingExpensifyCard is not set.

Workaround:

None.

Platform:

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions