Skip to content

[$1,000] Improve lists performance by not calling useOnyx in list items #63439

Closed
6 of 6 issues completed
Closed

Description

@adhorodyski

Goal of this effort is to make lists across EApp more performant.

We'll achieve this by moving useOnyx connections from within render items up the tree to the list level.
This PR should be used as an example.

Lists to cover:

How to compare your results?

  1. Record before+after performance traces using React Profiler.
  2. Import these into https://kacper-mikolajczak.github.io/rcc/ (with the 'before' being a baseline).
  3. Share your results with the PR
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. mountiny commented on Jun 5, 2025

    @mountiny
    Contributor

    Proposal in Slack here

  2. mountiny commented on Jun 5, 2025

    @mountiny
    Contributor

    From convo with Adam:

    What we will need to do is something like this:

    • so it's List -> PureReportActionItem -> TransactionPreview (some useOnyx calls) -> TransactionPreviewContent (some useOnyx calls)
    • should be List (some useOnyx calls) -> PureReportActionItem -> TransactionPreview -> TransactionPreviewContent

    so at the end every child to PureReportActionItem moves its useOnyx up the tree and does not hold any connection

    I think we could make all the items of the Search list one task and then divide up the ReportActionOne into multiple ones.

    • MoneyRequestPreview
    • MoneyRequestReportPreview
      • EmptyMoneyRequestReportPreview.tsx
      • MoneyRequestReportPreviewContent.tsx
    • TransactionPreview
    • ActionableItemButtons.tsx
    • ChronosOOOListActions.tsx
    • ExportIntegration.tsx
    • ExportWithDropdownMenu.tsx
    • IssueCardMessage.tsx
    • MoneyReportView.tsx
    • MoneyRequestAction.tsx
    • MoneyRequestView.tsx
    • ReportActionItemImage.tsx
    • ReportActionItemImages.tsx
    • ReportPreview.tsx
    • TaskAction.tsx
    • TaskPreview.tsx
    • TaskView.tsx
    • TripDetailsView.tsx
    • TripRoomPreview.tsx

    I think we can aim for a PR for each just to make it as easy to test and revert if needed, but if there are some really similar feel free to combine them to one PR (but not too many in one)

  3. mountiny commented on Jun 5, 2025

    @mountiny
    Contributor

    @hoangzinh @Pujan92 Has been chosen to complete this task for $1000 each. Ideally you split up the work/ components on who will implement what and who will review it (vice versa). Can you please organize together on that?

    Then please write a summary of the plan here for us and lets get cooking @adhorodyski @TMisiukiewicz Will help review the code as well. If you have any questions or anything is unclear, ping us in slack. @mjasikowski and me will be helping lead this from the internal team perspective.

  4. hoangzinh commented on Jun 5, 2025

    @hoangzinh
    Contributor

    Hi @mountiny, will we wait for @mjasikowski to split up those into issues, then @Pujan92 and I will discuss how we divide those issues?

  5. hoangzinh commented on Jun 5, 2025

    @hoangzinh
    Contributor

    When a PR is ready for review, will we loop @adhorodyski and @TMisiukiewicz to get early reviews, or wait until C+ completes the review checklist?

  6. 112 remaining items

  7. hoangzinh commented on Aug 14, 2025

    @hoangzinh
    Contributor

    @trjExpensify We have a bunch of PRs for this issue, but we have a fixed bounty since the beginning for @Pujan92 and me here

  8. trjExpensify commented on Aug 15, 2025

    @trjExpensify
    Contributor

    Okay cool, and we have PRs still to come?

  9. changed the title [-]Improve lists performance by not calling useOnyx in list items[/-] [+][$1,000] Improve lists performance by not calling useOnyx in list items[/+] on Aug 15, 2025
  10. hoangzinh commented on Aug 15, 2025

    @hoangzinh
    Contributor

    It looks like we're good for payment cc @mountiny

  11. Pujan92 commented on Aug 18, 2025

    @Pujan92
    Contributor

    @trjExpensify Could you plz add a payment summary here

  12. trjExpensify commented on Aug 18, 2025

    @trjExpensify
    Contributor

    Nobody has confirmed if there are more PRs to come to consider this work complete, and if it is complete, can we close the issue after summary?

  13. Pujan92 commented on Aug 18, 2025

    @Pujan92
    Contributor

    I believe it is completed, but let's wait for @mountiny's confirmation.

  14. mountiny commented on Aug 18, 2025

    @mountiny
    Contributor

    Yep this should be done and its ready for payment. We agreed for $1000 at the beginning of this project

  15. trjExpensify commented on Aug 18, 2025

    @trjExpensify
    Contributor

    Great, payment summary as follows:

    Both of you can request!

  16. moved this from AWAITING DEPLOYMENT to Done in [#whatsnext] #qualityon Aug 18, 2025
  17. hoangzinh commented on Aug 18, 2025

    @hoangzinh
    Contributor

    Thanks @mountiny @trjExpensify. I requested in ND

  18. twisterdotcom commented on Aug 19, 2025

    @twisterdotcom
    Contributor

    @hoangzinh has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    • Vendor found in VML: True. Status: Active
    • Amount requested: $1000.00. No ### Payment Summary comment from @melvin-bot found. I have therefore verified this manually from the BZ payment summary above.
    • I, @twisterdotcom am not already the BZ assignee. I have approved this payment.
    Zapier Logs Run ID: 00040eee-1967-a89b-a135-4fb4a0ce3631
  19. twisterdotcom commented on Aug 19, 2025

    @twisterdotcom
    Contributor

    Waiting for my thing to run again. Here I was, expecting all Payment Summaries to place the handle before the amount. Here @trjExpensify is, challenging my expectations.

  20. JmillsExpensify commented on Aug 20, 2025

    @JmillsExpensify
    Contributor

    $1,000 approved for @Pujan92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions