You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1,000] Improve lists performance by not calling useOnyx in list items #63439
so it's List -> PureReportActionItem -> TransactionPreview (some useOnyx calls) -> TransactionPreviewContent (some useOnyx calls)
should be List (some useOnyx calls) -> PureReportActionItem -> TransactionPreview -> TransactionPreviewContent
so at the end every child to PureReportActionItem moves its useOnyx up the tree and does not hold any connection
I think we could make all the items of the Search list one task and then divide up the ReportActionOne into multiple ones.
MoneyRequestPreview
MoneyRequestReportPreview
EmptyMoneyRequestReportPreview.tsx
MoneyRequestReportPreviewContent.tsx
TransactionPreview
ActionableItemButtons.tsx
ChronosOOOListActions.tsx
ExportIntegration.tsx
ExportWithDropdownMenu.tsx
IssueCardMessage.tsx
MoneyReportView.tsx
MoneyRequestAction.tsx
MoneyRequestView.tsx
ReportActionItemImage.tsx
ReportActionItemImages.tsx
ReportPreview.tsx
TaskAction.tsx
TaskPreview.tsx
TaskView.tsx
TripDetailsView.tsx
TripRoomPreview.tsx
I think we can aim for a PR for each just to make it as easy to test and revert if needed, but if there are some really similar feel free to combine them to one PR (but not too many in one)
@hoangzinh@Pujan92 Has been chosen to complete this task for $1000 each. Ideally you split up the work/ components on who will implement what and who will review it (vice versa). Can you please organize together on that?
Then please write a summary of the plan here for us and lets get cooking @adhorodyski@TMisiukiewicz Will help review the code as well. If you have any questions or anything is unclear, ping us in slack. @mjasikowski and me will be helping lead this from the internal team perspective.
changed the title [-]Improve lists performance by not calling useOnyx in list items[/-][+][$1,000] Improve lists performance by not calling useOnyx in list items[/+]on Aug 15, 2025
Amount requested: $1000.00. No ### Payment Summary comment from @melvin-bot found. I have therefore verified this manually from the BZ payment summary above.
I, @twisterdotcom am not already the BZ assignee. I have approved this payment.
Waiting for my thing to run again. Here I was, expecting all Payment Summaries to place the handle before the amount. Here @trjExpensify is, challenging my expectations.
Activity
mountiny commentedon Jun 5, 2025
Proposal in Slack here
mountiny commentedon Jun 5, 2025
From convo with Adam:
What we will need to do is something like this:
so at the end every child to PureReportActionItem moves its useOnyx up the tree and does not hold any connection
I think we could make all the items of the Search list one task and then divide up the ReportActionOne into multiple ones.
I think we can aim for a PR for each just to make it as easy to test and revert if needed, but if there are some really similar feel free to combine them to one PR (but not too many in one)
mountiny commentedon Jun 5, 2025
@hoangzinh @Pujan92 Has been chosen to complete this task for $1000 each. Ideally you split up the work/ components on who will implement what and who will review it (vice versa). Can you please organize together on that?
Then please write a summary of the plan here for us and lets get cooking @adhorodyski @TMisiukiewicz Will help review the code as well. If you have any questions or anything is unclear, ping us in slack. @mjasikowski and me will be helping lead this from the internal team perspective.
hoangzinh commentedon Jun 5, 2025
Hi @mountiny, will we wait for @mjasikowski to split up those into issues, then @Pujan92 and I will discuss how we divide those issues?
hoangzinh commentedon Jun 5, 2025
When a PR is ready for review, will we loop @adhorodyski and @TMisiukiewicz to get early reviews, or wait until C+ completes the review checklist?
112 remaining items
hoangzinh commentedon Aug 14, 2025
@trjExpensify We have a bunch of PRs for this issue, but we have a fixed bounty since the beginning for @Pujan92 and me here
trjExpensify commentedon Aug 15, 2025
Okay cool, and we have PRs still to come?
[-]Improve lists performance by not calling useOnyx in list items[/-][+][$1,000] Improve lists performance by not calling useOnyx in list items[/+]hoangzinh commentedon Aug 15, 2025
It looks like we're good for payment cc @mountiny
Pujan92 commentedon Aug 18, 2025
@trjExpensify Could you plz add a payment summary here
trjExpensify commentedon Aug 18, 2025
Nobody has confirmed if there are more PRs to come to consider this work complete, and if it is complete, can we close the issue after summary?
Pujan92 commentedon Aug 18, 2025
I believe it is completed, but let's wait for @mountiny's confirmation.
mountiny commentedon Aug 18, 2025
Yep this should be done and its ready for payment. We agreed for $1000 at the beginning of this project
trjExpensify commentedon Aug 18, 2025
Great, payment summary as follows:
Both of you can request!
hoangzinh commentedon Aug 18, 2025
Thanks @mountiny @trjExpensify. I requested in ND
twisterdotcom commentedon Aug 19, 2025
@hoangzinh has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
### Payment Summarycomment from @melvin-bot found. I have therefore verified this manually from the BZ payment summary above.Zapier Logs
Run ID: 00040eee-1967-a89b-a135-4fb4a0ce3631twisterdotcom commentedon Aug 19, 2025
Waiting for my thing to run again. Here I was, expecting all Payment Summaries to place the handle before the amount. Here @trjExpensify is, challenging my expectations.
JmillsExpensify commentedon Aug 20, 2025
$1,000 approved for @Pujan92