You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Combined report is not opened when the expense report is with Manager McTest #63493
Version Number: 9.1.59-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):sjdnoijdojdso@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.4 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Log in with a new Gmail account.
Open FAB > Create expense > Manual.
Enter amount > Nextn.
Select Manager McTest.
Click Create expense.
In 1:1 DM, click on the expense preview.
Expected Result:
Transaction thread will open directly because the report has only one expense.
Actual Result:
Expense report opens. User will have to click on the expense preview again to open transaction thread.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Ooh I misunderstood the steps. That PR is the issue. Ruh row. Pinging people involved with it because I don't want to make the revert PR since I have zero context on it and it's not a clean revert.
OK. I think I found the RCA. I think BE is returning the IOUTransactionID 's value for both originalMessage that has originalMessage.type is pay or create. It should only return IOUTransactionID with originalMessage that has type: create
I checked on production. I think the BE changes that caused this issue have been deployed to production, so this issue is now in production, too. We can remove the deploy blocker and demote it to daily. @blimpich Let me know if you want to fix this issue on BE or FE. If you want to fix it from FE, I can raise a PR.
Activity
melvin-bot commentedon Jun 4, 2025
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 4, 2025
Triggered auto assignment to @blimpich (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 4, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 4, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
BlameGPT commentedon Jun 4, 2025
Possible culprit PRs for this issue
blimpich commentedon Jun 4, 2025
Having VM issues, not able to reproduce yet. Probably not a BE blocker though.
blimpich commentedon Jun 4, 2025
Fixed VM issues. Hmm, I tried reverting #62080 locally to test this but it wasn't a clean revert. Didn't fix the issue.
blimpich commentedon Jun 4, 2025
Ooh I misunderstood the steps. That PR is the issue. Ruh row. Pinging people involved with it because I don't want to make the revert PR since I have zero context on it and it's not a clean revert.
blimpich commentedon Jun 4, 2025
Left side is reverted local dev, right side is prod where the issue doesn't exist yet.
https://github.com/user-attachments/assets/c958bdbe-08a9-43b3-9e62-5a9fd5050296
blimpich commentedon Jun 4, 2025
Posted to Slack in open source channel
posted to #engineering-chat in case anyone has bandwidth to take this to the finish line. Otherwise I will get to this tomorrow morning when I sign on.
hungvu193 commentedon Jun 5, 2025
Checking 👀
hungvu193 commentedon Jun 5, 2025
hungvu193 commentedon Jun 5, 2025
OK. I think I found the RCA. I think BE is returning the
IOUTransactionID's value for bothoriginalMessagethat hasoriginalMessage.typeispayorcreate. It should only returnIOUTransactionIDwithoriginalMessagethat hastype: createApp/src/libs/ReportActionsUtils.ts
Lines 1256 to 1260 in 437acdd
This will make
iouRequestActions.length > 0App/src/libs/ReportActionsUtils.ts
Lines 1266 to 1268 in 437acdd
and
transactionThreadReportIDreturn null here:App/src/pages/home/ReportScreen.tsx
Line 307 in 437acdd
I tried to add an extra filter here, and it fixed the issue:
hungvu193 commentedon Jun 5, 2025
cc @VickyStash for the comment above
hungvu193 commentedon Jun 5, 2025
I checked on production. I think the BE changes that caused this issue have been deployed to production, so this issue is now in production, too. We can remove the deploy blocker and demote it to daily.
@blimpich Let me know if you want to fix this issue on BE or FE. If you want to fix it from FE, I can raise a PR.
Screen.Recording.2025-06-05.at.10.56.42.mov
blimpich commentedon Jun 5, 2025
Asked for retest from Applause
IuliiaHerets commentedon Jun 5, 2025
@blimpich Issue is not repro
Recording.3221.mp4