Skip to content

Expense - Combined report is not opened when the expense report is with Manager McTest #63493

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.59-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): sjdnoijdojdso@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with a new Gmail account.
  3. Open FAB > Create expense > Manual.
  4. Enter amount > Nextn.
  5. Select Manager McTest.
  6. Click Create expense.
  7. In 1:1 DM, click on the expense preview.

Expected Result:

Transaction thread will open directly because the report has only one expense.

Actual Result:

Expense report opens. User will have to click on the expense preview again to open transaction thread.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6850920_1749068409193.20250605_041728.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 4, 2025
  2. melvin-bot commented on Jun 4, 2025

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 4, 2025

    @melvin-bot

    Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jun 4, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 4, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. BlameGPT commented on Jun 4, 2025

    @BlameGPT
    Contributor

    Possible culprit PRs for this issue

  7. blimpich commented on Jun 4, 2025

    @blimpich
    Contributor

    Having VM issues, not able to reproduce yet. Probably not a BE blocker though.

  8. removed
    DeployBlockerIndicates it should block deploying the API
    on Jun 4, 2025
  9. blimpich commented on Jun 4, 2025

    @blimpich
    Contributor

    Fixed VM issues. Hmm, I tried reverting #62080 locally to test this but it wasn't a clean revert. Didn't fix the issue.

  10. blimpich commented on Jun 4, 2025

    @blimpich
    Contributor

    Ooh I misunderstood the steps. That PR is the issue. Ruh row. Pinging people involved with it because I don't want to make the revert PR since I have zero context on it and it's not a clean revert.

  11. blimpich commented on Jun 4, 2025

    @blimpich
    Contributor

    Left side is reverted local dev, right side is prod where the issue doesn't exist yet.
    https://github.com/user-attachments/assets/c958bdbe-08a9-43b3-9e62-5a9fd5050296

  12. blimpich commented on Jun 4, 2025

    @blimpich
    Contributor
  13. hungvu193 commented on Jun 5, 2025

    @hungvu193
    Contributor

    Checking 👀

  14. hungvu193 commented on Jun 5, 2025

    @hungvu193
  15. hungvu193 commented on Jun 5, 2025

    @hungvu193
    Contributor

    OK. I think I found the RCA. I think BE is returning the IOUTransactionID 's value for both originalMessage that has originalMessage.type is pay or create. It should only return IOUTransactionID with originalMessage that has type: create

    (!!originalMessage?.IOUTransactionID ||
    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
    (isMessageDeleted(action) && action.childVisibleActionCount) ||
    (action.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && (isOffline ?? isNetworkOffline)))
    ) {

    This will make iouRequestActions.length > 0

    if (!iouRequestActions.length || iouRequestActions.length > 1) {
    return;
    }

    and transactionThreadReportID return null here:

    const transactionThreadReportID = getOneTransactionThreadReportID(reportID, reportActions ?? [], isOffline, reportTransactionIDs);

    I tried to add an extra filter here, and it fixed the issue:

    -((!!originalMessage?.IOUTransactionID ) ||
    +((!!originalMessage?.IOUTransactionID && originalMessage.type === 'create') ||
  16. hungvu193 commented on Jun 5, 2025

    @hungvu193
    Contributor
  17. hungvu193 commented on Jun 5, 2025

    @hungvu193
    Contributor

    I checked on production. I think the BE changes that caused this issue have been deployed to production, so this issue is now in production, too. We can remove the deploy blocker and demote it to daily.
    @blimpich Let me know if you want to fix this issue on BE or FE. If you want to fix it from FE, I can raise a PR.

    Screen.Recording.2025-06-05.at.10.56.42.mov
  18. removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 5, 2025
  19. blimpich commented on Jun 5, 2025

    @blimpich
    Contributor

    Asked for retest from Applause

  20. IuliiaHerets commented on Jun 5, 2025

    @IuliiaHerets

    @blimpich Issue is not repro

    Recording.3221.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions