Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: NA
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: NA
Email or phone of affected tester (no customers): NA
Logs: https://stackoverflow.com/c/expensify/questions/4856 NA
Expensify/Expensify Issue URL: NA
Issue reported by: @flaviadefaria
Slack conversation (hyperlinked to channel name): #migrate
Action Performed:
- Be migrated to NewDot
- Go to the GC and click to create a new expense
Expected Result:
The user should proceed with the expense creation flow without seeing the "Try a test receipt" tooltip
Actual Result:
The user sees the "Try a test receipt" tooltip
Workaround:
Yes
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
We're displaying the "Try a test receipt" tooltip also for migrated customers who might already have scanned receipts for years. We should remove this tooltips for any users that have "tryNewDot": nudgeMigration timestamp = not null
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021930626066668258447
- Upwork Job ID: 1930626066668258447
- Last Price Increase: 2025-06-05
- Automatic offers:
- suneox | Reviewer | 107632483
- FitseTLT | Contributor | 107632484
Activity
melvin-bot commentedon Jun 5, 2025
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Remove "Try a test receipt" tooltip for migrated users[/-][+][$250] Remove "Try a test receipt" tooltip for migrated users[/+]melvin-bot commentedon Jun 5, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021930626066668258447
melvin-bot commentedon Jun 5, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (
External)nyomanjyotisa commentedon Jun 5, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Remove "Try a test receipt" tooltip for migrated users
What is the root cause of that problem?
We always show scan test receipt
App/src/components/ProductTrainingContext/TOOLTIPS.ts
Lines 132 to 142 in 31fc9da
What changes do you think we should make in order to solve the problem?
update the
shouldShowfor scan test receipt to not showing the toolip if the current user have "tryNewDot": nudgeMigration timestamp = not nullWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
None
FitseTLT commentedon Jun 5, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-06-05 15:22:41 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Remove "Try a test receipt" tooltip for migrated users
What is the root cause of that problem?
We are always showing SCAN_TEST_TOOLTIP
App/src/components/ProductTrainingContext/TOOLTIPS.ts
Lines 132 to 142 in 31fc9da
What changes do you think we should make in order to solve the problem?
We need to hide it if it has
hasBeenAddedToNudgeMigrationThen if we need to hide the other tooltips linked to mc test receipt :
If we need to hide mc manager as a participant when
hasBeenAddedToNudgeMigrationbecause these users are already experienced we can updateApp/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx
Line 147 in aeffce7
This will automatically hide
SCAN_TEST_TOOLTIP_MANAGERas it only appears on mc test managerApp/src/components/SelectionList/InviteMemberListItem.tsx
Lines 50 to 52 in aeffce7
and also
SCAN_TEST_CONFIRMATIONApp/src/components/MoneyRequestConfirmationList.tsx
Lines 249 to 250 in aeffce7
But if we don't hide mc test manager but hide only the tooltips we will need to explicitly hide both the tooltips via their shouldShow here.
But
SCAN_TEST_DRIVE_CONFIRMATIONcan still appear for test drive receipt so if we need to hide it we can do via the shouldShow here just likeSCAN_TEST_TOOLTIPApp/src/components/ProductTrainingContext/TOOLTIPS.ts
Line 183 in aeffce7
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
If needed we can add a test in
ProductTrainingContextProviderto assert we don't show test receipt tooltip for a user added to nudge migration.What alternative solutions did you explore? (Optional)
nkdengineer commentedon Jun 5, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The user sees the "Try a test receipt" tooltip
What is the root cause of that problem?
We're showing the test receipt for all users
App/src/components/ProductTrainingContext/TOOLTIPS.ts
Lines 132 to 164 in fd5a995
What changes do you think we should make in order to solve the problem?
We should hide all test receipt tooltips if the user is migrated user by adding
hasBeenAddedToNudgeMigrationcheckApp/src/components/ProductTrainingContext/TOOLTIPS.ts
Lines 132 to 164 in fd5a995
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Update
Migrated User Scenarioscase inProductTrainingContextProvidertest to verify that the test receipt tooltip isn't displayedWhat alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
23 remaining items
[-][$250] Remove "Try a test receipt" tooltip for migrated users[/-][+][Due for payment 2025-07-01] [$250] Remove "Try a test receipt" tooltip for migrated users[/+]melvin-bot commentedon Jun 24, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 24, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.70-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-07-01. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 24, 2025
@suneox @flaviadefaria @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
flaviadefaria commentedon Jul 2, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
flaviadefaria commentedon Jul 2, 2025
I don't think we need a test rail case for this, so moving directly to payment.
flaviadefaria commentedon Jul 2, 2025
Payment Summary
Contributor: @FitseTLT paid $250 via Upwork = $250 (paid)
Contributor+: @suneox due $250 via Upwork = $250 (paid)