Skip to content

[Due for payment 2025-07-01] [$250] Remove "Try a test receipt" tooltip for migrated users #63564

Closed

Description

@flaviadefaria

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: NA
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: NA
Email or phone of affected tester (no customers): NA
Logs: https://stackoverflow.com/c/expensify/questions/4856 NA
Expensify/Expensify Issue URL: NA
Issue reported by: @flaviadefaria
Slack conversation (hyperlinked to channel name): #migrate

Action Performed:

  1. Be migrated to NewDot
  2. Go to the GC and click to create a new expense

Expected Result:

The user should proceed with the expense creation flow without seeing the "Try a test receipt" tooltip

Actual Result:

The user sees the "Try a test receipt" tooltip

Workaround:

Yes

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

We're displaying the "Try a test receipt" tooltip also for migrated customers who might already have scanned receipts for years. We should remove this tooltips for any users that have "tryNewDot": nudgeMigration timestamp = not null

Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021930626066668258447
  • Upwork Job ID: 1930626066668258447
  • Last Price Increase: 2025-06-05
  • Automatic offers:
    • suneox | Reviewer | 107632483
    • FitseTLT | Contributor | 107632484
Issue OwnerCurrent Issue Owner: @flaviadefaria

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 5, 2025
  2. self-assigned this
    on Jun 5, 2025
  3. melvin-bot commented on Jun 5, 2025

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 5, 2025
  5. changed the title [-]Remove "Try a test receipt" tooltip for migrated users[/-] [+][$250] Remove "Try a test receipt" tooltip for migrated users[/+] on Jun 5, 2025
  6. melvin-bot commented on Jun 5, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 5, 2025
  8. melvin-bot commented on Jun 5, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

  9. nyomanjyotisa commented on Jun 5, 2025

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Remove "Try a test receipt" tooltip for migrated users

    What is the root cause of that problem?

    We always show scan test receipt

    [SCAN_TEST_TOOLTIP]: {
    content: [
    {text: 'productTrainingTooltip.scanTestTooltip.part1', isBold: false},
    {text: 'productTrainingTooltip.scanTestTooltip.part2', isBold: true},
    ],
    onHideTooltip: () => dismissProductTraining(SCAN_TEST_TOOLTIP),
    name: SCAN_TEST_TOOLTIP,
    priority: 900,
    shouldShow: () => true,
    shouldRenderActionButtons: true,
    },

    What changes do you think we should make in order to solve the problem?

    update the shouldShow for scan test receipt to not showing the toolip if the current user have "tryNewDot": nudgeMigration timestamp = not null

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    None

  10. FitseTLT commented on Jun 5, 2025

    @FitseTLT
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-06-05 15:22:41 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Remove "Try a test receipt" tooltip for migrated users

    What is the root cause of that problem?

    We are always showing SCAN_TEST_TOOLTIP

    [SCAN_TEST_TOOLTIP]: {
    content: [
    {text: 'productTrainingTooltip.scanTestTooltip.part1', isBold: false},
    {text: 'productTrainingTooltip.scanTestTooltip.part2', isBold: true},
    ],
    onHideTooltip: () => dismissProductTraining(SCAN_TEST_TOOLTIP),
    name: SCAN_TEST_TOOLTIP,
    priority: 900,
    shouldShow: () => true,
    shouldRenderActionButtons: true,
    },

    What changes do you think we should make in order to solve the problem?

    We need to hide it if it has hasBeenAddedToNudgeMigration

            shouldShow: ({hasBeenAddedToNudgeMigration}) => !hasBeenAddedToNudgeMigration,
    
    

    Then if we need to hide the other tooltips linked to mc test receipt :
    If we need to hide mc manager as a participant when hasBeenAddedToNudgeMigration because these users are already experienced we can update

    canShowManagerMcTest: action !== CONST.IOU.ACTION.SUBMIT,

     const [tryNewDot] = useOnyx(ONYXKEYS.NVP_TRY_NEW_DOT, {canBeMissing: true});
        const hasBeenAddedToNudgeMigration = !!tryNewDot?.nudgeMigration?.timestamp;
    ...
    
                    canShowManagerMcTest:  !hasBeenAddedToNudgeMigration && action !== CONST.IOU.ACTION.SUBMIT,
    
    

    This will automatically hide SCAN_TEST_TOOLTIP_MANAGER as it only appears on mc test manager

    const {renderProductTrainingTooltip, shouldShowProductTrainingTooltip} = useProductTrainingContext(
    CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SCAN_TEST_TOOLTIP_MANAGER,
    !getIsUserSubmittedExpenseOrScannedReceipt() && isBetaEnabled(CONST.BETAS.NEWDOT_MANAGER_MCTEST) && isSelectedManagerMcTest(item.login) && !item.isSelected,

    and also SCAN_TEST_CONFIRMATION

    isTestDriveReceipt ? CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SCAN_TEST_DRIVE_CONFIRMATION : CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SCAN_TEST_CONFIRMATION,
    isTestDriveReceipt || isManagerMcTestReceipt,

    But if we don't hide mc test manager but hide only the tooltips we will need to explicitly hide both the tooltips via their shouldShow here.
    But SCAN_TEST_DRIVE_CONFIRMATION can still appear for test drive receipt so if we need to hide it we can do via the shouldShow here just like SCAN_TEST_TOOLTIP

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    If needed we can add a test in ProductTrainingContextProvider to assert we don't show test receipt tooltip for a user added to nudge migration.

    What alternative solutions did you explore? (Optional)

  11. nkdengineer commented on Jun 5, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The user sees the "Try a test receipt" tooltip

    What is the root cause of that problem?

    We're showing the test receipt for all users

    [SCAN_TEST_TOOLTIP]: {
    content: [
    {text: 'productTrainingTooltip.scanTestTooltip.part1', isBold: false},
    {text: 'productTrainingTooltip.scanTestTooltip.part2', isBold: true},
    ],
    onHideTooltip: () => dismissProductTraining(SCAN_TEST_TOOLTIP),
    name: SCAN_TEST_TOOLTIP,
    priority: 900,
    shouldShow: () => true,
    shouldRenderActionButtons: true,
    },
    [SCAN_TEST_TOOLTIP_MANAGER]: {
    content: [
    {text: 'productTrainingTooltip.scanTestTooltip.part3', isBold: false},
    {text: 'productTrainingTooltip.scanTestTooltip.part4', isBold: true},
    {text: 'productTrainingTooltip.scanTestTooltip.part5', isBold: false},
    ],
    onHideTooltip: (isDismissedUsingCloseButton = false) => dismissProductTraining(SCAN_TEST_TOOLTIP_MANAGER, isDismissedUsingCloseButton),
    name: SCAN_TEST_TOOLTIP_MANAGER,
    priority: 1000,
    shouldShow: () => true,
    },
    [SCAN_TEST_CONFIRMATION]: {
    content: [
    {text: 'productTrainingTooltip.scanTestTooltip.part6', isBold: false},
    {text: 'productTrainingTooltip.scanTestTooltip.part7', isBold: true},
    {text: 'productTrainingTooltip.scanTestTooltip.part8', isBold: false},
    ],
    onHideTooltip: (isDismissedUsingCloseButton = false) => dismissProductTraining(SCAN_TEST_CONFIRMATION, isDismissedUsingCloseButton),
    name: SCAN_TEST_CONFIRMATION,
    priority: 1100,
    shouldShow: () => true,
    },

    What changes do you think we should make in order to solve the problem?

    We should hide all test receipt tooltips if the user is migrated user by adding hasBeenAddedToNudgeMigration check

    shouldShow: ({hasBeenAddedToNudgeMigration}) => !hasBeenAddedToNudgeMigration,
    

    [SCAN_TEST_TOOLTIP]: {
    content: [
    {text: 'productTrainingTooltip.scanTestTooltip.part1', isBold: false},
    {text: 'productTrainingTooltip.scanTestTooltip.part2', isBold: true},
    ],
    onHideTooltip: () => dismissProductTraining(SCAN_TEST_TOOLTIP),
    name: SCAN_TEST_TOOLTIP,
    priority: 900,
    shouldShow: () => true,
    shouldRenderActionButtons: true,
    },
    [SCAN_TEST_TOOLTIP_MANAGER]: {
    content: [
    {text: 'productTrainingTooltip.scanTestTooltip.part3', isBold: false},
    {text: 'productTrainingTooltip.scanTestTooltip.part4', isBold: true},
    {text: 'productTrainingTooltip.scanTestTooltip.part5', isBold: false},
    ],
    onHideTooltip: (isDismissedUsingCloseButton = false) => dismissProductTraining(SCAN_TEST_TOOLTIP_MANAGER, isDismissedUsingCloseButton),
    name: SCAN_TEST_TOOLTIP_MANAGER,
    priority: 1000,
    shouldShow: () => true,
    },
    [SCAN_TEST_CONFIRMATION]: {
    content: [
    {text: 'productTrainingTooltip.scanTestTooltip.part6', isBold: false},
    {text: 'productTrainingTooltip.scanTestTooltip.part7', isBold: true},
    {text: 'productTrainingTooltip.scanTestTooltip.part8', isBold: false},
    ],
    onHideTooltip: (isDismissedUsingCloseButton = false) => dismissProductTraining(SCAN_TEST_CONFIRMATION, isDismissedUsingCloseButton),
    name: SCAN_TEST_CONFIRMATION,
    priority: 1100,
    shouldShow: () => true,
    },

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    Update Migrated User Scenarios case in ProductTrainingContextProvider test to verify that the test receipt tooltip isn't displayed

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  12. 23 remaining items

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 24, 2025
  14. changed the title [-][$250] Remove "Try a test receipt" tooltip for migrated users[/-] [+][Due for payment 2025-07-01] [$250] Remove "Try a test receipt" tooltip for migrated users[/+] on Jun 24, 2025
  15. melvin-bot commented on Jun 24, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Jun 24, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.70-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-01. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Jun 24, 2025

    @melvin-bot

    @suneox @flaviadefaria @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  18. flaviadefaria commented on Jul 2, 2025

    @flaviadefaria
    ContributorAuthor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  19. flaviadefaria commented on Jul 2, 2025

    @flaviadefaria
    ContributorAuthor

    I don't think we need a test rail case for this, so moving directly to payment.

  20. flaviadefaria commented on Jul 2, 2025

    @flaviadefaria
    ContributorAuthor

    Payment Summary

    Contributor: @FitseTLT paid $250 via Upwork = $250 (paid)
    Contributor+: @suneox due $250 via Upwork = $250 (paid)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions