Skip to content

[Due for payment 2025-06-25] [$250] WS setting - Currency can be changed after adding USD bank account which cause an error. #63669

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.60-1
Reproducible in staging?: Yes
Reproducible in production?: Can't add BA on prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+bm705@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Web, mweb, android
App Component: Workspace Settings

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Create a workspace with a currency other than USD.
  3. Go to Workflows and click on "Connect bank account"
  4. Update WS currency to USD
  5. Log in to bank account and finish the flow.
  6. After adding bank account, click on the back navigation.
  7. Then change the default currency to something other than USD

Expected Result:

Once a USD bank account is successfully connected, the workspace currency should be locked or restricted from being changed to prevent conflicts

Actual Result:

After navigating back, the user is able to change the workspace currency from USD to another currency, which causes an error.
As a result, RBR appears in the Overview and Workspaces.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6852351_1749206268571.bandicam_2025-06-06_12-59-58-300.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021930999098654954297
  • Upwork Job ID: 1930999098654954297
  • Last Price Increase: 2025-06-06
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @alexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 6, 2025
  2. melvin-bot commented on Jun 6, 2025

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 6, 2025

    @melvin-bot

    Triggered auto assignment to @JS00001 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jun 6, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 6, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. BlameGPT commented on Jun 6, 2025

    @BlameGPT
    Contributor

    Possible culprit PRs for this issue

  7. 28 remaining items

  8. melvin-bot commented on Jun 18, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-25. 🎊

    For reference, here are some details about the assignees on this issue:

    • @bernhardoj requires payment through NewDot Manual Requests
    • @eh2077 requires payment through NewDot Manual Requests
  9. melvin-bot commented on Jun 18, 2025

    @melvin-bot

    @eh2077 @alexpensify @eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  10. eh2077 commented on Jun 20, 2025

    @eh2077
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: NA. It's not a regression caused by recent PR and I can't find the exact PR that caused this issue.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: AN

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • have global reimbursement beta enabled and a workspace with non-supported currencies (e.g., IDR)

    Test:

    1. Open the workspace Workflows page
    2. Press Connect bank account. You will be prompted to change the currency.
    3. Press the change currency button
    4. Select USD
    5. Go back
    6. Verify the RHP is closed
    7. Press Connect bank account again
    8. Complete the flow
    9. Open the workspace currency page directly by opening the URL (https://staging.new.expensify.com/settings/workspaces/{workspace_id}/overview/currency)

    Do we agree 👍 or 👎

  11. melvin-bot commented on Jun 25, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@alexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1930999098654954297/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. JS00001 commented on Jun 26, 2025

    @JS00001
    Contributor

    @alexpensify Could you handle payment here?

  13. alexpensify commented on Jun 26, 2025

    @alexpensify
    Contributor

    Payment Summary

    Contributor: @bernhardoj due $250 via NewDot-- please submit a request via Chat, thanks!
    Contributor+: @eh2077 due $250 via NewDot- please submit a request via Chat, thanks!

  14. alexpensify commented on Jun 26, 2025

    @alexpensify
    Contributor

    @alexpensify Could you handle payment here?

    Already on my task list for today, done!

  15. bernhardoj commented on Jul 1, 2025

    @bernhardoj
    Contributor

    Requested in ND.

  16. JmillsExpensify commented on Jul 2, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @bernhardoj

  17. JmillsExpensify commented on Jul 14, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @eh2077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions