You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-08-20] [$125] Reports - "you" returns current account in Filters > From page, but no results in From button #63856
Version Number: 9.1.63-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):sjdoijsosnsiojndso@agiuse.com Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to Reports
Click Filters
Click From
Type "you"
Your own email shows up in the result
Close the RHP
Click From filter button
Type "you"
Expected Result:
Your own email will show up in the result when searching for "you" in From filter button
Actual Result:
Your own email does not show up in the result when searching for "you" in From filter button
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6855612_1749563770571.20250610_215150.mp4
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Hmmm. I don't think there's many people how'd use you anyways. I kinda feel like this isn't worth fixing, but yeah, there's definitely inconsistency there.
I think it's worth making them consistent. The fact that (you) is part of the display name makes me think we should make it so that searching for you would return it:
We've also discussed totally removing (you) from the UI at some point, but I can't remember where we last left off there. cc @trjExpensify@JmillsExpensify
This doesnt seem intuitive to me, I feel like we should standardize to not include (you) in searches, rather than the other way around. I think it can be confusing to the user to get results that are not actually what they are looking for, but rather, generated by us, and only shown in this one place
If we do decide to keep the behavior of searching "you", then I can throw up a quick Pr for it
Yeah, interesting one. (you) is the name of the selfDM chat, so it makes sense that the search router for chat switching includes it because that's the name of the chat -- or broadly wherever you're searching for the chat by name.
Outside of that, I don't think (you) should be appended to a displayName wherever it's shown. For example, we don't do that in the members table, reportActions from yourself etc:
So I think we can remove it from the From and To filters.
Yeah this is an interesting one. I don't think we necessarily need to include "you" in the display of the From and To filters, but I will note that in Slack, even though "you" doesn't show anywhere in the search, if I type it in, it shows me as the top result. Same thing if I search for "me" 🤷♂
changed the title [-][$125] Reports - "you" returns current account in Filters > From page, but no results in From button[/-][+][Due for payment 2025-08-20] [$125] Reports - "you" returns current account in Filters > From page, but no results in From button[/+]on Aug 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.93-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@s77rt@jliexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No, I don't think this requires a test
Activity
melvin-bot commentedon Jun 10, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Jun 10, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-06-13 15:50:29 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Your own email does not show up in the result when searching for "you" in From filter button
What is the root cause of that problem?
We are filtering here
App/src/components/Search/FilterDropdowns/UserSelectPopup.tsx
Lines 81 to 84 in 4764b6b
In the function
filterOptions, we are usingfilterPersonalDetailswithsearchTermsApp/src/libs/OptionsListUtils.ts
Lines 2289 to 2291 in 4764b6b
And we don't have
youormeinpersonalDetailSearchTermsApp/src/libs/OptionsListUtils.ts
Lines 2206 to 2215 in 4764b6b
App/src/libs/OptionsListUtils.ts
Lines 2132 to 2134 in 4764b6b
It leads to us not having data when
searchTermsisyouormeWhat changes do you think we should make in order to solve the problem?
We should get
currentUserOptioninfilterAndOrderOptionsand use this instead of usingincludeCurrentUserflagincludeCurrentUserhere and also removeincludeCurrentUserinGetOptionsConfigApp/src/components/Search/FilterDropdowns/UserSelectPopup.tsx
Lines 74 to 77 in 4764b6b
App/src/libs/OptionsListUtils.ts
Lines 223 to 231 in 4764b6b
2. Get
currentUserOptionfromfilterAndOrderOptionsfunction and add this topersonalDetailListApp/src/components/Search/FilterDropdowns/UserSelectPopup.tsx
Line 102 in 4764b6b
shouldAddCurrentUserPostfixtoUserSelectionListItem. Then use it hereApp/src/components/SelectionList/Search/UserSelectionListItem.tsx
Lines 60 to 65 in b5e0cb8
Then pass
shouldAddCurrentUserPostfixasfalseto the lists required. For example,UserSelectPopupfor "from" buttonApp/src/components/Search/FilterDropdowns/UserSelectPopup.tsx
Line 164 in b5e0cb8
And
SearchFiltersParticipantsSelectorfor "From" and "To" FilterApp/src/components/Search/SearchFiltersParticipantsSelector.tsx
Line 201 in b5e0cb8
Screen.Recording.2025-06-13.at.22.49.16.mov
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
jliexpensify commentedon Jun 11, 2025
Going to get @Expensify/design to weigh in, but I don't think this is an actual issue?
IMO, no one calls themselves
you,and searching foryouis weird. This does work if you search your own email, though.I do agree that the search behaviour is a little inconsistent though.
dubielzyk-expensify commentedon Jun 11, 2025
Hmmm. I don't think there's many people how'd use you anyways. I kinda feel like this isn't worth fixing, but yeah, there's definitely inconsistency there.
shawnborton commentedon Jun 11, 2025
cc @JS00001
I think it's worth making them consistent. The fact that
(you)is part of the display name makes me think we should make it so that searching foryouwould return it:shawnborton commentedon Jun 11, 2025
We've also discussed totally removing
(you)from the UI at some point, but I can't remember where we last left off there. cc @trjExpensify @JmillsExpensifyJS00001 commentedon Jun 11, 2025
This doesnt seem intuitive to me, I feel like we should standardize to not include (you) in searches, rather than the other way around. I think it can be confusing to the user to get results that are not actually what they are looking for, but rather, generated by us, and only shown in this one place
If we do decide to keep the behavior of searching "you", then I can throw up a quick Pr for it
trjExpensify commentedon Jun 11, 2025
Yeah, interesting one.
(you)is the name of the selfDM chat, so it makes sense that the search router for chat switching includes it because that's the name of the chat -- or broadly wherever you're searching for the chat by name.Outside of that, I don't think
(you)should be appended to a displayName wherever it's shown. For example, we don't do that in the members table, reportActions from yourself etc:So I think we can remove it from the
FromandTofilters.JS00001 commentedon Jun 11, 2025
Cool, lets get designs opinion on the above, and then I'll open this up externally to update either the 'from' dropdown, or all of them
dannymcclain commentedon Jun 11, 2025
Yeah this is an interesting one. I don't think we necessarily need to include "you" in the display of the
FromandTofilters, but I will note that in Slack, even though "you" doesn't show anywhere in the search, if I type it in, it shows me as the top result. Same thing if I search for "me" 🤷♂trjExpensify commentedon Jun 11, 2025
Maybe that's what we were shooting for to help with faster auto-complete? 🤷 It's definitely a nice-to-have, really.
Slack uses it in the chat switcher too, which we would retain:
80 remaining items
[-][$125] Reports - "you" returns current account in Filters > From page, but no results in From button[/-][+][Due for payment 2025-08-20] [$125] Reports - "you" returns current account in Filters > From page, but no results in From button[/+]melvin-bot commentedon Aug 13, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.93-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-08-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 13, 2025
@s77rt @jliexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
jliexpensify commentedon Aug 15, 2025
Payment Summary
NEW JOB: https://www.upwork.com/jobs/~021956155680088944807
jliexpensify commentedon Aug 15, 2025
@s77rt waiting on checklist
s77rt commentedon Aug 15, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Suggested Search #62851 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No, I don't think this requires a test
s77rt commentedon Aug 15, 2025
Added checklist but this not due payment yet
jliexpensify commentedon Aug 17, 2025
Thanks! Payment summary here
jliexpensify commentedon Aug 20, 2025
Paid and job closed.
@s77rt - payment summary here.
garrettmknight commentedon Aug 26, 2025
$125 approved for @s77rt