Skip to content

[Due for payment 2025-08-13] [$250] Improve navigation behavior when opening expenses from reports #64012

Closed

Description

@davidcardoza

- Slack conversation for reference

Problem

When a user clicks on an expense or the "Review" button from the Reports view, they are taken to the bottom of the expense thread. This forces them to scroll up manually to address violations (e.g., editing the expense category). This disrupts the user workflow and adds unnecessary friction, especially when multiple edits are needed.

Why is this important?

This behavior creates confusion and inefficiency. Users expect to land at the top of the expense thread—where violations and key information are displayed—so they can resolve issues directly. This inconsistency between navigating to expenses vs. chats (Inbox vs. Reports) undermines user expectations. The team is aligned on the UX improvement and sees it as a quality-of-life fix.

Solution

  • Update the navigation logic so that clicking an expense or "Review" from the Reports view loads the top of the expense thread.
Issue OwnerCurrent Issue Owner: @truph01
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021960787284046922546
  • Upwork Job ID: 1960787284046922546
  • Last Price Increase: 2025-08-27

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 11, 2025
  2. melvin-bot commented on Jun 11, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

  3. thelullabyy commented on Jun 12, 2025

    @thelullabyy
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Improve navigation behavior when opening expenses from reports

    What is the root cause of that problem?

    The report action list is always scrolled to bottom when we open the report.

    useEffect(() => {
    if (linkedReportActionID) {
    return;
    }
    InteractionManager.runAfterInteractions(() => {
    setIsFloatingMessageCounterVisible(false);
    reportScrollManager.scrollToBottom();
    });
    // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
    }, []);

    What changes do you think we should make in order to solve the problem?

    We can check if the report is a transaction thread report or one expense report and this report is RHP report, we scroll to top to see the MoneyRequestView

    const isTransactionThreadReport = isMoneyRequestAction(parentReportAction) || !!transactionThreadReport;
    useEffect(() => {
        if (linkedReportActionID) {
            return;
        }
        InteractionManager.runAfterInteractions(() => {
            setIsFloatingMessageCounterVisible(false);
            if (isTransactionThreadReport && isSearchTopmostFullScreenRoute()) {
                reportScrollManager.scrollToIndex(sortedVisibleReportActions.length - 1);
            } else {
                reportScrollManager.scrollToBottom();
            }
        });
        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
    }, []);
    

    useEffect(() => {
    if (linkedReportActionID) {
    return;
    }
    InteractionManager.runAfterInteractions(() => {
    setIsFloatingMessageCounterVisible(false);
    reportScrollManager.scrollToBottom();
    });
    // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
    }, []);

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    NA

    Result

    Screen.Recording.2025-06-12.at.12.14.08.mov

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. danielrvidal commented on Jun 16, 2025

    @danielrvidal
    Contributor

    @fedirjh thoughts on the proposal?

  5. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 17, 2025
  6. melvin-bot commented on Jun 17, 2025

    @melvin-bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  7. 108 remaining items

  8. truph01 commented on Oct 27, 2025

    @truph01
    Contributor

    Kindly bump @jasperhuangg on this one

  9. huult commented on Oct 29, 2025

    @huult
    Contributor

    Just a friendly bump, @jasperhuangg 😄

  10. melvin-bot commented on Nov 3, 2025

    @melvin-bot

    @truph01 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. huult commented on Nov 4, 2025

    @huult
    Contributor

    @jasperhuangg @VictoriaExpensify Could you take a look at this ticket? This issue can no longer be reproduced. Can we proceed with payment and close the ticket?

  12. melvin-bot commented on Nov 5, 2025

    @melvin-bot

    @truph01 Eep! 4 days overdue now. Issues have feelings too...

  13. melvin-bot commented on Nov 7, 2025

    @melvin-bot

    @truph01 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  14. huult commented on Nov 10, 2025

    @huult
    Contributor
  15. VictoriaExpensify commented on Nov 11, 2025

    @VictoriaExpensify
    Contributor

    Agree we can proceed with payments and close the issue. Finalizing now.

  16. huult commented on Nov 11, 2025

    @huult
    Contributor

    @VictoriaExpensify thank you ❤️

  17. VictoriaExpensify commented on Nov 11, 2025

    @VictoriaExpensify
    Contributor

    Offers have been sent!
    @huult please accept your offer here - https://www.upwork.com/nx/wm/offer/109434931
    @truph01 please accept your offer here - https://www.upwork.com/nx/wm/offer/109434990

  18. huult commented on Nov 11, 2025

    @huult
    Contributor
  19. huult commented on Nov 14, 2025

    @huult
    Contributor

    @VictoriaExpensify I accepted your offer link.

  20. VictoriaExpensify commented on Nov 25, 2025

    @VictoriaExpensify
    Contributor

    Payment summary:
    C: @huult paid $250 via UW
    C+: @truph01 paid $250 via UW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions