Skip to content

[HOLD for payment 2022-02-01] $1000 - IOU - Decimal separator not updated when set to Spanish on some screens #6427

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open app and login
  2. Go to profile settings and set language to Español
  3. Request money from any contact in any currency

Expected Result:

All money amounts are localized to Spanish, comma as decimal separator. Eg: C$ 23,85

Actual Result:

Decimal separators are not localized in some screens. They are shown as English, in dots. Eg: C$ 23.85

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.16-1
Reproducible in staging?: Yes
Reproducible in production?: yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:

Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Nov 23, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 23, 2021
  3. MelvinBot commented on Nov 23, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  4. bfitzexpensify commented on Nov 25, 2021

    @bfitzexpensify
    Contributor

    Posted to Upwork - job

  5. MelvinBot commented on Nov 25, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @parasharrajat (Exported)

  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 25, 2021
  7. MelvinBot commented on Nov 25, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @Luke9389 (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  8. 58 remaining items

  9. parasharrajat commented on Jan 11, 2022

    @parasharrajat
    Member

    Is there a reason for your preference aside from referencing Intl.numberFormat @parasharrajat?

    No. It does not matter much. Happy with anything.

  10. songlang1994 commented on Jan 13, 2022

    @songlang1994
    Contributor

    Thank you @Luke9389. I will send a PR within 2 days. Should I apply for the Upwork job now? The job link mentioned in this comment is unavailable.

  11. bfitzexpensify commented on Jan 13, 2022

    @bfitzexpensify
    Contributor

    Hey @songlang1994, please apply here (I updated the link, but it got lost in the hidden comments in this issue). Thanks!

  12. songlang1994 commented on Jan 13, 2022

    @songlang1994
    Contributor

    Aha, thank you @bfitzexpensify. I forgot the hidden comments.

  13. bfitzexpensify commented on Jan 24, 2022

    @bfitzexpensify
    Contributor

    Deployed to staging. @songlang1994, once this is deployed to production, this issue will automatically update, and then we'll pay out the fee once there have been no regressions after 7 days.

  14. songlang1994 commented on Jan 25, 2022

    @songlang1994
    Contributor

    @bfitzexpensify Okay. That sounds good for me. Thank you.

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 25, 2022
  16. botify commented on Jan 25, 2022

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.32-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-02-01. 🎊

  17. changed the title [-]$1000 - IOU - Decimal separator not updated when set to Spanish on some screens[/-] [+][HOLD for payment 2022-02-01] $1000 - IOU - Decimal separator not updated when set to Spanish on some screens[/+] on Jan 25, 2022
  18. bfitzexpensify commented on Feb 1, 2022

    @bfitzexpensify
    Contributor

    Paid out contracts. Thanks @songlang1994!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions