Skip to content

Chat messages are fixed top instead of bottom - Reported by: @PrashantMangukiya  #6436

Closed

Description

@isagoico

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Start a new conversation with a user
  2. Send a message

Expected Result:

Message should be displayed on the bottom of the conversation viewer.

Actual Result:

Message is displayed on top of the conversation viewer.

Workaround:

No need, visual issue.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.16-2

Reproducible in staging?: Yes
Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image

Expensify/Expensify Issue URL:

Issue reported by: @PrashantMangukiya
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1637300247327600

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Nov 23, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. OSBotify commented on Nov 23, 2021

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. isagoico commented on Nov 23, 2021

    @isagoico
    Author

    Non coder hunch here: Maybe this has the same source as #6415 (since both are fixing content to the top 🤔)

  4. parasharrajat commented on Nov 23, 2021

    @parasharrajat
    Member

    Very close @isagoico. Just that it is a side-effect of a PR which caused #6425

  5. alex-mechler commented on Nov 23, 2021

    @alex-mechler
    Contributor

    Yup, @parasharrajat your hunch is right. Reverting that locally fixed the issue. #6268 is the offending PR. cc @thienlnam @azimgd

  6. alex-mechler commented on Nov 23, 2021

    @alex-mechler
    Contributor

    Hmm, not sure why botify closed this, fix is not on staging yet

  7. alex-mechler commented on Nov 23, 2021

    @alex-mechler
    Contributor

    @isagoico the fix was CP'd to staging. Can you have this retested?

  8. isagoico commented on Nov 24, 2021

    @isagoico
    Author

    Retest for this was a pass 🎉

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 24, 2021
  10. MelvinBot commented on Nov 24, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  11. alex-mechler commented on Nov 24, 2021

    @alex-mechler
    Contributor

    @trjExpensify can you get @PrashantMangukiya paid for reporting this issue? Thanks!

  12. trjExpensify commented on Nov 25, 2021

    @trjExpensify
    Contributor

    @PrashantMangukiya Offer sent 👍

  13. PrashantMangukiya commented on Nov 25, 2021

    @PrashantMangukiya
    Contributor

    Offer Accepted.

  14. trjExpensify commented on Nov 25, 2021

    @trjExpensify
    Contributor

    Awesome, paid! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions