You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Chat with task/GBR not visible after switching Priority Mode back to Most Recent #64540
Version Number: v9.1.69-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#64076 Email or phone of affected tester (no customers):qaooxx+199@gmail.com Issue reported by: Applause Internal Team Device used: Windows / Chrome App Component: Other
Action Performed:
Create a fresh account
Start a chat with a random user and send a message
Go back to the LHN and confirm the chat appears at the top
Long press / right-click on the Concierge chat and select "Pin"
Confirm the Concierge chat moves to the top of the list
Start another chat
Create a task in that chat and assign it to yourself
Confirm the chat appears in 1st or 2nd position in the LHN (sorted alphabetically with Concierge)
Go to Account → Preferences
Change the Priority Mode to Focus
Return to the LHN and confirm only the pinned chat and the task/GBR chat are visible
Go back to Account → Preferences
Change the Priority Mode to Most Recent
Return to the LHN
Expected Result:
All three chats (random user, pinned Concierge, and task/GBR chat) are visible in the LHN.
Actual Result:
Only two chats are visible in the LHN — the chat with the task/GBR is missing.
@joekaufmanexpensify making abuild of the revert #64599 could you please test it on that adhoc build if its repro for you same as in staging or if its fixed?
Separately, I couldn't reproduce the other one for the whole day today (see my last comment, asked for a retest).
I'll look into this one first thing tomorrow morning.
I was able to reproduce this on Web (Mac) with @kubabutkiewicz, here are the takeaways:
It's a BE issue to me because FE renders correctly when it has this report available in Onyx. It's not reproducible when we're offline.
Changing priority mode calls the OpenApp command (should it?) which runs setCollection (was merge back in the days but setCollection means better perf) on reports_ that is missing this report ...972 (that should have a GBR).
When we navigate to this missing report (...972) from Reports -> Chats (via a snapshot), OpenReport gets called and merges back this report. From then on, it's visible in LHN just because it's back in our Onyx state.
Thanks for the investigation! I am personally not super passionate about fixing this right now, given the reproduction behavior is so niche. WDYT @mountiny ? If you want to fix it though, totally fine with me too.
I agree, I think we need to take a more holistic approach to the GBR/ RBR stuff to fix these properly, I would like to poke that idea around in quality but dont think its worth the time now to spend on this individual issue.
Activity
melvin-bot commentedon Jun 19, 2025
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.joekaufmanexpensify commentedon Jun 19, 2025
Reproduced on android mWeb.
2025-06-19_11-41-07.mp4
joekaufmanexpensify commentedon Jun 19, 2025
Works fine for me on chrome web though.
joekaufmanexpensify commentedon Jun 19, 2025
cc @adhorodyski @mountiny @brunovjk as seems related to this PR that's on staging
mountiny commentedon Jun 19, 2025
@joekaufmanexpensify making abuild of the revert #64599 could you please test it on that adhoc build if its repro for you same as in staging or if its fixed?
joekaufmanexpensify commentedon Jun 19, 2025
Yep! Will do.
mountiny commentedon Jun 19, 2025
@brunovjk Can you please test this on staging and the revert PR? Was this fixed for you in the PR?
4 remaining items
adhorodyski commentedon Jun 23, 2025
Any way I can help here?
joekaufmanexpensify commentedon Jun 23, 2025
I'm thinking we're going to tackle this and the other bug in a follow up PR. Is that right @mountiny @brunovjk
mountiny commentedon Jun 23, 2025
Ype in the other one, commented there
joekaufmanexpensify commentedon Jun 24, 2025
TY!
joekaufmanexpensify commentedon Jun 26, 2025
@adhorodyski are you planning to include this one in your PR from the other issue?
adhorodyski commentedon Jun 26, 2025
Separately, I couldn't reproduce the other one for the whole day today (see my last comment, asked for a retest).
I'll look into this one first thing tomorrow morning.
adhorodyski commentedon Jun 27, 2025
I was able to reproduce this on Web (Mac) with @kubabutkiewicz, here are the takeaways:
It's a BE issue to me because FE renders correctly when it has this report available in Onyx.
It's not reproducible when we're offline.
OpenAppcommand (should it?) which runssetCollection(wasmergeback in the days but setCollection means better perf) onreports_that is missing this report...972(that should have a GBR)....972) fromReports -> Chats(via a snapshot),OpenReportgets called and merges back this report. From then on, it's visible in LHN just because it's back in our Onyx state.To fix this, we need to return it with OpenApp.
joekaufmanexpensify commentedon Jun 27, 2025
Thanks for the investigation! I am personally not super passionate about fixing this right now, given the reproduction behavior is so niche. WDYT @mountiny ? If you want to fix it though, totally fine with me too.
mountiny commentedon Jun 30, 2025
I agree, I think we need to take a more holistic approach to the GBR/ RBR stuff to fix these properly, I would like to poke that idea around in quality but dont think its worth the time now to spend on this individual issue.