Skip to content

[Due for payment 2025-07-01] Add an ESLint warning that Onyx.connect() is deprecated #64588

Closed
Expensify/eslint-config-expensify
#147

Description

@tgolen

Background

We have identified that Onyx.connect() is an anti-pattern and will be deprecated. The project to refactor and clean up those patterns has not begun yet and is slated to begin in early July.

Problem

Contributors continue to add new references to Onyx.connect() which adds more anti-patterns to our code, which will cause more work later to refactor.

Solution

Create an ESLint custom rule that will throw a WARNING for Onyx.connect() references. The warning message should direct developers on what to use instead.

Activity

  1. self-assigned this
    on Jun 19, 2025
  2. added theissue type on Jun 19, 2025
  3. added
    ReviewingHas a PR in review
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 19, 2025
  4. changed the title [-]Add an ESLint warning that `Onyx.connect()` is deprecated[/-] [+][Due for payment 2025-07-01] Add an ESLint warning that `Onyx.connect()` is deprecated[/+] on Jun 24, 2025
  5. melvin-bot commented on Jun 24, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  6. melvin-bot commented on Jun 24, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.70-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-01. 🎊

  7. tgolen commented on Jun 25, 2025

    @tgolen
    ContributorAuthor

    This can be closed and doesn't need payment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions