Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.69-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #62483
Email or phone of affected tester (no customers): applausetester+fa@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
- Go to https://staging.new.expensify.com/home
- Go to workspace settings - enable tags - upload dependant tags with GL code
- Toggle off these are independent tags
- Tap next
- Tap region
- Long press North
Expected Result:
Long pressing north tag shows 1 selected on top so checkbox for selection must also be shown
Actual Result:
Long pressing north tag shows 1 selected on top but checkbox for selection is not shown
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6864802_1750354554634.Screenrecorder-2025-06-19-22-57-34-881.mp4
Bug6864802_1750354554642!Dependent_with_GL_codes_format.1 (1).csv
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021935764076818272759
- Upwork Job ID: 1935764076818272759
- Last Price Increase: 2025-06-19
- Automatic offers:
- allgandalf | Contributor | 107742397
Activity
melvin-bot commentedon Jun 19, 2025
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 19, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 19, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
[-]Tags - Checkbox for sub tags selection is not shown[/-][+][$250] Tags - Checkbox for sub tags selection is not shown[/+]melvin-bot commentedon Jun 19, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021935764076818272759
melvin-bot commentedon Jun 19, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (
External)daledah commentedon Jun 19, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Long pressing north tag shows 1 selected on top but checkbox for selection is not shown
What is the root cause of that problem?
There should be no selection mode when dependent tags are enabled, because there's no options with these tags. Disable option is only for independent tags. We can check OD behaviour:
And we always allow long press here
App/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx
Line 412 in ff2ae64
What changes do you think we should make in order to solve the problem?
We should disable long press if there's dependent tags
App/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx
Line 412 in ff2ae64
Optional, enforce these options conditions
App/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx
Line 274 in ff2ae64
App/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx
Line 291 in ff2ae64
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
allgandalf commentedon Jun 19, 2025
Please assign this to me @carlosmiceli , this stems from a PR me and @akinwale worked on
melvin-bot commentedon Jun 19, 2025
📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
allgandalf commentedon Jun 25, 2025
Hopeful to get the PR merged this week
allgandalf commentedon Jul 4, 2025
Lets close this issue @carlosmiceli