Skip to content

[$250] Tags - Checkbox for sub tags selection is not shown #64595

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.69-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #62483
Email or phone of affected tester (no customers): applausetester+fa@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Go to workspace settings - enable tags - upload dependant tags with GL code
  3. Toggle off these are independent tags
  4. Tap next
  5. Tap region
  6. Long press North

Expected Result:

Long pressing north tag shows 1 selected on top so checkbox for selection must also be shown

Actual Result:

Long pressing north tag shows 1 selected on top but checkbox for selection is not shown

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6864802_1750354554634.Screenrecorder-2025-06-19-22-57-34-881.mp4

Bug6864802_1750354554642!Dependent_with_GL_codes_format.1 (1).csv

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021935764076818272759
  • Upwork Job ID: 1935764076818272759
  • Last Price Increase: 2025-06-19
  • Automatic offers:
    • allgandalf | Contributor | 107742397
Issue OwnerCurrent Issue Owner: @akinwale

Activity

  1. melvin-bot commented on Jun 19, 2025

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. melvin-bot commented on Jun 19, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on Jun 19, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 19, 2025
  5. changed the title [-]Tags - Checkbox for sub tags selection is not shown[/-] [+][$250] Tags - Checkbox for sub tags selection is not shown[/+] on Jun 19, 2025
  6. melvin-bot commented on Jun 19, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 19, 2025
  8. melvin-bot commented on Jun 19, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

  9. daledah commented on Jun 19, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Long pressing north tag shows 1 selected on top but checkbox for selection is not shown

    What is the root cause of that problem?

    There should be no selection mode when dependent tags are enabled, because there's no options with these tags. Disable option is only for independent tags. We can check OD behaviour:

    Independent tag - have toggle Dependent tag - no toggle
    Image Image

    And we always allow long press here

    turnOnSelectionModeOnLongPress

    What changes do you think we should make in order to solve the problem?

    We should disable long press if there's dependent tags

    turnOnSelectionModeOnLongPress

    turnOnSelectionModeOnLongPress={!hasDependentTags}

    Optional, enforce these options conditions

    if (enabledTagCount > 0) {

    if (enabledTagCount > 0 && !hasDependentTags) {

    if (disabledTagCount > 0) {

    if (disabledTagCount > 0 && !hasDependentTags) {

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  10. allgandalf commented on Jun 19, 2025

    @allgandalf
    Contributor

    Please assign this to me @carlosmiceli , this stems from a PR me and @akinwale worked on

  11. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 19, 2025
  12. melvin-bot commented on Jun 19, 2025

    @melvin-bot

    📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  13. allgandalf commented on Jun 25, 2025

    @allgandalf
    Contributor

    Hopeful to get the PR merged this week

  14. allgandalf commented on Jul 4, 2025

    @allgandalf
    Contributor

    Lets close this issue @carlosmiceli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions