Skip to content

[Due for payment 2025-07-17] [$250] [Suggested Search v1] Create report appears in the Submit empty state for a user with no NewDot compatible workspaces.  #64646

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @davidcardoza
Slack conversation (hyperlinked to channel name): #Quality

Pre-requisite

The account your testing with is only a member of workspaces that aren’t NewDot compatible (don’t have the isPolicyExpenseChatEnabled: true policyNVP)

Action Performed (including steps to get an account into that state):

  1. Create an account on expensify.com via “Sign in” button
  2. [Auto] you’ll be redirected to new.expensify.com
  3. Choose “Something else” (so a workspace isn’t created)
  4. Go to Account > “Switch to Expensify Classic”
  5. Create a Control workspace on OldDot (so it doesn’t have isPolicyExpenseChatEnabled: true set)
  6. Click “Try New Expensify” to toggle back to NewDot
  7. Click + > Create report
  8. Observe the “coming soon” blocking modal.
  9. Go to the Reports page
  10. Click on Reports in the LHN
  11. Observe the empty state doesn’t have the Create report button
  12. Click on Submit in the LHN
  13. Observe the empty state has the Create report button
  14. Click on the Create report button
  15. Observe the empty workspaces select list.

Expected Result:

Don’t show the Create report button in the Submit suggested search empty state, like we don’t the Reports empty state in this scenario whereby the user is only a member of workspaces that aren't NewDot compatible.

Actual Result:

The button shows in Submit empty state, and when clicked, navigates to an empty workspaces list.

Workaround:

None

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Repro:

2025-06-24_02-22-20.mp4

The video for the issue is in OP

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021937325231948407485
  • Upwork Job ID: 1937325231948407485
  • Last Price Increase: 2025-06-24
  • Automatic offers:
    • linhvovan29546 | Contributor | 107792812
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    on Jun 20, 2025
  2. melvin-bot commented on Jun 20, 2025

    @melvin-bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MelvinBot commented on Jun 20, 2025

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  4. kpadmanabhan commented on Jun 20, 2025

    @kpadmanabhan

    @m-natarajan / @davidcardoza : I was trying to reproduce the issue. I can see that workspaces are populated in the right panel as shown in screenshot below.

    Image

    • was there any console error? or any network call failed?
    • or is it any user specific behaviour like user who is not part of any workspace?
  5. trjExpensify commented on Jun 24, 2025

    @trjExpensify
    Contributor

    Taking over the BZ on this one. I was investigating it in this thread (internal). It's a bug with the empty state in the new suggested search added for Submit. (CC: @JS00001 @luacmartins @JmillsExpensify).

    Updated the OP with how to reproduce, @kpadmanabhan.

  6. 31 remaining items

  7. changed the title [-][$250] [Suggested Search v1] `Create report` appears in the `Submit` empty state for a user with no NewDot compatible workspaces. [/-] [+][Due for payment 2025-07-17] [$250] [Suggested Search v1] `Create report` appears in the `Submit` empty state for a user with no NewDot compatible workspaces. [/+] on Jul 10, 2025
  8. melvin-bot commented on Jul 10, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Jul 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-17. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Jul 10, 2025

    @melvin-bot

    @shubham1206agra @trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. trjExpensify commented on Jul 16, 2025

    @trjExpensify
    Contributor

    This was follow-up in the suggested search project, so tests for it are being added centrally. I'm out tomorrow, so taking care of payments now.

    Closing!

  12. moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrateon Jul 16, 2025
  13. shubham1206agra commented on Jul 16, 2025

    @shubham1206agra
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/61170/files#r2210823802

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • The account your testing with is only a member of workspaces that aren’t NewDot compatible (don’t have the isPolicyExpenseChatEnabled: true policyNVP)

    Test:

    1. Open App
    2. Go to the Reports page
    3. Click on Submit in the LHN
    4. Verify the "Create report" button is not present in the empty state UI.

    Do we agree 👍 or 👎

  14. garrettmknight commented on Jul 21, 2025

    @garrettmknight
    Contributor

    $250 approved fro @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions