Skip to content

[Due for payment 2025-07-10] Add useNewTransaction unit tests #64936

Closed

Description

@SzymczakJ

Add useNewTransaction tests, coming from this discussion.

Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 25, 2025
  2. melvin-bot commented on Jun 25, 2025

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. moved this to Second Cohort - MEDIUM or LOW in [#whatsnext] #migrateon Jun 25, 2025
  4. CortneyOfstad commented on Jul 1, 2025

    @CortneyOfstad
    Contributor

    Hey team! I'm unfamiliar with this type of GH. I checked SO but came up short. Is there any documentation or steps that you can point me to for this? Thanks in advance for any help!

  5. SzymczakJ commented on Jul 2, 2025

    @SzymczakJ
    ContributorAuthor

    This is an issue for adding unit tests to one of the functionalities. This is a discussion in which we decided to do this https://swmansion.slack.com/archives/C07NMDKEFMH/p1750281948715659?thread_ts=1749575268.778859&cid=C07NMDKEFMH, I'm not sure if you can open this.

  6. SzymczakJ commented on Jul 2, 2025

    @SzymczakJ
    ContributorAuthor

    I linked a PR, also @ahmedGaber93 was reviewing it

  7. CortneyOfstad commented on Jul 2, 2025

    @CortneyOfstad
    Contributor

    Yeah, unfortunately I cannot open the link. However, if you could share the PR link that would be great for me to keep an eye on as well. Thank you!

    Just a heads up that will be heading OoO this afternoon (July 2 to July 7) for the US holiday. If there is anything that is needed from a BZ perspective, please reach out in Slack — otherwise I will review as soon as I am back. Thanks!

  8. SzymczakJ commented on Jul 3, 2025

    @SzymczakJ
    ContributorAuthor

    PR is already merged [NoQA] Add useNewTransactions tests #64938
    I think there's no need for BZ as this is NoQA, just enjoy your holiday 😄

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 3, 2025
  10. changed the title [-]Add useNewTransaction unit tests[/-] [+][Due for payment 2025-07-10] Add useNewTransaction unit tests[/+] on Jul 3, 2025
  11. melvin-bot commented on Jul 3, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jul 3, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.74-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-10. 🎊

    For reference, here are some details about the assignees on this issue:

    • @SzymczakJ does not require payment (Contractor)
  13. melvin-bot commented on Jul 3, 2025

    @melvin-bot

    @mountiny @CortneyOfstad @SzymczakJ The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. mountiny commented on Jul 5, 2025

    @mountiny
    Contributor

    We can close this one just a follow up to add tests

  15. moved this from Second Cohort - MEDIUM or LOW to Done in [#whatsnext] #migrateon Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions