You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Results returned when searching for a user and default back to suggestions #65144
Version Number: 9.1.72-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@quinthar Slack conversation (hyperlinked to channel name): #Quality
Action Performed:
Navigate to "Reports" > 'Expenses"
Click "From" on the filter options
Input a user name or email in the search for someone field
Expected Result:
The searched user should appear in the results if they exist and are selectable by clicking
Actual Result:
Search result displayed after a loading spinner and resets to default suggestions
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceRecording.1347.mp4
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
filterFormValues has a lot of dependencies and one of them is updated during the search (I think personalDetails, but I'm not sure), in any case, even if the values themselves have not changed, a new reference to the object has been created, accordingly updateFilterForm has been updated, and because of this, the userPickerComponent has been completely updated, which is why the value was reset
The solution to the problem can be to pass the dependency to the updateFilterForm useCallback not of the object, but of its stringify version:
constfilterFormValuesKey=JSON.stringify(filterFormValues);constupdateFilterForm=useCallback((values: Partial<SearchAdvancedFiltersForm>)=>{constupdatedFilterFormValues: Partial<SearchAdvancedFiltersForm>={
...filterFormValues,
...values,};// If the type has changed, reset the status so we dont have an invalid status selectedif(updatedFilterFormValues.type!==filterFormValues.type){updatedFilterFormValues.status=CONST.SEARCH.STATUS.EXPENSE.ALL;}constfilterString=buildQueryStringFromFilterFormValues(updatedFilterFormValues);constsearchQueryJSON=buildSearchQueryJSON(filterString);constqueryString=buildSearchQueryString(searchQueryJSON);close(()=>{Navigation.setParams({q: queryString});});},[filterFormValuesKey],);
Suggested Search: Unapproved accruals #64670: Large refactor to search filters (SearchList, SingleSelectPopup, SearchQueryUtils) used by the ‘From’ user filter, making it likely that user-search results now get overwritten by the default suggestions.
perf: bottom bar switching and search #64995: Modifies UserSelectPopup and SearchFiltersBar logic for search inside Reports tab, so could cause the list to reset right after results load.
If not above, check these
Feat standardize pay button #56838: Refactored Search component and libs/actions/Search.ts which drive user search in filters, so its changes can cause the search results in the Expenses ‘From’ filter to briefly load then revert to default suggestions.
Activity
melvin-bot commentedon Jun 28, 2025
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 28, 2025
Triggered auto assignment to @AndrewGable (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 28, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 28, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Eskalifer1 commentedon Jun 30, 2025
I think this is a regression from #62657
The reason for this is that in this useCallback
App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx
Lines 202 to 215 in 0c28b4e
Passed dependency updateFilterForm
App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx
Lines 86 to 107 in 0c28b4e
Which in turn depends on filterFormValues:
App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx
Lines 82 to 84 in 0c28b4e
filterFormValues has a lot of dependencies and one of them is updated during the search (I think personalDetails, but I'm not sure), in any case, even if the values themselves have not changed, a new reference to the object has been created, accordingly updateFilterForm has been updated, and because of this, the userPickerComponent has been completely updated, which is why the value was reset
The solution to the problem can be to pass the dependency to the updateFilterForm useCallback not of the object, but of its stringify version:
JS00001 commentedon Jun 30, 2025
This is from #64995
BlameGPT commentedon Jun 30, 2025
Possible culprit PRs for this issue
If not above, check these
JS00001 commentedon Jun 30, 2025
Fixed by reverting #64995, which was CPd. No external contributions, so closing