Repository navigation
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.Something to build that is a new item.
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.72-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation (hyperlinked to channel name): #Product
Action Performed:
- Create a room in a workspace you're a member but not an admin of
- Click on the room header to open the room settings RHP.
Expected Result:
You should be able to set a custom avatar on the room
Actual Result:
No option to edit the avatar
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Details
Recording.1355.mp4
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021939810271827347955
- Upwork Job ID: 1939810271827347955
- Last Price Increase: 2025-10-31
- Automatic offers:
- samranahm | Contributor | 108127378
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @rushatgabhaneMetadata
Metadata
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.Something to build that is a new item.
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Jun 30, 2025
Triggered auto assignment to @clarajones-expensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 30, 2025
Current assignee @clarajones-expensify is eligible for the NewFeature assigner, not assigning anyone new.
samranahm commentedon Jun 30, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Can't edit room avatar
What is the root cause of that problem?
We render
RoomHeaderAvatarshere, but currently there is no logic to edit the room avatarApp/src/pages/ReportDetailsPage.tsx
Lines 599 to 605 in 8c250f2
What changes do you think we should make in order to solve the problem?
We should implement the same approach we did in
AvatarWithImagePickerand update ourRoomHeaderAvatarscomponent accordinglyApp/src/components/AvatarWithImagePicker.tsx
Lines 375 to 414 in 8c250f2
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Can't edit room avatar[/-][+][$250] Can't edit room avatar[/+]melvin-bot commentedon Jun 30, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021939810271827347955
174 remaining items
melvin-bot commentedon Nov 4, 2025
@eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
clarajones-expensify commentedon Nov 4, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
clarajones-expensify commentedon Nov 4, 2025
Hi @eh2077 ! Would you fill out the above checklist when you can? Thank you!
clarajones-expensify commentedon Nov 13, 2025
Payment Summary
Contributor: @samranahm paid $500 via Upwork
Contributor+: @eh2077 due $500 via NewDot
[-][Due for payment 2025-11-11] [$500] Can't edit room avatar[/-][+][`hold for BZ checklist`][Due for payment 2025-11-11] [$500] Can't edit room avatar[/+]eh2077 commentedon Nov 13, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: NA, this is a new feature.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
[Admin]
[Workspace member]
[Non Workspace member]
[An Auditor]
Do we agree 👍 or 👎
eh2077 commentedon Nov 13, 2025
@clarajones-expensify Checklist done, thank you!
[-][`hold for BZ checklist`][Due for payment 2025-11-11] [$500] Can't edit room avatar[/-][+][Due for payment 2025-11-11] [$500] Can't edit room avatar[/+]garrettmknight commentedon Nov 21, 2025
$500 approved for @eh2077