Skip to content

[Due for payment 2025-11-11] [$500] Can't edit room avatar #65210

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.72-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation (hyperlinked to channel name): #Product

Action Performed:

  1. Create a room in a workspace you're a member but not an admin of
  2. Click on the room header to open the room settings RHP.

Expected Result:

You should be able to set a custom avatar on the room

Actual Result:

No option to edit the avatar

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Details
Recording.1355.mp4
Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021939810271827347955
  • Upwork Job ID: 1939810271827347955
  • Last Price Increase: 2025-10-31
  • Automatic offers:
    • samranahm | Contributor | 108127378
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @rushatgabhane

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 30, 2025
  2. melvin-bot commented on Jun 30, 2025

    @melvin-bot

    Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 30, 2025

    @melvin-bot

    Current assignee @clarajones-expensify is eligible for the NewFeature assigner, not assigning anyone new.

  4. samranahm commented on Jun 30, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Can't edit room avatar

    What is the root cause of that problem?

    • New feature

    We render RoomHeaderAvatars here, but currently there is no logic to edit the room avatar

    <View style={styles.mb3}>
    <RoomHeaderAvatars
    icons={icons}
    reportID={report?.reportID}
    />
    </View>
    );

    What changes do you think we should make in order to solve the problem?

    We should implement the same approach we did in AvatarWithImagePicker and update our RoomHeaderAvatars component accordingly

    <Tooltip
    shouldRender={!disabled}
    text={translate('avatarWithImagePicker.editImage')}
    >
    <PressableWithoutFeedback
    onPress={() => onPressAvatar(openPicker)}
    accessibilityRole={CONST.ROLE.BUTTON}
    accessibilityLabel={translate('avatarWithImagePicker.editImage')}
    disabled={isAvatarCropModalOpen || (disabled && !enablePreview)}
    disabledStyle={disabledStyle}
    style={[styles.pRelative, type === CONST.ICON_TYPE_AVATAR && styles.alignSelfCenter, avatarStyle]}
    ref={anchorRef}
    >
    <OfflineWithFeedback pendingAction={pendingAction}>
    {source ? (
    <Avatar
    containerStyles={avatarStyle}
    imageStyles={[styles.alignSelfCenter, avatarStyle]}
    source={source}
    avatarID={avatarID}
    fallbackIcon={fallbackIcon}
    size={size}
    type={type}
    />
    ) : (
    <DefaultAvatar />
    )}
    </OfflineWithFeedback>
    {!disabled && (
    <View style={StyleSheet.flatten([styles.smallEditIcon, styles.smallAvatarEditIcon, editIconStyle])}>
    <Icon
    src={editIcon}
    width={variables.iconSizeSmall}
    height={variables.iconSizeSmall}
    fill={theme.icon}
    />
    </View>
    )}
    </PressableWithoutFeedback>
    </Tooltip>

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. changed the title [-]Can't edit room avatar[/-] [+][$250] Can't edit room avatar[/+] on Jun 30, 2025
  6. melvin-bot commented on Jun 30, 2025

    @melvin-bot
  7. 174 remaining items

  8. melvin-bot commented on Nov 4, 2025

    @melvin-bot

    @eh2077 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  9. clarajones-expensify commented on Nov 4, 2025

    @clarajones-expensify
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  10. clarajones-expensify commented on Nov 4, 2025

    @clarajones-expensify
    Contributor

    Hi @eh2077 ! Would you fill out the above checklist when you can? Thank you!

  11. clarajones-expensify commented on Nov 13, 2025

    @clarajones-expensify
    Contributor

    Payment Summary

    Contributor: @samranahm paid $500 via Upwork
    Contributor+: @eh2077 due $500 via NewDot

  12. changed the title [-][Due for payment 2025-11-11] [$500] Can't edit room avatar[/-] [+][`hold for BZ checklist`][Due for payment 2025-11-11] [$500] Can't edit room avatar[/+] on Nov 13, 2025
  13. eh2077 commented on Nov 13, 2025

    @eh2077
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: NA, this is a new feature.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Create workspace and invite invite some member on workspace
    • Create workspace room

    Test:

    [Admin]

    1. Open workspace room
    2. Click header to open report detail page
    3. Verify you can edit room avatar
    4. Edit room avatar
    5. Verify system message appear changed the room avatar
    6. Open report detail page and remove the room avatar
    7. Verify room avatar is workspace avatar and system message is removed the room avatar
    8. Verify LHN alternate text is You: removed the room avatar

    [Workspace member]

    1. Open workspace room that admin or any other user created
    2. Click header to open report detail page
    3. Verify you can't edit room avatar until you're a participant on that room
    4. Send a message to room chat
    5. Open report detail page upload and remove the avatar
    6. Verify log message appear and it's correct for all other room members

    [Non Workspace member]

    1. Open a public room where you're not a member on workspace
    2. Participate with chat in room
    3. Open report detail page and verify you can't edit room avatar

    [An Auditor]

    1. Admin invite a user as auditor
    2. Auditor open a workspace room
    3. Participate on room
    4. Open workspace report detail page and verify you can't edit room avatar

    Do we agree 👍 or 👎

  14. eh2077 commented on Nov 13, 2025

    @eh2077
    Contributor

    @clarajones-expensify Checklist done, thank you!

  15. changed the title [-][`hold for BZ checklist`][Due for payment 2025-11-11] [$500] Can't edit room avatar[/-] [+][Due for payment 2025-11-11] [$500] Can't edit room avatar[/+] on Nov 13, 2025
  16. garrettmknight commented on Nov 21, 2025

    @garrettmknight
    Contributor

    $500 approved for @eh2077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions