Skip to content

[Due for payment 2025-07-22] [$250] Replace "Onboarding help" dropdown button in #admins #65325

Closed

Description

@dylanexpensify

Coming from this thread and this thread, currently, we have a dropdown button in #admins that only shows one option for users, where those who are 1-10 size, "Register for webinar", and those who are 11-50 size, "Schedule call". This feels like an improper use of a dropdown given there's only one option, so let's replace this button with one that just says "Register for webinar" or "Schedule call" depending on the user size.

Current:
Image

Recommended (1-10 size):
Image

Recommended (11-50):
Image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021940353966599241915
  • Upwork Job ID: 1940353966599241915
  • Last Price Increase: 2025-07-02
  • Automatic offers:
    • linhvovan29546 | Contributor | 107890663
Issue OwnerCurrent Issue Owner: @dylanexpensify

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 2, 2025
  2. changed the title [-]Replace "Onboarding help" dropdown button in #admins[/-] [+][$250] Replace "Onboarding help" dropdown button in #admins[/+] on Jul 2, 2025
  3. melvin-bot commented on Jul 2, 2025

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 2, 2025
  5. melvin-bot commented on Jul 2, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

  6. melvin-bot commented on Jul 2, 2025

    @melvin-bot

    Current assignee @dylanexpensify is eligible for the Bug assigner, not assigning anyone new.

  7. MobileMage commented on Jul 2, 2025

    @MobileMage
    Contributor

    @dylanexpensify I think the images are broken

  8. ryntgh commented on Jul 2, 2025

    @ryntgh
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Replace "Onboarding help" dropdown button in #admins

    What is the root cause of that problem?

    Change Request

    What changes do you think we should make in order to solve the problem?

    We should modify the OnboardingHelpDropdownButton component to render a regular Button when there's only one option

        if (options.length === 1) {
            const singleOption = options[0];
            const isWebinarOption = singleOption.value === CONST.ONBOARDING_HELP.REGISTER_FOR_WEBINAR;
    
            return (
                <Button
                    onPress={singleOption.onSelected}
                    pressOnEnter
                    medium
                    text={singleOption.text}
                    icon={isWebinarOption ? null : singleOption.icon}
                    iconRight={isWebinarOption ? singleOption.icon : undefined}
                    shouldShowRightIcon={isWebinarOption}
                    style={shouldUseNarrowLayout && styles.earlyDiscountButton}
                />
            );
        }
    
        return (
            <ButtonWithDropdownMenu
                onPress={noop}
                shouldAlwaysShowDropdownMenu
                pressOnEnter
                success={!!hasActiveScheduledCall}
                buttonSize={CONST.DROPDOWN_BUTTON_SIZE.MEDIUM}
                options={options}
                isSplitButton={false}
                customText={hasActiveScheduledCall ? translate('scheduledCall.callScheduled') : translate('getAssistancePage.onboardingHelp')}
                wrapperStyle={shouldUseNarrowLayout && styles.earlyDiscountButton}
            />
        );

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    N/A

  9. dylanexpensify commented on Jul 2, 2025

    @dylanexpensify
    ContributorAuthor

    They look right to me @MobileMage? Mind showing me what you see? Image

  10. dylanexpensify commented on Jul 2, 2025

    @dylanexpensify
    ContributorAuthor

    @rushatgabhane can we get these proposals viewed asap?

  11. MobileMage commented on Jul 2, 2025

    @MobileMage
    Contributor

    @dylanexpensify they look like this to me

    Image

    And return "Page not found when clicked"

    Image
  12. 38 remaining items

  13. changed the title [-][$250] Replace "Onboarding help" dropdown button in #admins[/-] [+][Due for payment 2025-07-22] [$250] Replace "Onboarding help" dropdown button in #admins[/+] on Jul 15, 2025
  14. melvin-bot commented on Jul 15, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jul 15, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.80-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-22. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Jul 15, 2025

    @melvin-bot

    @rushatgabhane @dylanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. rushatgabhane commented on Jul 21, 2025

    @rushatgabhane
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N.A. New feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not critical

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    1. Signup with new account and choose Manage my team expenses > (select 1-10 cohorts)
    2. Select "Quick book online" > Select On
    3. Open Admin or Concierge, then verify that the "Register for webinar" is displayed in header as a single button

    admins

    1. Go to an admins room
    2. Verify that the "Schedule call" button is displayed as a single button.

    Do we agree 👍 or 👎

  18. dylanexpensify commented on Jul 22, 2025

    @dylanexpensify
    ContributorAuthor

    Payment summary:

    Contributor: @linhvovan29546 $250 via Upwork
    Contributor+: @rushatgabhane $250 via NewDot

    Please apply/request!

  19. dylanexpensify commented on Jul 22, 2025

    @dylanexpensify
    ContributorAuthor

    done!

  20. garrettmknight commented on Aug 1, 2025

    @garrettmknight
    Contributor

    $250 approved for @rushatgabhane

  21. JmillsExpensify commented on Aug 20, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions