You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-07-22] [$250] Replace "Onboarding help" dropdown button in #admins #65325
Coming from this thread and this thread, currently, we have a dropdown button in #admins that only shows one option for users, where those who are 1-10 size, "Register for webinar", and those who are 11-50 size, "Schedule call". This feels like an improper use of a dropdown given there's only one option, so let's replace this button with one that just says "Register for webinar" or "Schedule call" depending on the user size.
changed the title [-]Replace "Onboarding help" dropdown button in #admins[/-][+][$250] Replace "Onboarding help" dropdown button in #admins[/+]on Jul 2, 2025
changed the title [-][$250] Replace "Onboarding help" dropdown button in #admins[/-][+][Due for payment 2025-07-22] [$250] Replace "Onboarding help" dropdown button in #admins[/+]on Jul 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.80-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@rushatgabhane@dylanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N.A. New feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Signup with new account and choose Manage my team expenses > (select 1-10 cohorts)
Select "Quick book online" > Select On
Open Admin or Concierge, then verify that the "Register for webinar" is displayed in header as a single button
admins
Go to an admins room
Verify that the "Schedule call" button is displayed as a single button.
Activity
[-]Replace "Onboarding help" dropdown button in #admins[/-][+][$250] Replace "Onboarding help" dropdown button in #admins[/+]melvin-bot commentedon Jul 2, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021940353966599241915
melvin-bot commentedon Jul 2, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (
External)melvin-bot commentedon Jul 2, 2025
Current assignee @dylanexpensify is eligible for the Bug assigner, not assigning anyone new.
MobileMage commentedon Jul 2, 2025
@dylanexpensify I think the images are broken
ryntgh commentedon Jul 2, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Replace "Onboarding help" dropdown button in #admins
What is the root cause of that problem?
Change Request
What changes do you think we should make in order to solve the problem?
We should modify the
OnboardingHelpDropdownButtoncomponent to render a regularButtonwhen there's only one optionWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
N/A
dylanexpensify commentedon Jul 2, 2025
They look right to me @MobileMage? Mind showing me what you see?
dylanexpensify commentedon Jul 2, 2025
@rushatgabhane can we get these proposals viewed asap?
MobileMage commentedon Jul 2, 2025
@dylanexpensify they look like this to me
And return "Page not found when clicked"
38 remaining items
[-][$250] Replace "Onboarding help" dropdown button in #admins[/-][+][Due for payment 2025-07-22] [$250] Replace "Onboarding help" dropdown button in #admins[/+]melvin-bot commentedon Jul 15, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.80-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-07-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 15, 2025
@rushatgabhane @dylanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
rushatgabhane commentedon Jul 21, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N.A. New feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
admins
Do we agree 👍 or 👎
dylanexpensify commentedon Jul 22, 2025
Payment summary:
Contributor: @linhvovan29546 $250 via Upwork
Contributor+: @rushatgabhane $250 via NewDot
Please apply/request!
dylanexpensify commentedon Jul 22, 2025
done!
garrettmknight commentedon Aug 1, 2025
$250 approved for @rushatgabhane
JmillsExpensify commentedon Aug 20, 2025
$250 approved for @rushatgabhane