Skip to content

[Due for payment 2025-07-23] [$250] The "More" button in the header disappears after selecting IOU on a medium-sized screen width #65419

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.74-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dmkt9
Slack conversation (hyperlinked to channel name): #Open Source

Action Performed:

  1. Adjust the window width to a medium size (e.g., half of 1920p)
  2. Log in with Expensifail account
  3. Start chat with any user
  4. Send 2 IOUs
  5. Open the report
  6. Select any IOU.

Expected Result:

The "More" button on the header should change to a "Selected" button.

Actual Result:

The "More" button on the header disappeared.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
447547528-84292e2c-1bab-4c1c-afee-5914d75024c9.mp4
Recording.1373.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021940993338516339796
  • Upwork Job ID: 1940993338516339796
  • Last Price Increase: 2025-07-04
  • Automatic offers:
    • FitseTLT | Contributor | 107968867
Issue OwnerCurrent Issue Owner: @FitseTLT

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 3, 2025
  2. melvin-bot commented on Jul 3, 2025

    @melvin-bot

    Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. m-natarajan commented on Jul 3, 2025

    @m-natarajan
    Author

    Proposal by @dmkt9

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The "More" button on the header disappeared.

    What is the root cause of that problem?

    1. On medium-sized screens, the button shown depends on isMoreContentShown:
      {isMoreContentShown && (
      <View style={[styles.dFlex, styles.flexColumn, shouldAddGapToContents && styles.gap3, styles.pb3, styles.ph5]}>
      {shouldShowSelectedTransactionsButton && shouldDisplayNarrowVersion && (
      <View style={[styles.dFlex, styles.w100, styles.pb3]}>
    2. However, isMoreContentShown does not include a check for shouldShowSelectedTransactionsButton && shouldDisplayNarrowVersion, so it always returns false:
      const isMoreContentShown = shouldShowNextStep || !!statusBarProps;

    What changes do you think we should make in order to solve the problem?

    Add a new condition check to isMoreContentShown:

    const isMoreContentShown = shouldShowNextStep || !!statusBarProps;

    js
    const isMoreContentShown = shouldShowNextStep || !!statusBarProps || (shouldShowSelectedTransactionsButton && shouldDisplayNarrowVersion);

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    NA
    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 4, 2025
  5. changed the title [-]The "More" button in the header disappears after selecting IOU on a medium-sized screen width[/-] [+][$250] The "More" button in the header disappears after selecting IOU on a medium-sized screen width[/+] on Jul 4, 2025
  6. melvin-bot commented on Jul 4, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 4, 2025
  8. melvin-bot commented on Jul 4, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

  9. melvin-bot commented on Jul 4, 2025

    @melvin-bot

    📣 @moutazmahmoud! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  10. moutazmahmoud commented on Jul 4, 2025

    @moutazmahmoud

    Contributor details
    Your Expensify account email: moutaz.prof.egy@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~0170a4c9bdb091e3a7

  11. melvin-bot commented on Jul 4, 2025

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  12. 11 remaining items

  13. FitseTLT commented on Jul 25, 2025

    @FitseTLT
    Contributor

    @lydiabarclay Automation failed Payment overdue as per #65883 (comment) Thx

  14. lydiabarclay commented on Jul 25, 2025

    @lydiabarclay
    Contributor

    Thank you for flagging @FitseTLT

  15. changed the title [-][$250] The "More" button in the header disappears after selecting IOU on a medium-sized screen width[/-] [+][Due for payment 2025-07-23] [$250] The "More" button in the header disappears after selecting IOU on a medium-sized screen width[/+] on Jul 25, 2025
  16. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Jul 25, 2025
  17. lydiabarclay commented on Jul 25, 2025

    @lydiabarclay
    Contributor

    @shubham1206agra can you please fill out the BZ checklist?

  18. lydiabarclay commented on Jul 25, 2025

    @lydiabarclay
    Contributor

    Payment Summary

    Contributor: @FitseTLT paid $250 via Upwork
    Contributor+: @shubham1206agra due $250 via NewDot

    ✅ Regression test filed

  19. shubham1206agra commented on Jul 26, 2025

    @shubham1206agra
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/58084/files#r2232535438

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/530292

    Regression Test Proposal

    Test:

    1. Adjust the window width to a medium size (e.g., half of 1920p)
    2. Start chat with any user
    3. Send 2 IOUs
    4. Open the report
    5. Select any IOU.
    6. Verify that the "More" button on the header should change to a "Selected" button.

    Do we agree 👍 or 👎

  20. lydiabarclay commented on Jul 28, 2025

    @lydiabarclay
    Contributor

    Payment summary here, closing

  21. trjExpensify commented on Sep 1, 2025

    @trjExpensify
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions