Skip to content

[HOLD for payment 2022-01-25] Create Expensify branded generic error page #6552

Closed

Description

@roryabraham

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Coming from #6478 – following a good suggestion from @zoontek.

Action Performed:

No specific action – just any action that causes an uncaught JS exception caught by our ErrorBoundary. Of course, we never want to land here, because it's a sign that our app isn't working as it's supposed to. But over the lifetime of this app it's a near-inevitability that we'll introduce a few bugs that get caught by our error boundary. Right now, we just display a blank white screen.

Expected Result:

Instead of rendering a blank white screen, we should display an Expensify-branded generic error screen.

Mockup

Copy

Title

Uh-oh, something went wrong!

Body (iOS/Android)

Please try closing and reopening the app or switching to web.

If the problem persists, reach out to concierge@expensify.com.

Body (web/mWeb/desktop)

If the problem persists, reach out to concierge@expensify.com.

Button text

Should say Reload, not Refresh

Actual Result:

We show a blank white screen.

Workaround:

n/a

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @zoontek here
Slack conversation:

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Nov 30, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @megankelso (Design), see these Stack Overflow questions for more details.

  2. megankelso commented on Dec 3, 2021

    @megankelso
  3. rosegrech commented on Dec 3, 2021

    @rosegrech
  4. mallenexpensify commented on Dec 4, 2021

    @mallenexpensify
    Contributor

    @roryabraham and whomever might be assigned as the CM, I added @zoontek as "Reported by:" in the OP because I think they should be compensated $250 for reporting this here, once this issue has been fixed internally or externally

  5. megankelso commented on Dec 6, 2021

    @megankelso
  6. rosegrech commented on Dec 6, 2021

    @rosegrech
  7. roryabraham commented on Dec 6, 2021

    @roryabraham
    Author
  8. roryabraham commented on Dec 6, 2021

    @roryabraham
    ContributorAuthor

    This is similar to a 404, but not exactly the same. 404 means the user tried to go to a page that doesn't exist (and that concept doesn't really exist on a mobile app). This is more of a 500 error page which means the user didn't do anything wrong, and the error happened on our side. Basically, this page would be shown when we have a bug in the application that would normally crash the app, but instead we'll catch that error and show them this page.

  9. megankelso commented on Dec 6, 2021

    @megankelso
  10. MelvinBot commented on Dec 6, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @gabrielessner (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

  11. 82 remaining items

  12. parasharrajat commented on Jan 14, 2022

    @parasharrajat
    Member

    Also, a small note to add to Rory's comment (in case it helps in the decision)
    Refresh logic was curated based on combined efforts from multiple persons after Manan asked for help #6856 (comment) (point 4) till #6856 (comment).

  13. mananjadhav commented on Jan 14, 2022

    @mananjadhav
    Collaborator

    there was no real change in scope

    @roryabraham, and I'd like to take back the request as I've been also assigned #7037 which is a relatively small PR, so I feel that the budget increase wouldn't be required and the effort will be adjusted there.

  14. roryabraham commented on Jan 14, 2022

    @roryabraham
    ContributorAuthor

    Okay, glad that easier issue makes up for it.

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 18, 2022
  16. botify commented on Jan 18, 2022

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.30-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-01-25. 🎊

  17. changed the title [-]Create Expensify branded generic error page[/-] [+][HOLD for payment 2022-01-25] Create Expensify branded generic error page[/+] on Jan 18, 2022
  18. Christinadobrzyn commented on Jan 27, 2022

    @Christinadobrzyn
    Contributor

    No regressions on this PR - paid @mananjadhav in Upwork - closing job in Upwork and this issue.

  19. parasharrajat commented on Jan 27, 2022

    @parasharrajat
    Member

    @Christinadobrzyn Where can I apply for C+, job is closed?

  20. Christinadobrzyn commented on Jan 27, 2022

    @Christinadobrzyn
    Contributor

    Ah so sorry @parasharrajat! Let me reopen the job and hire you for it!

  21. Christinadobrzyn commented on Jan 27, 2022

    @Christinadobrzyn
    Contributor

    Alright! @parasharrajat I paid you for the C+ in Upwork (our documentation says to pay C+ the same amount as the hired contractor which is $250 for this job). This is my first time paying for C+ so let me know if that's not correct or if I missed something. Thanks!

  22. parasharrajat commented on Jan 27, 2022

    @parasharrajat
    Member

    That's correct. Thanks, @Christinadobrzyn.

  23. nyomanjyotisa commented on Nov 18, 2026

    @nyomanjyotisa
    Member

    The generic error page added in #6856 styled its title as a heading without exposing a heading role. Tracked in #107208 and fixed in #105224.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions