You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-08-01] [$250] Expense - Hold expense header displays "all expenses were put on hold" #65725
Version Number: V9.1.78-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/6456836 Email or phone of affected tester (no customers): Slottwo1 csm@gmail.com Issue reported by: Applause Internal Team Device used: Redminote 10s android 13 App Component: Money Requests
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Expense - Hold expense header displays "all expenses were put on hold"[/-][+][$250] Expense - Hold expense header displays "all expenses were put on hold"[/+]on Jul 10, 2025
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
@huult , we already have one proposal #65725 (comment) above suggesting that we should check whether transactions.length > 1, and if so, display expensesOnHold; otherwise, show expenseOnHold. From your proposal, it seems like you're suggesting something similar - just wanted to confirm what exactly you're proposing that's different from the above?
@jayeshmangwani I based the logic of the function hasOnlyHeldExpenses to check single report transactions by length = 1, then return the exact transaction.
just wanted to confirm what exactly you're proposing that's different from the above?
@huult , thanks for your proposal and explanation. I think this issue is fairly straightforward, and since both proposed solutions are quite similar, we can go ahead with the first one in this case.
changed the title [-][$250] Expense - Hold expense header displays "all expenses were put on hold"[/-][+][Due for payment 2025-08-01] [$250] Expense - Hold expense header displays "all expenses were put on hold"[/+]on Jul 25, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.85-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jayeshmangwani@abekkala The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Not sure we need a dedicated regression test for this, but if we decide to add one, I think the steps below should cover it. Here's what I'm suggesting:
Regression Test Proposal
Open the app
Create a workspace and enable approvals
Navigate to a workspace chat
Create 2 scan expenses and wait for the smartscan
Create a manual expense
The report should contain 2 scanned expenses and 1 manual
Submit the report with the 3 expenses
Navigate to one of the scanned expenses
Hold the scanned expense
Click on the approve button
Verify the approve modal is displayed so the user can select with amount to approve (total or only unheld expenses)
Click on the option to approve only the unheld expenses
Verify the report is approved with the 2 expenses that were unheld
Verify a new report is created with the held scan expens
Open the expense
Verify hold expense header display "this expense was put on hold".
Activity
melvin-bot commentedon Jul 9, 2025
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.thelullabyy commentedon Jul 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Hold expense header displays "all expenses were put on hold" instead "this expense was put on hold".
What is the root cause of that problem?
In one expense report view, we always display
expensesOnHoldtranslationApp/src/components/MoneyReportHeader.tsx
Lines 372 to 374 in 861d3e6
What changes do you think we should make in order to solve the problem?
We should display
expenseOnHolddescription if we only have one expenseApp/src/components/MoneyReportHeader.tsx
Lines 372 to 374 in 861d3e6
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Expense - Hold expense header displays "all expenses were put on hold"[/-][+][$250] Expense - Hold expense header displays "all expenses were put on hold"[/+]melvin-bot commentedon Jul 10, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021943391641851063523
melvin-bot commentedon Jul 10, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)huult commentedon Jul 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Hold expense header displays "all expenses were put on hold"
What is the root cause of that problem?
We always show
expensesOnHoldifhasOnlyHeldExpensesistrue.App/src/components/MoneyReportHeader.tsx
Lines 384 to 386 in d53e7ea
And the case where we have only one report transaction is not handled yet
App/src/libs/ReportUtils.ts
Line 9394 in ca67828
What changes do you think we should make in order to solve the problem?
To resolve this issue, we need to add a new case for when there is only one report transaction. The implementation should look like this:
App/src/libs/ReportUtils.ts
Line 9396 in ca67828
add
function hasOnlyHeldExpense(iouReportID?: string, allReportTransactions?: SearchTransaction[]): boolean { const transactionsByIouReportID = getReportTransactions(iouReportID); const reportTransactions = allReportTransactions ?? transactionsByIouReportID; return reportTransactions.length === 1 && !reportTransactions.some((transaction) => !isOnHoldTransactionUtils(transaction)); }2 Check is hasOnlyHeldExpense then return
expenseOnHoldApp/src/components/MoneyReportHeader.tsx
Line 383 in d53e7ea
add
const hasOnlyHeldExpense = hasOnlyHeldExpenseReportUtils(moneyRequestReport?.reportID); if (hasOnlyHeldExpense) { return {icon: getStatusIcon(Expensicons.Stopwatch), description: translate('iou.expenseOnHold')}; }What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
jayeshmangwani commentedon Jul 12, 2025
@huult , we already have one proposal #65725 (comment) above suggesting that we should check whether
transactions.length > 1, and if so, displayexpensesOnHold; otherwise, showexpenseOnHold. From your proposal, it seems like you're suggesting something similar - just wanted to confirm what exactly you're proposing that's different from the above?huult commentedon Jul 14, 2025
@jayeshmangwani I based the logic of the function
hasOnlyHeldExpensesto check single report transactions by length = 1, then return the exact transaction.It looks like this is the same thing.
jayeshmangwani commentedon Jul 15, 2025
@huult , thanks for your proposal and explanation. I think this issue is fairly straightforward, and since both proposed solutions are quite similar, we can go ahead with the first one in this case.
14 remaining items
[-][$250] Expense - Hold expense header displays "all expenses were put on hold"[/-][+][Due for payment 2025-08-01] [$250] Expense - Hold expense header displays "all expenses were put on hold"[/+]melvin-bot commentedon Jul 25, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 25, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.85-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-08-01. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 25, 2025
@jayeshmangwani @abekkala The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
abekkala commentedon Jul 25, 2025
PAYMENT SUMMARY FOR AUG 01
please complete checklist
abekkala commentedon Aug 1, 2025
@thelullabyy payment sent and contract ended - thank you! 🎉
feature: hold transaction in one transaction view
jayeshmangwani commentedon Aug 1, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Feature: Hold expense in one transaction view v2 #43618
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Not sure we need a dedicated regression test for this, but if we decide to add one, I think the steps below should cover it. Here's what I'm suggesting:
Regression Test Proposal
Do we agree 👍 or 👎
abekkala commentedon Aug 1, 2025
PAYMENT SUMMARY FOR AUG 01