You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-08-01] [$250] Stop showing RTER violation on the reports page for paid transactions #65761
Problem
Currently we're showing the RTER violation on paid transactions on the report page, as you can see in the screenshot below
Note that the Scanning... in the screenshot is a bug, and what I'm highlighting is
We're on the report page
The red circle and accompanying red text for the violation
The fact that these transactions show as paid
Solution
After discussing with product (@JmillsExpensify) we landed on showing violations on the report page, even for paid transactions, but with the exception of the RTER violation
Let's update the code that displays violations on the reports page to omit the RTER violation
Please re-state the problem that we are trying to solve in this issue.
Stop showing RTER violation on the reports page for paid transactions
What is the root cause of that problem?
New requirement
What changes do you think we should make in order to solve the problem?
Add a new parameter to shouldShowViolation, name it shouldShowRterForSettled and default it to true. Then update the function to only filter out the rter violation if shouldShowRterForSettled is false.
Then we need to add a new parameter to useTransactionViolations, name it shouldShowRterForSettled, default it to true and pass it as the last param of shouldShowViolation.
Optional: Instead of filtering the transaction in shouldShowViolation, we can directly filter that when running filter method in useTransactionViolations hook.
What changes do you think we should make in order to solve the problem?
We already have a case for RTER violation in shouldShowViolation function, we only need to add a condition to not show this violation if the report is settled
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can write the unit test for shouldShowViolation and verify that the RTER violation return false if the report is paid.
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.85-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Pujan92@sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Hi @Krishna2323, it looks like you became eligible for NewDot payments on July 22, but since you were assigned to this issue on July 16, before eligibility kicked in, we’ll still need to process payment through Upwork for this one.
@sakluger could you please check this comment? If there is still any issue, I'm happy to proceed with Upwork. I have not declined the offer this time 😅. Thanks!
I looked into this, and @Krishna2323, your eligibility date for NewDot payments is 2025-02-15. So while you might have only been set up recently, that's the date to consider when deciding to cancel an Upwork contract to be paid in NewDot instead.
This issue, and the two other issues you referenced above, were all contracted after the eligibility date. We can proceed with ND payments for these. 👍
Thanks for pointing me to that comment, you're correct! Our internal documentation listed the wrong eligibility date, so I've updated our documentation.
I withdrew the Upwork contract and updated the payment summary above so you can request payment via NewDot.
Activity
melvin-bot commentedon Jul 9, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (
External)melvin-bot commentedon Jul 9, 2025
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Krishna2323 commentedon Jul 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Stop showing RTER violation on the reports page for paid transactions
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
shouldShowViolation, name itshouldShowRterForSettledand default it to true. Then update the function to only filter out the rter violation ifshouldShowRterForSettledis false.App/src/libs/TransactionUtils/index.ts
Lines 987 to 1012 in d212634
useTransactionViolations, name itshouldShowRterForSettled, default it totrueand pass it as the last param ofshouldShowViolation.App/src/hooks/useTransactionViolations.ts
Lines 8 to 28 in d212634
TransactionItemRowRBRWithOnyxpass false for theshouldShowRterForPaidparam touseTransactionViolations.App/src/components/TransactionItemRow/TransactionItemRowRBRWithOnyx.tsx
Line 30 in d212634
shouldShowViolation, we can directly filter that when running filter method inuseTransactionViolationshook.App/src/hooks/useTransactionViolations.ts
Lines 22 to 25 in 1adf0bf
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
shouldShowViolationif we decide to update that.What alternative solutions did you explore? (Optional)
useTransactionViolationsand pass the filtered violations togetRBRMessages.App/src/components/TransactionItemRow/TransactionItemRowRBRWithOnyx.tsx
Lines 30 to 38 in d212634
Result
sakluger commentedon Jul 11, 2025
Hey @Pujan92, could you please review the proposal above? Thanks!
nkdengineer commentedon Jul 15, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Stop showing RTER violation on the reports page for paid transactions
What is the root cause of that problem?
The violation is getting from
useTransactionViolationsand we don't have the logic to filter out theRTERviolation if the transaction is paidApp/src/hooks/useTransactionViolations.ts
Line 23 in 1adf0bf
App/src/libs/TransactionUtils/index.ts
Lines 990 to 1020 in 1adf0bf
What changes do you think we should make in order to solve the problem?
We already have a case for
RTERviolation inshouldShowViolationfunction, we only need to add a condition to not show this violation if the report is settledApp/src/libs/TransactionUtils/index.ts
Lines 990 to 1020 in 1adf0bf
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can write the unit test for
shouldShowViolationand verify that theRTERviolation returnfalseif the report is paid.What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Krishna2323 commentedon Jul 15, 2025
PROPOSAL UPDATED
useTransactionViolationsis change recently. The solution is still almost the same.melvin-bot commentedon Jul 15, 2025
@Pujan92 Huh... This is 4 days overdue. Who can take care of this?
Pujan92 commentedon Jul 15, 2025
I am reviewing it Melvin..
22 remaining items
melvin-bot commentedon Jul 25, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.85-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-08-01. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 25, 2025
@Pujan92 @sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Pujan92 commentedon Jul 31, 2025
We don't need a checklist here as it is a new change.
sakluger commentedon Aug 1, 2025
Payment Summary
Contributor: @Krishna2323 $250 via NewDot
Contributor+: @Pujan92 $250 via Newdot
melvin-bot commentedon Aug 1, 2025
Payment Summary
Upwork Job
BugZero Checklist (@sakluger)
Krishna2323 commentedon Aug 2, 2025
@sakluger I'm now eligible for NewDot payments, so I've declined the Upwork contract. Apologies for not mentioning it earlier.
sakluger commentedon Aug 2, 2025
Hi @Krishna2323, it looks like you became eligible for NewDot payments on July 22, but since you were assigned to this issue on July 16, before eligibility kicked in, we’ll still need to process payment through Upwork for this one.
Here's the new offer: https://www.upwork.com/nx/wm/offer/108273149
Krishna2323 commentedon Aug 2, 2025
@sakluger could you please check this comment? If there is still any issue, I'm happy to proceed with Upwork. I have not declined the offer this time 😅. Thanks!
sakluger commentedon Aug 4, 2025
Thanks for pointing me to that comment, you're correct! Our internal documentation listed the wrong eligibility date, so I've updated our documentation.
I withdrew the Upwork contract and updated the payment summary above so you can request payment via NewDot.
Krishna2323 commentedon Aug 4, 2025
Requested in NewDot.
isabelastisser commentedon Aug 5, 2025
@Pujan92 has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Vendor found in VML: True. Status: Active
Amount requested: $250.00. Matches the payment summary here.
I am not already the BZ assignee, so I have approved this payment.
flaviadefaria commentedon Aug 13, 2025
$250 approved for @Krishna2323