You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-08-13] [$250] Import Contacts - Unable to find imported contacts in Start Chat #65916
We can move this logic to separe hook and use on other pages
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Import Contacts - Unable to find imported contacts in Start Chat[/-][+][$250] Import Contacts - Unable to find imported contacts in Start Chat[/+]on Jul 12, 2025
Please re-state the problem that we are trying to solve in this issue.
Users can't find their phone contacts when starting a new chat. The "Start Chat" page only shows people from the server, but not contacts from their phone's contact list.
What is the root cause of that problem?
The NewChatPage doesn't connect to the user's phone contacts. While the app has contact import features that work in other places (like when adding people to expense reports), this feature isn't enabled on the Start Chat page. The existing contact system (contactImport, getContacts, useContactPermissions) works in MoneyRequestParticipantsSelector but isn't integrated into the NewChatPage.
What changes do you think we should make in order to solve the problem?
Add contact import to the Start Chat page - Use the existing contact system that already works in other parts of the app
Show an "Import Contacts" button - When users haven't given permission to access their contacts
Ask for permission - Show a popup asking users if they want to share their contacts
Display imported contacts - Show phone contacts alongside existing contacts in the search results
Technical implementation:
Extend the useOptions hook in NewChatPage to include contact management
Add ContactPermissionModal for permission handling
Modify the defaultOptions to include device contacts with server contacts
Add "Import Contacts" button to footer when permission not granted
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Basic Tests:
Test that the "Import Contacts" button appears when needed
Test that contacts show up in search results after import
Test that the permission popup works correctly
Test that imported contacts can be selected for chat
Edge Cases:
Test what happens when user denies contact permission
Test with empty contact list
Test with very large contact lists
Test on both iOS and Android
Test that imported contacts don't duplicate existing server contacts
What alternative solutions did you explore? (Optional)
Server-side contact sync: Too complex and privacy concerns
Separate contacts tab: Would make the interface confusing
Manual contact entry: Doesn't solve the problem of finding existing contacts
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
📣 @aybanda! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.89-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jayeshmangwani@Christinadobrzyn The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
@Christinadobrzyn This issue is more of a feature request, as we haven’t implemented imported contacts on the new chat page. Therefore, I’m proposing a regression test instead of the checklist.
Activity
melvin-bot commentedon Jul 11, 2025
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Eskalifer1 commentedon Jul 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Import Contacts - Unable to find imported contacts in Start Chat
What is the root cause of that problem?
We currently do not have logic for contacts on the new Chat page
What changes do you think we should make in order to solve the problem?
We need to modify the useOptions hook on the newChat page:
App/src/pages/NewChatPage.tsx
Lines 52 to 144 in 7be2292
Add a state for constacts and their setting:
Then add them to defaultOptions:
We can move this logic to separe hook and use on other pages
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Import Contacts - Unable to find imported contacts in Start Chat[/-][+][$250] Import Contacts - Unable to find imported contacts in Start Chat[/+]melvin-bot commentedon Jul 12, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021944119156196629279
melvin-bot commentedon Jul 12, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)aybanda commentedon Jul 13, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Users can't find their phone contacts when starting a new chat. The "Start Chat" page only shows people from the server, but not contacts from their phone's contact list.
What is the root cause of that problem?
The NewChatPage doesn't connect to the user's phone contacts. While the app has contact import features that work in other places (like when adding people to expense reports), this feature isn't enabled on the Start Chat page. The existing contact system (
contactImport,getContacts,useContactPermissions) works inMoneyRequestParticipantsSelectorbut isn't integrated into the NewChatPage.What changes do you think we should make in order to solve the problem?
Technical implementation:
useOptionshook in NewChatPage to include contact managementContactPermissionModalfor permission handlingdefaultOptionsto include device contacts with server contactsWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Basic Tests:
Edge Cases:
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Jul 13, 2025
📣 @aybanda! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
aybanda commentedon Jul 13, 2025
Contributor details
Your Expensify account email: jsaj2024@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0128101ae814719134
37 remaining items
melvin-bot commentedon Aug 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.89-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-08-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 6, 2025
@jayeshmangwani @Christinadobrzyn The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Christinadobrzyn commentedon Aug 11, 2025
Payment coming up soon!
jayeshmangwani commentedon Aug 13, 2025
@Christinadobrzyn This issue is more of a feature request, as we haven’t implemented imported contacts on the new chat page. Therefore, I’m proposing a regression test instead of the checklist.
jayeshmangwani commentedon Aug 13, 2025
Regression Test Proposal
Preconditions:
Steps:
Do we agree 👍 or 👎
Christinadobrzyn commentedon Aug 13, 2025
Thanks @jayeshmangwani!
@Eskalifer1 can you please accept the Upwork offer https://www.upwork.com/nx/wm/offer/108406607
melvin-bot commentedon Aug 13, 2025
Payment Summary
Upwork Job
BugZero Checklist (@Christinadobrzyn)
Eskalifer1 commentedon Aug 14, 2025
Sorry for the delay, I accepted the offer last night, but because I was sleepy, I forgot to reply.
cc: @Christinadobrzyn
Christinadobrzyn commentedon Aug 14, 2025
No worries @Eskalifer1! I've paid you through Upwork.
@jayeshmangwani please make sure to request payment - payment summary is here - #65916 (comment)
Closing!
twisterdotcom commentedon Aug 27, 2025
@jayeshmangwani has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-1b03-a856-95e7-8f7026de3431