You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Payment Buttons] Reports - "Pay with personal account" button is present when the invoice room is a B2B room #65978
Version Number: 9.1.80-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from TestRail:#65296 Email or phone of affected tester (no customers):applausetester+sdsdk903s@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.expensify.com
[User A] Send an invoice to User B.
[User B] Open the invoice room.
[User B] Click Pay on the invoice preview > Pay as a business > Mark as paid.
[User A] Send another invoice to User B.
[User B] Click Pay dropdown button on the invoice preview.
→ There is only Add bank account and Mark as paid button.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
feat: standardize pay button #65296: Overhauled SettlementButton, usePaymentOptions, PaymentUtils and related logic used to build the Pay dropdown, so it could mistakenly include the ‘Pay with personal account’ option in a B2B invoice room.
fix: replace dropdown menu when only one option #65390: Changed ButtonWithDropdownMenu behaviour for single-option pay buttons, which may alter the options rendered and unintentionally surface the personal-account choice.
If not above, check these
[NO QA] rename props #65831: Follow-up refactor of ButtonWithDropdownMenu props touches the same pay-button component and could contribute to incorrect option display.
changed the title [-]Reports - "Pay with personal account" button is present when the invoice room is a B2B room[/-][+][Payment Buttons] Reports - "Pay with personal account" button is present when the invoice room is a B2B room[/+]on Jul 14, 2025
Activity
melvin-bot commentedon Jul 11, 2025
Triggered auto assignment to @maddylewis (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 11, 2025
Triggered auto assignment to @inimaga (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 11, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 11, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
rushatgabhane commentedon Jul 11, 2025
@BlameGPT find the prs pls
BlameGPT commentedon Jul 11, 2025
Sus PRs on the scene
If not above, check these
hungvu193 commentedon Jul 12, 2025
cc @grgia @joekaufmanexpensify @getusha
We were already aware of this case. Let's demote it.
inimaga commentedon Jul 14, 2025
@hungvu193 Does that mean you're planning on handling it with other regressions from the offending PR?
hungvu193 commentedon Jul 14, 2025
@inimaga Yes, please demote it. This is BE issue and I believe @grgia is working on it.
grgia commentedon Jul 14, 2025
@hungvu193 wouldn't this be FE not BE if we just need to hide the menuitem for this case?
[-]Reports - "Pay with personal account" button is present when the invoice room is a B2B room[/-][+][Payment Buttons] Reports - "Pay with personal account" button is present when the invoice room is a B2B room[/+]luacmartins commentedon Jul 15, 2025
We reverted the offending PR. Closing
joekaufmanexpensify commentedon Aug 11, 2025
Noting per this that this one is one we need to make sure is fixed in our next iteration of merging the invoices pay changes
hungvu193 commentedon Oct 10, 2025
will be fixed in #71748
joekaufmanexpensify commentedon Oct 14, 2025
Tested on the adhoc in #71748 and confirmed not happening there 👍