Skip to content

[Payment Buttons] Reports - "Pay with personal account" button is present when the invoice room is a B2B room #65978

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.80-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #65296
Email or phone of affected tester (no customers): applausetester+sdsdk903s@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.expensify.com
  2. [User A] Send an invoice to User B.
  3. [User B] Open the invoice room.
  4. [User B] Click Pay on the invoice preview > Pay as a business > Mark as paid.
  5. [User A] Send another invoice to User B.
  6. [User B] Click Pay dropdown button on the invoice preview.
    → There is only Add bank account and Mark as paid button.
  7. [User B] Go to Reports.
  8. [User B] Click Type: Expense > Select Invoice > Click Apply.
  9. [User B] Click Pay dropdown button.

Expected Result:

"Pay with personal account" button should not exist because the invoice room is now a B2B room (because user paid as a business from Step 4).

Actual Result:

"Pay with personal account" button is present when the invoice room is a B2B room.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 11, 2025
  2. melvin-bot commented on Jul 11, 2025

    @melvin-bot

    Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jul 11, 2025

    @melvin-bot

    Triggered auto assignment to @inimaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jul 11, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jul 11, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. rushatgabhane commented on Jul 11, 2025

    @rushatgabhane
    Member

    @BlameGPT find the prs pls

  7. BlameGPT commented on Jul 11, 2025

    @BlameGPT
    Contributor

    Sus PRs on the scene

    • feat: standardize pay button #65296: Overhauled SettlementButton, usePaymentOptions, PaymentUtils and related logic used to build the Pay dropdown, so it could mistakenly include the ‘Pay with personal account’ option in a B2B invoice room.
    • fix: replace dropdown menu when only one option #65390: Changed ButtonWithDropdownMenu behaviour for single-option pay buttons, which may alter the options rendered and unintentionally surface the personal-account choice.

    If not above, check these

    • [NO QA] rename props #65831: Follow-up refactor of ButtonWithDropdownMenu props touches the same pay-button component and could contribute to incorrect option display.
  8. hungvu193 commented on Jul 12, 2025

    @hungvu193
    Contributor

    cc @grgia @joekaufmanexpensify @getusha
    We were already aware of this case. Let's demote it.

  9. inimaga commented on Jul 14, 2025

    @inimaga
    Contributor

    @hungvu193 Does that mean you're planning on handling it with other regressions from the offending PR?

  10. hungvu193 commented on Jul 14, 2025

    @hungvu193
    Contributor

    @inimaga Yes, please demote it. This is BE issue and I believe @grgia is working on it.

  11. assigned and unassigned on Jul 14, 2025
  12. grgia commented on Jul 14, 2025

    @grgia
    Contributor

    @hungvu193 wouldn't this be FE not BE if we just need to hide the menuitem for this case?

  13. removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jul 14, 2025
  14. changed the title [-]Reports - "Pay with personal account" button is present when the invoice room is a B2B room[/-] [+][Payment Buttons] Reports - "Pay with personal account" button is present when the invoice room is a B2B room[/+] on Jul 14, 2025
  15. luacmartins commented on Jul 15, 2025

    @luacmartins
    Contributor

    We reverted the offending PR. Closing

  16. joekaufmanexpensify commented on Aug 11, 2025

    @joekaufmanexpensify
    Contributor

    Noting per this that this one is one we need to make sure is fixed in our next iteration of merging the invoices pay changes

  17. hungvu193 commented on Oct 10, 2025

    @hungvu193
    Contributor

    will be fixed in #71748

  18. joekaufmanexpensify commented on Oct 14, 2025

    @joekaufmanexpensify
    Contributor

    Tested on the adhoc in #71748 and confirmed not happening there 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions