Skip to content

[Due for payment 2025-07-23] [Due for payment 2025-07-22] Missing Copy on Tag Import Screen #65993

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.80-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #65827
Email or phone of affected tester (no customers): applausetester+dp237@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 12 / iOS 18.5
App Component: Other

Action Performed:

1, Open app
2. Go to Workspace > Tags
3. Tap More > Import Tags
4. Select Multi-Level Tag option

Expected Result:

Import screen displays the following instructional copy:

“Select a spreadsheet file to import. Learn more about supported file formats.”

Actual Result:

Instructional copy is missing from the import screen

P.S. Actually copy disappeared for Single level tags too comparing to production.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 12, 2025
  2. github-actions commented on Jul 12, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on Jul 12, 2025

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jul 12, 2025

    @melvin-bot

    Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Jul 12, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. rushatgabhane commented on Jul 12, 2025

    @rushatgabhane
    Member

    @BlameGPT find the culprits

  7. BlameGPT commented on Jul 12, 2025

    @BlameGPT
    Contributor

    Sus PRs on the scene

    If not above, check these

    • Chore: follow ups and cleanup pt 1 #65847: Updated CONST and translation files for ‘Learn more about supported formats’ wording which ImportSpreadsheet also references, so it could inadvertently clear or mismatch the string shown on the tag import screen.
  8. PiyushChandra17 commented on Jul 12, 2025

    @PiyushChandra17
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Missing Copy on Tag Import Screen

    What is the root cause of that problem?

    The root cause is this style > styles.uploadFileViewTextContainer

    style={[styles.uploadFileViewTextContainer, styles.userSelectNone]}

    What changes do you think we should make in order to solve the problem?

    If we remove that style, styles.uploadFileViewTextContainer, we get the text back

    • We need to update this styles.uploadFileViewTextContainer accordingly for small screenwidth

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Or we can create mobileView

    const mobileView = (
            <>
                <View onLayout={({nativeEvent}) => setFileTopPosition(PixelRatio.roundToNearestPixel((nativeEvent.layout as DOMRect).top))}>
                    <ImageSVG
                        src={Expensicons.SpreadsheetComputer}
                        contentFit="contain"
                        style={styles.mb4}
                        width={CONST.IMPORT_SPREADSHEET.ICON_WIDTH}
                        height={CONST.IMPORT_SPREADSHEET.ICON_HEIGHT}
                    />
                </View>
                {/* <View
                    style={[styles.userSelectNone]}
                    // eslint-disable-next-line react-compiler/react-compiler, react/jsx-props-no-spreading
                    {...panResponder.panHandlers}
                > */}
                <Text style={[styles.textFileUpload, styles.mb1]}>{spreadsheet?.isImportingMultiLevelTags ? translate('spreadsheet.import') : translate('spreadsheet.upload')}</Text>
                {isSmallScreenWidth && <RenderHTML html={getTextForImportModal()} />}
                {/* </View> */}
    
                <FilePicker acceptableFileTypes={acceptableFileTypes}>
                    {({openPicker}) => (
                        <Button
                            success
                            text={translate('common.chooseFile')}
                            accessibilityLabel={translate('common.chooseFile')}
                            style={[styles.pt9]}
                            isLoading={isReadingFile}
                            onPress={() => {
                                openPicker({
                                    onPicked: (file) => {
                                        readFile(file as File);
                                    },
                                });
                            }}
                        />
                    )}
                </FilePicker>
            </>
        );

    And use this here,

    {!(isDraggingOver ?? isDraggingOver) && desktopView}

     {!isDraggingOver && (isSmallScreenWidth ? mobileView : desktopView)}

    Result

    Image

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  9. 5 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 15, 2025
  11. changed the title [-]Missing Copy on Tag Import Screen[/-] [+][Due for payment 2025-07-22] Missing Copy on Tag Import Screen[/+] on Jul 15, 2025
  12. melvin-bot commented on Jul 15, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jul 15, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.80-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-22. 🎊

  14. melvin-bot commented on Jul 15, 2025

    @melvin-bot

    @MonilBhavsar @isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. changed the title [-][Due for payment 2025-07-22] Missing Copy on Tag Import Screen[/-] [+][Due for payment 2025-07-23] [Due for payment 2025-07-22] Missing Copy on Tag Import Screen[/+] on Jul 16, 2025
  16. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.81-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-23. 🎊

  17. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    @MonilBhavsar @isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions